From e0c361ec77e4e63bd8ddea0d037e7d5bc1b158be Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Mon, 13 Apr 2026 16:03:02 -0700 Subject: [PATCH] fix(weed/worker/tasks): log dropped errors (#9057) --- weed/worker/tasks/task_logger.go | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/weed/worker/tasks/task_logger.go b/weed/worker/tasks/task_logger.go index 90383c769..975e12f84 100644 --- a/weed/worker/tasks/task_logger.go +++ b/weed/worker/tasks/task_logger.go @@ -199,7 +199,10 @@ func (l *FileTaskLogger) LogProgress(progress float64, message string) { } l.writeLogEntry(entry) - l.saveMetadata() // Update metadata with new progress + // Update metadata with new progress + if err := l.saveMetadata(); err != nil { + glog.Warningf("Failed to save initial task metadata: %v", err) + } } // LogStatus logs task status change @@ -216,7 +219,10 @@ func (l *FileTaskLogger) LogStatus(status string, message string) { } l.writeLogEntry(entry) - l.saveMetadata() // Update metadata with new status + // Update metadata with new status + if err := l.saveMetadata(); err != nil { + glog.Warningf("Failed to update metadata with new status: %v", err) + } } // LogWithFields logs a message with structured fields @@ -263,7 +269,9 @@ func (l *FileTaskLogger) Close() error { } // Save final metadata - l.saveMetadata() + if err := l.saveMetadata(); err != nil { + glog.Warningf("Failed to save final task metadata: %v", err) + } // Close log file if l.logFile != nil {