From e8806d97fdc885534f94d44bd60f2fa545364f7c Mon Sep 17 00:00:00 2001 From: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.com> Date: Tue, 9 Jul 2024 16:34:32 +0500 Subject: [PATCH] revert skip deletion error, since the error file was not found is already skipped on the side of the grpc function --- weed/s3api/s3api_object_handlers_delete.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/weed/s3api/s3api_object_handlers_delete.go b/weed/s3api/s3api_object_handlers_delete.go index 43849bb07..4b0e55bd7 100644 --- a/weed/s3api/s3api_object_handlers_delete.go +++ b/weed/s3api/s3api_object_handlers_delete.go @@ -32,10 +32,9 @@ func (s3a *S3ApiServer) DeleteObjectHandler(w http.ResponseWriter, r *http.Reque s3a.WithFilerClient(false, func(client filer_pb.SeaweedFilerClient) error { - err := doDeleteEntry(client, dir, name, true, false) - if err != nil { - // skip deletion error, usually the file is not found - return nil + if err := doDeleteEntry(client, dir, name, true, false); err != nil { + w.WriteHeader(http.StatusInternalServerError) + return err } if s3a.option.AllowEmptyFolder {