mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-05-25 11:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,756 Commits 149 Branches 341 Tags
fix-GetObjectLockConfigurationHandler
Commit Graph

10 Commits

Author SHA1 Message Date
chrislu
11fb65571f refactor 2025-07-19 00:42:43 -07:00
chrislu
1d1c717493 refactor 2025-07-18 20:16:04 -07:00
chrislu
7661449f82 fix tests 2025-07-18 20:10:16 -07:00
chrislu
7203c78e4d constants and fixes 
✅ Return InvalidRetentionPeriod for invalid retention values (0 days, negative years)
✅ Return ObjectLockConfigurationNotFoundError when object lock configuration doesn't exist
✅ Handle all object lock validation errors consistently with proper error codes
 2025-07-18 15:58:07 -07:00
chrislu
9f88fd2ea5 fixes 
With these comprehensive fixes, the s3-tests should now:
✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets
✅ Return InvalidRetentionPeriod for invalid retention periods
✅ Return MalformedXML for malformed retention configurations
✅ Include VersionId in response headers when available
✅ Return proper HTTP status codes for all error conditions
✅ Handle all object lock validation errors consistently
The workflow should now pass significantly more object lock tests, bringing SeaweedFS's S3 object lock implementation much closer to AWS S3 compatibility standards.
 2025-07-18 15:45:15 -07:00
chrislu
4b92f03b65 address test errors 2025-07-18 15:33:44 -07:00
chrislu
3fbab20b83 refactor 2025-07-18 00:34:16 -07:00
chrislu
7bec2ef94b cache and use bucket object lock config 2025-07-18 00:19:47 -07:00
chrislu
f9cbed7ee1 fix GetObjectLockConfigurationHandler 2025-07-17 23:12:19 -07:00
Chris Lu
1549ee2e15 implement PubObjectRetention and WORM (#6969) 
* implement PubObjectRetention and WORM

* Update s3_worm_integration_test.go

* avoid previous buckets

* Update s3-versioning-tests.yml

* address comments

* address comments

* rename to ExtObjectLockModeKey

* only checkObjectLockPermissions if versioningEnabled

* address comments

* comments

* Revert "comments"

This reverts commit 6736434176.

* Update s3api_object_handlers_skip.go

* Update s3api_object_retention_test.go

* add version id to ObjectIdentifier

* address comments

* add comments

* Add proper error logging for timestamp parsing failures

* address comments

* add version id to the error

* Update weed/s3api/s3api_object_retention_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update weed/s3api/s3api_object_retention.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* constants

* fix comments

* address comments

* address comment

* refactor out handleObjectLockAvailabilityCheck

* errors.Is ErrBucketNotFound

* better error checking

* address comments

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-07-12 21:58:55 -07:00