mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-07-20 15:02:27 +00:00
Chris Lu
d57de6dc20
fix(s3): keep anonymous access working with EnableIam default `docker run seaweedfs` (and `weed mini` with no config) start with EnableIam=true but no IAM config file and no identities. The advanced-IAM init path was failing in 4.25 because of the missing STS signing key, which masked a latent bug: SetIAMIntegration unconditionally flipped isAuthEnabled to true, and isEnabled() also treated a non-nil iamIntegration as auth-on. Once the mini SSE-S3 KEK landed in 4.26 the STS fallback started succeeding, the integration got installed end to end, and every anonymous S3 request bounced as AccessDenied. Separate the two concerns: SetIAMIntegration just plumbs in the OIDC / embedded-IAM machinery, and a new EnableAuthEnforcement opts in to enforcement. The startup path calls it only when -s3.iam.config is actually provided, so operators with explicit IAM configs still get auth (preserves #7726). isEnabled() now reads isAuthEnabled only.
77 lines
2.8 KiB
Go
77 lines
2.8 KiB
Go
package s3api
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/credential"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// resetMemoryStore resets the shared in-memory credential store so that tests
|
|
// that rely on an empty store are not polluted by earlier tests.
|
|
func resetMemoryStore() {
|
|
for _, store := range credential.Stores {
|
|
if store.GetName() == credential.StoreTypeMemory {
|
|
if resettable, ok := store.(interface{ Reset() }); ok {
|
|
resettable.Reset()
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestLoadIAMManagerWithNoConfig(t *testing.T) {
|
|
// Verify that IAM can be initialized without any config
|
|
option := &S3ApiServerOption{
|
|
Config: "",
|
|
}
|
|
iamManager := NewIdentityAccessManagementWithStore(option, nil, "memory")
|
|
assert.NotNil(t, iamManager)
|
|
// Internal state might be hard to access directly, but successful init implies defaults worked.
|
|
}
|
|
|
|
func TestLoadIAMManagerFromConfig_EmptyConfigWithFallbackKey(t *testing.T) {
|
|
// Reset the shared memory store to avoid state leaking from other tests.
|
|
resetMemoryStore()
|
|
|
|
// Initialize IAM with empty config — no anonymous identity is configured,
|
|
// so LookupAnonymous should return not-found.
|
|
option := &S3ApiServerOption{
|
|
Config: "",
|
|
IamConfig: "",
|
|
EnableIam: true,
|
|
}
|
|
iamManager := NewIdentityAccessManagementWithStore(option, nil, "memory")
|
|
|
|
_, found := iamManager.LookupAnonymous()
|
|
assert.False(t, found, "Anonymous identity should not be found when not explicitly configured")
|
|
}
|
|
|
|
// TestSetIAMIntegrationKeepsAuthDisabledWithoutConfig is a regression test for
|
|
// issue #9557. The `weed mini` defaults (and the bare `docker run seaweedfs`
|
|
// image) start with EnableIam=true but no IAM config file and no identities.
|
|
// The advanced-IAM init path used to also flip isAuthEnabled to true via
|
|
// SetIAMIntegration, which then rejected every anonymous request as
|
|
// AccessDenied — breaking out-of-the-box S3 access. Setting an integration
|
|
// must not, on its own, enable auth enforcement; explicit configs use
|
|
// EnableAuthEnforcement to opt in.
|
|
func TestSetIAMIntegrationKeepsAuthDisabledWithoutConfig(t *testing.T) {
|
|
resetMemoryStore()
|
|
|
|
option := &S3ApiServerOption{
|
|
EnableIam: true,
|
|
}
|
|
iam := NewIdentityAccessManagementWithStore(option, nil, "memory")
|
|
|
|
// Simulate an integration object being plugged in (the constructor in
|
|
// s3api_server.go does this when EnableIam=true, even with no config file).
|
|
// We only care that auth stays off — the integration value itself is opaque.
|
|
iam.SetIAMIntegration(&S3IAMIntegration{})
|
|
|
|
assert.False(t, iam.isEnabled(), "Auth must stay disabled when no identities and no IamConfig are configured")
|
|
|
|
// And EnableAuthEnforcement does flip it on — this is what the startup
|
|
// path runs when the operator explicitly passes -s3.iam.config.
|
|
iam.EnableAuthEnforcement()
|
|
assert.True(t, iam.isEnabled(), "EnableAuthEnforcement must turn auth on")
|
|
}
|