mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-17 04:36:50 +00:00
* feat(s3/lifecycle/engine): daily-replay view surface (Phase 4 engine) Adds the engine-side API the new daily-replay worker reaches for: per-view snapshot construction (RulesForShard, RecoveryView), the two cursor hashes that gate recovery (ReplayContentHash, PromotedHash), and the cursor sliding-window helper (MaxEffectiveTTL). CurrentSnapshot is a stub keyed on a package-level atomic that the worker startup wiring populates. Views return new *Snapshot instances holding cloned *CompiledAction values so per-clone active/Mode never leak across partitions. Replay clones force Mode=ModeEventDriven to rehabilitate any persistent ModeScanOnly carried over from PriorState; walk and recovery clones preserve Mode as-is. Disabled actions are excluded from all views. No production caller is wired here — Phase 4's walker/dailyrun integration is the follow-up. dailyrun's local helpers (localReplayContentHash, localMaxEffectiveTTL) become one-line redirects to these exports. API surface: - CurrentSnapshot() *Snapshot — stub until Phase 4 wiring. - SetCurrentEngine(*Engine) — Phase 4 wiring entry point. - Snapshot.RulesForShard(shardID, retentionWindow) (replay, walk *Snapshot) - RecoveryView(s *Snapshot) *Snapshot — force-active over the full set. - ReplayContentHash(s *Snapshot) [32]byte — partition-independent. - PromotedHash(s *Snapshot, retentionWindow) [32]byte — partition-flip. - MaxEffectiveTTL(s *Snapshot) time.Duration — over active replay only. 30 unit tests covering clone isolation, Mode rewrite, partition membership including the multi-action-kind XML rule split, RecoveryView activating pre-BootstrapComplete actions, ReplayContentHash partition-independence, PromotedHash sensitivity to promotion in either direction, MaxEffectiveTTL aggregation. Build + race-tests green. * refactor(s3/lifecycle/engine): consolidate hash helpers; clarify shardID semantics Addresses PR #9447 review feedback. Three medium-priority items from gemini, all code-quality refinements (no behavior change): 1. Duplicated sort comparator between ReplayContentHash and PromotedHash. Extract sortHashItems shared helper so the two hashes use the same ordering by construction — if one drifted, the cursor could see a spurious "rule changed" on a no-op snapshot rebuild. 2. Duplicated writeField/writeInt closures. Extract hashWriter struct holding the sha256 running hash + lenbuf, with method helpers. Same allocation profile (one Hash, one tiny stack buffer per helper); just deduplicates ~20 lines. 3. shardID parameter on RulesForShard is unused. Per the design's open question, every shard sees every rule today (shard filter runs at the entry-iteration site, not view construction). Keep the parameter for API stability — removing it now would force a breaking change when bucket-shard ownership lands — and update the doc comment to explain why it's reserved. go build ./... clean; engine test suite green.
206 lines
6.6 KiB
Go
206 lines
6.6 KiB
Go
package engine
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/sha256"
|
|
"encoding/binary"
|
|
"hash"
|
|
"sort"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3lifecycle"
|
|
)
|
|
|
|
// hashItem pairs a ruleset member with its parent action so the
|
|
// sort+hash helpers below can be type-agnostic. Internal type — every
|
|
// hash callsite collects items into a slice, then hands it off.
|
|
type hashItem struct {
|
|
key s3lifecycle.ActionKey
|
|
action *CompiledAction
|
|
}
|
|
|
|
// sortHashItems orders items by (RuleHash, ActionKind, Bucket). The
|
|
// composition matches the ActionKey identity model: RuleHash is the
|
|
// primary content-derived identifier, ActionKind disambiguates siblings
|
|
// of one rule, Bucket scopes by bucket so the same XML in two buckets
|
|
// hashes distinctly. Shared between ReplayContentHash and PromotedHash
|
|
// so the two helpers agree on the on-wire ordering — if one drifted,
|
|
// the cursor could see "rule changed" on a no-op snapshot rebuild.
|
|
func sortHashItems(items []hashItem) {
|
|
sort.Slice(items, func(i, j int) bool {
|
|
if c := bytes.Compare(items[i].key.RuleHash[:], items[j].key.RuleHash[:]); c != 0 {
|
|
return c < 0
|
|
}
|
|
if items[i].key.ActionKind != items[j].key.ActionKind {
|
|
return items[i].key.ActionKind < items[j].key.ActionKind
|
|
}
|
|
return items[i].key.Bucket < items[j].key.Bucket
|
|
})
|
|
}
|
|
|
|
// hashWriter is the small varint-tagged writer the hash helpers use.
|
|
// Each field gets a one-byte tag so a future schema change (new field)
|
|
// can extend the on-wire format without colliding with existing values.
|
|
type hashWriter struct {
|
|
h hash.Hash
|
|
lenbuf [binary.MaxVarintLen64]byte
|
|
}
|
|
|
|
func newHashWriter() *hashWriter {
|
|
return &hashWriter{h: sha256.New()}
|
|
}
|
|
|
|
// writeField writes a length-prefixed byte field under tag.
|
|
func (w *hashWriter) writeField(tag byte, b []byte) {
|
|
_, _ = w.h.Write([]byte{tag})
|
|
n := binary.PutUvarint(w.lenbuf[:], uint64(len(b)))
|
|
_, _ = w.h.Write(w.lenbuf[:n])
|
|
_, _ = w.h.Write(b)
|
|
}
|
|
|
|
// writeInt writes a varint-encoded signed integer under tag.
|
|
func (w *hashWriter) writeInt(tag byte, v int64) {
|
|
_, _ = w.h.Write([]byte{tag})
|
|
n := binary.PutVarint(w.lenbuf[:], v)
|
|
_, _ = w.h.Write(w.lenbuf[:n])
|
|
}
|
|
|
|
func (w *hashWriter) sum() [32]byte {
|
|
var out [32]byte
|
|
copy(out[:], w.h.Sum(nil))
|
|
return out
|
|
}
|
|
|
|
// ReplayContentHash hashes the content (action kind, predicate, TTL value)
|
|
// of every replay-eligible compiled action in the base snapshot, returning
|
|
// the empty hash when no replay-eligible action exists. The hash is:
|
|
// - Partition-independent. A retention-driven scan_only promotion does
|
|
// NOT change this hash; only the dispatch path changes, not the rule
|
|
// content. (PromotedHash exists to catch partition flips separately.)
|
|
// - Stable across snapshot reorderings. Actions are pre-sorted by
|
|
// RuleHash + ActionKind + Bucket so two snapshots with the same rules
|
|
// compiled in any order hash identically.
|
|
// - Disabled-rule-aware. ModeDisabled actions are excluded so disabling
|
|
// a rule changes the hash (it changed the rule set the worker is
|
|
// scanning under).
|
|
//
|
|
// Used as cursor.RuleSetHash. A mismatch between persisted and current
|
|
// triggers the recovery branch on next daily_run.
|
|
func ReplayContentHash(s *Snapshot) [32]byte {
|
|
var empty [32]byte
|
|
if s == nil {
|
|
return empty
|
|
}
|
|
var items []hashItem
|
|
for k, a := range s.actions {
|
|
if a == nil || a.Mode == ModeDisabled {
|
|
continue
|
|
}
|
|
if !isReplayKind(k.ActionKind) {
|
|
continue
|
|
}
|
|
items = append(items, hashItem{key: k, action: a})
|
|
}
|
|
if len(items) == 0 {
|
|
return empty
|
|
}
|
|
sortHashItems(items)
|
|
|
|
w := newHashWriter()
|
|
for _, it := range items {
|
|
w.writeField(0x01, []byte(it.key.Bucket))
|
|
w.writeField(0x02, it.key.RuleHash[:])
|
|
w.writeInt(0x03, int64(it.key.ActionKind))
|
|
// RuleHash already covers the predicate (Prefix + FilterTags + size
|
|
// filters) and per-kind TTLs, so we don't need to re-canonicalise
|
|
// the *Rule. But we also include the action's effective TTL
|
|
// directly so that an "effective TTL of 0" (a malformed rule where
|
|
// the kind doesn't match the populated field) is distinguishable
|
|
// from a valid one.
|
|
w.writeInt(0x04, int64(effectiveTTL(it.action)))
|
|
}
|
|
return w.sum()
|
|
}
|
|
|
|
// PromotedHash hashes the set of replay-eligible actions that *would* land
|
|
// in walk (rather than replay) for the given retentionWindow, due to TTL >
|
|
// retentionWindow. Empty hash when no rules are promoted. Takes the SAME
|
|
// retentionWindow value as RulesForShard so the two helpers cannot disagree
|
|
// about partition membership.
|
|
//
|
|
// Detects partition flips in either direction:
|
|
// - replay → walk (retention dropped): rule appears in this hash but
|
|
// didn't before.
|
|
// - walk → replay (retention recovered): rule used to appear here but no
|
|
// longer does.
|
|
//
|
|
// In both cases the persisted hash differs from the freshly computed one,
|
|
// firing the recovery branch.
|
|
//
|
|
// A mismatch with the persisted PromotedHash triggers recovery even when
|
|
// rule content is unchanged.
|
|
func PromotedHash(s *Snapshot, retentionWindow time.Duration) [32]byte {
|
|
var empty [32]byte
|
|
if s == nil {
|
|
return empty
|
|
}
|
|
var items []hashItem
|
|
for k, a := range s.actions {
|
|
if a == nil || a.Mode == ModeDisabled {
|
|
continue
|
|
}
|
|
if !isReplayKind(k.ActionKind) {
|
|
continue
|
|
}
|
|
ttl := effectiveTTL(a)
|
|
// Mirror RulesForShard's partition predicate exactly: a replay
|
|
// kind lands in walk when ttl is 0 (malformed) or ttl >
|
|
// retentionWindow. PromotedHash hashes that walk-bound subset.
|
|
if ttl > 0 && ttl <= retentionWindow {
|
|
continue
|
|
}
|
|
items = append(items, hashItem{key: k, action: a})
|
|
}
|
|
if len(items) == 0 {
|
|
return empty
|
|
}
|
|
sortHashItems(items)
|
|
|
|
w := newHashWriter()
|
|
for _, it := range items {
|
|
w.writeField(0x01, []byte(it.key.Bucket))
|
|
w.writeField(0x02, it.key.RuleHash[:])
|
|
w.writeInt(0x03, int64(it.key.ActionKind))
|
|
}
|
|
return w.sum()
|
|
}
|
|
|
|
// MaxEffectiveTTL returns the maximum effective TTL across the *active*
|
|
// replay-eligible actions in s. Returns 0 for a nil snapshot or one with no
|
|
// active replay actions; the caller is expected to be in the empty-replay
|
|
// branch already (per the design's sentinel-cursor logic).
|
|
//
|
|
// "Effective TTL" mirrors the partition predicate in views.go: derived from
|
|
// the rule field that matches the action kind. Walker-only action kinds
|
|
// (ExpirationDate / ExpiredDeleteMarker / NewerNoncurrent) contribute
|
|
// nothing — they're either not replay-eligible or, in a walk view, not
|
|
// active in the replay sense.
|
|
func MaxEffectiveTTL(s *Snapshot) time.Duration {
|
|
if s == nil {
|
|
return 0
|
|
}
|
|
var max time.Duration
|
|
for k, a := range s.actions {
|
|
if a == nil || !a.IsActive() {
|
|
continue
|
|
}
|
|
if !isReplayKind(k.ActionKind) {
|
|
continue
|
|
}
|
|
if ttl := effectiveTTL(a); ttl > max {
|
|
max = ttl
|
|
}
|
|
}
|
|
return max
|
|
}
|