mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-29 04:07:17 +00:00
Chris Lu
56c51e7f50
CreateEntry is a FindEntry-then-write with no lock, so concurrent creates to the same path race: OExcl can admit two creators, and a conditional write has no atomic check-then-act. Add a per-path exclusive lock (util.LockTable, which evicts idle keys so it stays bounded) in the CreateEntry handler so the read and the write are atomic on this filer. Once callers route a key's writes to its owner filer, this local lock is the authoritative serialization point. AppendToEntry moves from the distributed lock to the same per-path lock.
60 lines
1.5 KiB
Go
60 lines
1.5 KiB
Go
package weed_server
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
// Concurrent OExcl creates for the same path must yield exactly one winner. The
|
|
// filer's CreateEntry is a FindEntry-then-Insert; without the per-path lock both
|
|
// racers observe "not found" and both insert. The exclusive entry lock makes the
|
|
// check-then-act atomic so the losers see ErrEntryAlreadyExists.
|
|
func TestCreateEntryOExclSerialized(t *testing.T) {
|
|
store := newRenameTestStore()
|
|
store.findDelay = 5 * time.Millisecond
|
|
f := newRenameTestFiler(store)
|
|
f.DirBucketsPath = "/buckets"
|
|
|
|
fs := &FilerServer{
|
|
filer: f,
|
|
option: &FilerOption{},
|
|
entryLockTable: util.NewLockTable[util.FullPath](),
|
|
}
|
|
|
|
const racers = 8
|
|
var success int32
|
|
var wg sync.WaitGroup
|
|
start := make(chan struct{})
|
|
for i := 0; i < racers; i++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
<-start
|
|
resp, err := fs.CreateEntry(context.Background(), &filer_pb.CreateEntryRequest{
|
|
Directory: "/test",
|
|
OExcl: true,
|
|
SkipCheckParentDirectory: true,
|
|
Entry: &filer_pb.Entry{
|
|
Name: "obj",
|
|
Attributes: &filer_pb.FuseAttributes{Mtime: 1700000000, FileMode: 0644, Inode: 1},
|
|
},
|
|
})
|
|
if err == nil && resp.Error == "" {
|
|
atomic.AddInt32(&success, 1)
|
|
}
|
|
}()
|
|
}
|
|
close(start)
|
|
wg.Wait()
|
|
|
|
if success != 1 {
|
|
t.Fatalf("expected exactly 1 OExcl winner, got %d", success)
|
|
}
|
|
}
|