Chris Lu 6141222ab0 fix(test/s3/policy): allocate fresh admin port per subtest (#9332) ...

* fix(test/s3/policy): allocate fresh admin port per subtest

startMiniCluster ran weed mini in-process and explicitly assigned
master/volume/filer/s3 ports allocated by MustAllocatePorts, but it
left -admin.port and -admin.port.grpc unset, so each subtest reused
the hardcoded defaults 23646 / 33646.

The package's subtests run sequentially within the same go test
process. The previous subtest's admin goroutine is still bound to
23646 by the time the next subtest spins up its own mini, so the
new admin can never bind, mini.go's waitForAdminServerReady hits
its 240-attempt cap, and glog.Fatalf kills the test binary. This
has been the dominant cause of "admin server did not become ready"
flakes across recent IAM PRs.

Allocate two extra ports for admin and pass them through. The other
subprocess-based tests (s3tables/*) are not affected because each
launches weed mini in a fresh OS process.

* fix(mini): make admin readiness wait context-aware

waitForAdminServerReady polled for 240 attempts × 500ms regardless of
whether the surrounding mini context was cancelled. When mini is run
in-process from a test harness (test/s3/policy/...) and the test calls
its cancel func, the leftover wait keeps spinning for the full two
minutes and then glog.Fatalf's, terminating the entire test binary —
including any sibling subtest that has since started its own mini.

Thread the existing miniClientsCtx through the wait so a Stop / cancel
returns context.Canceled immediately. The caller (startMiniAdminWithWorker)
treats a context-cancelled outcome as a graceful shutdown signal and
logs+returns instead of fataling.

2026-05-05 11:24:43 -07:00

..

bucket_policy_idempotency_test.go

go fmt

2026-04-10 17:31:14 -07:00

policy_test.go

fix(test/s3/policy): allocate fresh admin port per subtest (#9332)

2026-05-05 11:24:43 -07:00

shell_accesskey_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_anonymous_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_bucket_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_config_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_group_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_helpers_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_policy_attach_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_serviceaccount_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00

shell_user_test.go

fix(shell): s3.user.provision handles existing users by attaching policy (#9040)

2026-04-11 22:30:51 -07:00