mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-05-29 21:20:21 +00:00
* test(s3api): cover IAM inline policy aws:SourceIp + group inline gap Unit tests under weed/s3api/ drive PutUserPolicy / PutGroupPolicy → reload → VerifyActionPermission with a synthetic 127.0.0.1 request and assert that the policy's IpAddress condition flips the outcome. The user-policy cases pass on master (hydrateRuntimePolicies already routes inline docs through the policy engine, so Condition blocks are honored end- to-end). The group-policy case fails: PutGroupPolicy still returns NotImplemented, so a group inline doc never lands in the engine. Integration counterparts live under test/s3/iam/ and exercise the same paths against a live SeaweedFS S3+IAM endpoint. * s3api: support group inline policies + Condition enforcement PutGroupPolicy/GetGroupPolicy/DeleteGroupPolicy/ListGroupPolicies used to return NotImplemented in embedded IAM mode, so anything attached to a group as an inline doc — including aws:SourceIp or any other Condition — was simply unreachable. Wire the four endpoints to the credential-store methods that were already in place (memory, postgres, filer_etc all implement GroupInlinePolicyStore). On every config reload, hydrateRuntimePolicies now also walks LoadGroupInlinePolicies, registers each doc in the IAM policy engine under __inline_group_policy__/<group>/<policy>, and appends that key to Group.PolicyNames so evaluateIAMPolicies picks it up through its existing group walk. PutGroupPolicy/DeleteGroupPolicy are added to the ReloadConfiguration trigger list in DoActions. Side fix: MemoryStore.LoadConfiguration now surfaces store.groups too. Without it iam.groups never repopulated on a memory-store reload, so group policy evaluation silently no-op'd whether the policy was inline or attached. The existing tests didn't notice because no test reloaded through cm after creating a group. The NotImplemented unit test is inverted to drive the new round-trip. * s3api: drop redundant refreshIAMConfiguration from Put/DeleteGroupPolicy DoActions already triggers ReloadConfiguration for both actions via the explicit reload list, so calling refreshIAMConfiguration inline runs the load twice per request. Per PR review. * s3api: scope group-policy resource names per test; tighten deny polling - Integration test resource names get a per-test suffix so retried or parallel CI jobs don't trip EntityAlreadyExists / BucketAlreadyExists. - Deny-path Eventually loops gate on AccessDenied via a typed helper rather than any non-nil error; transient setup errors no longer end the wait prematurely. - ListGroupPolicies returns ServiceFailure when the credential manager is nil, matching Put/Get/DeleteGroupPolicy. * test(s3 iam): cover both IPv4 and IPv6 loopback in allow CIDRs CI runners with happy-eyeballs resolve `localhost` to ::1 first, in which case a 127.0.0.0/8-only allow would silently never match and the deny-driven enforcement test would hang for the allow case. Add ::1/128 to every loopback-matching policy so the allow path works regardless of which loopback family the SDK lands on.
452 lines
11 KiB
Go
452 lines
11 KiB
Go
package memory
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/credential"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/iam_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/policy_engine"
|
|
)
|
|
|
|
func (store *MemoryStore) LoadConfiguration(ctx context.Context) (*iam_pb.S3ApiConfiguration, error) {
|
|
store.mu.RLock()
|
|
defer store.mu.RUnlock()
|
|
|
|
if !store.initialized {
|
|
return nil, fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
config := &iam_pb.S3ApiConfiguration{}
|
|
|
|
// Convert all users to identities
|
|
for _, user := range store.users {
|
|
config.Identities = append(config.Identities, store.deepCopyIdentity(user))
|
|
}
|
|
|
|
// Add all policies
|
|
for name, doc := range store.policies {
|
|
content, _ := json.Marshal(doc)
|
|
config.Policies = append(config.Policies, &iam_pb.Policy{
|
|
Name: name,
|
|
Content: string(content),
|
|
})
|
|
}
|
|
|
|
// Groups are written via CreateGroup / AddUserToGroup / AttachGroupPolicy
|
|
// (never via SaveConfiguration), so they live in store.groups regardless
|
|
// of the bulk-config path. Surface them here so consumers that reload
|
|
// through cm.LoadConfiguration see a faithful snapshot — without this,
|
|
// iam.groups would never repopulate on memory-store reloads and group
|
|
// policy evaluation would silently no-op.
|
|
for _, g := range store.groups {
|
|
config.Groups = append(config.Groups, cloneGroup(g))
|
|
}
|
|
|
|
return config, nil
|
|
}
|
|
|
|
func (store *MemoryStore) SaveConfiguration(ctx context.Context, config *iam_pb.S3ApiConfiguration) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
// Clear existing data
|
|
store.users = make(map[string]*iam_pb.Identity)
|
|
store.accessKeys = make(map[string]string)
|
|
store.policies = make(map[string]policy_engine.PolicyDocument)
|
|
|
|
// Add all identities
|
|
for _, identity := range config.Identities {
|
|
store.users[identity.Name] = store.deepCopyIdentity(identity)
|
|
|
|
// Index access keys
|
|
for _, credential := range identity.Credentials {
|
|
store.accessKeys[credential.AccessKey] = identity.Name
|
|
}
|
|
}
|
|
|
|
// Add all policies
|
|
for _, policy := range config.Policies {
|
|
var doc policy_engine.PolicyDocument
|
|
if err := json.Unmarshal([]byte(policy.Content), &doc); err == nil {
|
|
store.policies[policy.Name] = doc
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *MemoryStore) CreateUser(ctx context.Context, identity *iam_pb.Identity) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
if _, exists := store.users[identity.Name]; exists {
|
|
return credential.ErrUserAlreadyExists
|
|
}
|
|
|
|
// Check for duplicate access keys
|
|
for _, cred := range identity.Credentials {
|
|
if _, exists := store.accessKeys[cred.AccessKey]; exists {
|
|
return fmt.Errorf("access key %s already exists", cred.AccessKey)
|
|
}
|
|
}
|
|
|
|
// Deep copy to avoid mutation issues
|
|
identityCopy := store.deepCopyIdentity(identity)
|
|
store.users[identity.Name] = identityCopy
|
|
|
|
// Index access keys
|
|
for _, cred := range identity.Credentials {
|
|
store.accessKeys[cred.AccessKey] = identity.Name
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *MemoryStore) GetUser(ctx context.Context, username string) (*iam_pb.Identity, error) {
|
|
store.mu.RLock()
|
|
defer store.mu.RUnlock()
|
|
|
|
if !store.initialized {
|
|
return nil, fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
return nil, credential.ErrUserNotFound
|
|
}
|
|
|
|
// Return a deep copy to avoid mutation issues
|
|
return store.deepCopyIdentity(user), nil
|
|
}
|
|
|
|
func (store *MemoryStore) UpdateUser(ctx context.Context, username string, identity *iam_pb.Identity) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
existingUser, exists := store.users[username]
|
|
if !exists {
|
|
return credential.ErrUserNotFound
|
|
}
|
|
|
|
// Remove old access keys from index
|
|
for _, cred := range existingUser.Credentials {
|
|
delete(store.accessKeys, cred.AccessKey)
|
|
}
|
|
|
|
// Check for duplicate access keys (excluding current user)
|
|
for _, cred := range identity.Credentials {
|
|
if existingUsername, exists := store.accessKeys[cred.AccessKey]; exists && existingUsername != username {
|
|
return fmt.Errorf("access key %s already exists", cred.AccessKey)
|
|
}
|
|
}
|
|
|
|
// Deep copy to avoid mutation issues
|
|
identityCopy := store.deepCopyIdentity(identity)
|
|
store.users[username] = identityCopy
|
|
|
|
// Re-index access keys
|
|
for _, cred := range identity.Credentials {
|
|
store.accessKeys[cred.AccessKey] = username
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *MemoryStore) DeleteUser(ctx context.Context, username string) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
return credential.ErrUserNotFound
|
|
}
|
|
|
|
// Remove access keys from index
|
|
for _, cred := range user.Credentials {
|
|
delete(store.accessKeys, cred.AccessKey)
|
|
}
|
|
|
|
// Remove user
|
|
delete(store.users, username)
|
|
delete(store.inlinePolicies, username)
|
|
|
|
return nil
|
|
}
|
|
|
|
// RenameUser implements credential.UserRenamer for the memory store.
|
|
// Renames the user and re-points access-key and inline-policy indexes
|
|
// to the new name. The whole operation is performed under the store
|
|
// lock so it is atomic with respect to concurrent reads.
|
|
func (store *MemoryStore) RenameUser(ctx context.Context, oldName, newName string) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
if oldName == newName {
|
|
return nil
|
|
}
|
|
|
|
user, exists := store.users[oldName]
|
|
if !exists {
|
|
return credential.ErrUserNotFound
|
|
}
|
|
if _, clash := store.users[newName]; clash {
|
|
return credential.ErrUserAlreadyExists
|
|
}
|
|
|
|
user.Name = newName
|
|
store.users[newName] = user
|
|
delete(store.users, oldName)
|
|
|
|
for _, cred := range user.Credentials {
|
|
store.accessKeys[cred.AccessKey] = newName
|
|
}
|
|
|
|
if policies, ok := store.inlinePolicies[oldName]; ok {
|
|
store.inlinePolicies[newName] = policies
|
|
delete(store.inlinePolicies, oldName)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *MemoryStore) ListUsers(ctx context.Context) ([]string, error) {
|
|
store.mu.RLock()
|
|
defer store.mu.RUnlock()
|
|
|
|
if !store.initialized {
|
|
return nil, fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
var usernames []string
|
|
for username := range store.users {
|
|
usernames = append(usernames, username)
|
|
}
|
|
|
|
return usernames, nil
|
|
}
|
|
|
|
func (store *MemoryStore) GetUserByAccessKey(ctx context.Context, accessKey string) (*iam_pb.Identity, error) {
|
|
store.mu.RLock()
|
|
defer store.mu.RUnlock()
|
|
|
|
if !store.initialized {
|
|
return nil, fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
username, exists := store.accessKeys[accessKey]
|
|
if !exists {
|
|
return nil, credential.ErrAccessKeyNotFound
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
// This should not happen, but handle it gracefully
|
|
return nil, credential.ErrUserNotFound
|
|
}
|
|
|
|
// Return a deep copy to avoid mutation issues
|
|
return store.deepCopyIdentity(user), nil
|
|
}
|
|
|
|
func (store *MemoryStore) CreateAccessKey(ctx context.Context, username string, cred *iam_pb.Credential) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
return credential.ErrUserNotFound
|
|
}
|
|
|
|
// Check if access key already exists
|
|
if _, exists := store.accessKeys[cred.AccessKey]; exists {
|
|
return fmt.Errorf("access key %s already exists", cred.AccessKey)
|
|
}
|
|
|
|
// Add credential to user
|
|
user.Credentials = append(user.Credentials, &iam_pb.Credential{
|
|
AccessKey: cred.AccessKey,
|
|
SecretKey: cred.SecretKey,
|
|
})
|
|
|
|
// Index the access key
|
|
store.accessKeys[cred.AccessKey] = username
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *MemoryStore) DeleteAccessKey(ctx context.Context, username string, accessKey string) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
return credential.ErrUserNotFound
|
|
}
|
|
|
|
// Find and remove the credential
|
|
var newCredentials []*iam_pb.Credential
|
|
found := false
|
|
for _, cred := range user.Credentials {
|
|
if cred.AccessKey == accessKey {
|
|
found = true
|
|
// Remove from access key index
|
|
delete(store.accessKeys, accessKey)
|
|
} else {
|
|
newCredentials = append(newCredentials, cred)
|
|
}
|
|
}
|
|
|
|
if !found {
|
|
return credential.ErrAccessKeyNotFound
|
|
}
|
|
|
|
user.Credentials = newCredentials
|
|
return nil
|
|
}
|
|
|
|
// deepCopyIdentity creates a deep copy of an identity to avoid mutation issues
|
|
func (store *MemoryStore) deepCopyIdentity(identity *iam_pb.Identity) *iam_pb.Identity {
|
|
if identity == nil {
|
|
return nil
|
|
}
|
|
|
|
// Use JSON marshaling/unmarshaling for deep copy
|
|
// This is simple and safe for protobuf messages
|
|
data, err := json.Marshal(identity)
|
|
if err != nil {
|
|
// Fallback to shallow copy if JSON fails
|
|
return &iam_pb.Identity{
|
|
Name: identity.Name,
|
|
Account: identity.Account,
|
|
Credentials: identity.Credentials,
|
|
Actions: identity.Actions,
|
|
PolicyNames: identity.PolicyNames,
|
|
}
|
|
}
|
|
|
|
var copy iam_pb.Identity
|
|
if err := json.Unmarshal(data, ©); err != nil {
|
|
// Fallback to shallow copy if JSON fails
|
|
return &iam_pb.Identity{
|
|
Name: identity.Name,
|
|
Account: identity.Account,
|
|
Credentials: identity.Credentials,
|
|
Actions: identity.Actions,
|
|
PolicyNames: identity.PolicyNames,
|
|
}
|
|
}
|
|
|
|
return ©
|
|
}
|
|
|
|
// AttachUserPolicy attaches a managed policy to a user by policy name
|
|
func (store *MemoryStore) AttachUserPolicy(ctx context.Context, username string, policyName string) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
return credential.ErrUserNotFound
|
|
}
|
|
|
|
// Verify policy exists
|
|
if _, exists := store.policies[policyName]; !exists {
|
|
return credential.ErrPolicyNotFound
|
|
}
|
|
|
|
// Check if already attached
|
|
for _, p := range user.PolicyNames {
|
|
if p == policyName {
|
|
return credential.ErrPolicyAlreadyAttached
|
|
}
|
|
}
|
|
|
|
user.PolicyNames = append(user.PolicyNames, policyName)
|
|
return nil
|
|
}
|
|
|
|
// DetachUserPolicy detaches a managed policy from a user
|
|
func (store *MemoryStore) DetachUserPolicy(ctx context.Context, username string, policyName string) error {
|
|
store.mu.Lock()
|
|
defer store.mu.Unlock()
|
|
|
|
if !store.initialized {
|
|
return fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
return credential.ErrUserNotFound
|
|
}
|
|
|
|
found := false
|
|
var newPolicies []string
|
|
for _, p := range user.PolicyNames {
|
|
if p == policyName {
|
|
found = true
|
|
} else {
|
|
newPolicies = append(newPolicies, p)
|
|
}
|
|
}
|
|
|
|
if !found {
|
|
return credential.ErrPolicyNotAttached
|
|
}
|
|
|
|
user.PolicyNames = newPolicies
|
|
return nil
|
|
}
|
|
|
|
// ListAttachedUserPolicies returns the list of policy names attached to a user
|
|
func (store *MemoryStore) ListAttachedUserPolicies(ctx context.Context, username string) ([]string, error) {
|
|
store.mu.RLock()
|
|
defer store.mu.RUnlock()
|
|
|
|
if !store.initialized {
|
|
return nil, fmt.Errorf("store not initialized")
|
|
}
|
|
|
|
user, exists := store.users[username]
|
|
if !exists {
|
|
return nil, credential.ErrUserNotFound
|
|
}
|
|
|
|
// Return copy to prevent mutation
|
|
result := make([]string, len(user.PolicyNames))
|
|
copy(result, user.PolicyNames)
|
|
return result, nil
|
|
}
|