mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-01 21:59:44 +00:00
Chris LuandGitHub
f8caaa4464
* mount: renew POSIX lock leases via keepalive The mount tracks the inode keys it holds locks on and a background loop renews its session lease (KEEP_ALIVE) with each key's owner filer every 5s, within the filer's 15s TTL. A live mount is never reaped; a dead one stops renewing and owners reclaim its locks. Tracking is a superset: holds are added on grant and dropped only on owner release, so a still held lock is never under-renewed. * mount,filer: re-assert held POSIX locks via keepalive The owner filer holds POSIX advisory locks as in-memory soft state, so a key's owner change (ring rebalance) or an owner restart lost or stranded them: the new or restarted owner was blind to existing holders and would double-grant. Make the keepalive carry the mount's held lock ranges per key. The mount mirrors its own granted locks (posixOwn), and each tick re-asserts them to the key's current owner, which rebuilds that session's locks from the assertion — self -healing after a takeover or restart. The owner arbitrates re-asserted locks against other sessions so it never double-grants; a lock that lost a migration race is reported, not forced. A bare keepalive (no ranges) still just renews.
83 lines
2.9 KiB
Go
83 lines
2.9 KiB
Go
package posixlock
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// A mount's tracked locks round-trip through Snapshot back to a fresh owner via
|
|
// Reassert — the owner-restart / ring-change recovery path.
|
|
func TestReassertRebuildsOnFreshOwner(t *testing.T) {
|
|
const sid = uint64(7)
|
|
|
|
// Client mirror: two granted locks on one key, one on another.
|
|
client := NewManager()
|
|
client.Track("a", Range{Start: 0, End: 99, Type: Write, Sid: sid, Owner: 1})
|
|
client.Track("a", Range{Start: 200, End: 299, Type: Read, Sid: sid, Owner: 2})
|
|
client.Track("b", Range{Start: 0, End: maxEnd, Type: Write, Sid: sid, Owner: 1, IsFlock: true})
|
|
|
|
// Fresh owner (post-restart / new ring owner) knows nothing.
|
|
owner := NewManager()
|
|
for key, locks := range client.Snapshot() {
|
|
if c := owner.Reassert(key, sid, locks); c != nil {
|
|
t.Fatalf("unexpected conflict reasserting %s: %+v", key, c)
|
|
}
|
|
}
|
|
|
|
// The owner now reports the same conflicts a foreign session would hit.
|
|
if _, granted := owner.TryLock("a", Range{Start: 50, End: 60, Type: Write, Sid: 99, Owner: 1}); granted {
|
|
t.Fatal("owner should block a foreign write after rebuild")
|
|
}
|
|
if _, granted := owner.TryLock("b", Range{Start: 0, End: 0, Type: Read, Sid: 99, Owner: 1, IsFlock: true}); granted {
|
|
t.Fatal("owner should block a foreign flock read after rebuild")
|
|
}
|
|
}
|
|
|
|
// Re-asserting every tick is idempotent: the owner's view is unchanged.
|
|
func TestReassertIdempotent(t *testing.T) {
|
|
const sid = uint64(1)
|
|
m := NewManager()
|
|
m.TryLock("k", Range{Start: 0, End: 99, Type: Write, Sid: sid, Owner: 1})
|
|
before := append([]Range(nil), m.byKey["k"].locks...)
|
|
|
|
m.Reassert("k", sid, before)
|
|
m.Reassert("k", sid, before)
|
|
|
|
if !reflect.DeepEqual(m.byKey["k"].locks, before) {
|
|
t.Fatalf("reassert not idempotent:\n got %+v\nwant %+v", m.byKey["k"].locks, before)
|
|
}
|
|
}
|
|
|
|
// A lock another session grabbed in the migration window is reported as a
|
|
// conflict and not double-granted.
|
|
func TestReassertReportsConflict(t *testing.T) {
|
|
const mine, other = uint64(1), uint64(2)
|
|
m := NewManager()
|
|
// Another mount took the lock on this (new) owner during the gap.
|
|
m.TryLock("k", Range{Start: 0, End: 99, Type: Write, Sid: other, Owner: 1})
|
|
|
|
conflicts := m.Reassert("k", mine, []Range{{Start: 0, End: 99, Type: Write, Sid: mine, Owner: 1}})
|
|
if len(conflicts) != 1 {
|
|
t.Fatalf("expected 1 conflict, got %d: %+v", len(conflicts), conflicts)
|
|
}
|
|
// The other session keeps the lock; mine was not installed.
|
|
if got := len(m.byKey["k"].locks); got != 1 {
|
|
t.Fatalf("expected only the incumbent lock, got %d", got)
|
|
}
|
|
}
|
|
|
|
// Reassert renews the lease, so a re-asserting mount is not reaped.
|
|
func TestReassertRenewsLease(t *testing.T) {
|
|
const sid = uint64(1)
|
|
m := NewManager()
|
|
m.Renew(sid)
|
|
m.Reassert("k", sid, []Range{{Start: 0, End: 9, Type: Write, Sid: sid, Owner: 1}})
|
|
|
|
if reaped := m.ReapExpired(time.Hour); len(reaped) != 0 {
|
|
t.Fatalf("freshly re-asserted session should not be reaped: %v", reaped)
|
|
}
|
|
}
|
|
|
|
const maxEnd = ^uint64(0)
|