mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-05-13 21:31:32 +00:00
d123a2768b
* shell: add s3.accesskey.*, s3.anonymous.*, s3.serviceaccount.* commands Add credential, anonymous access, and service account management commands: Access key commands: - s3.accesskey.create: add credentials to an existing user - s3.accesskey.list: list access keys for a user (key ID + status) - s3.accesskey.delete: remove a specific access key - s3.accesskey.rotate: atomic create-new + delete-old key rotation Anonymous access commands: - s3.anonymous.set: set/remove public access on a bucket - s3.anonymous.get: show anonymous access for a bucket - s3.anonymous.list: list all buckets with anonymous access Service account commands: - s3.serviceaccount.create: create with optional action subset and expiry - s3.serviceaccount.list: tabular listing, optionally filtered by parent - s3.serviceaccount.show: detailed view of a service account - s3.serviceaccount.delete: remove a service account These replace the credential and anonymous portions of the monolithic s3.configure and s3.bucket.access commands. * shell: address review feedback for s3.accesskey.*, s3.anonymous.*, s3.serviceaccount.* - Return flag parse errors instead of swallowing them (all commands) - Add action validation in s3.anonymous.set (Read, Write, List, Tagging, Admin) - Fix s3.serviceaccount.create output: note to use list for server-assigned ID since CreateServiceAccountResponse does not return the ID * shell: fix bucket matching and action validation in s3.anonymous.* - Use SplitN instead of HasSuffix for bucket name matching to avoid false positives when one bucket name is a suffix of another - Make action validation case-insensitive with canonical normalization * shell: fix nil panics, dedup actions, validate service account actions - Fix nil-pointer panic in getOrCreateAnonymousUser when GetUser returns err==nil with nil Identity (status.FromError(nil) returns nil status) - Add nil Identity guards in s3.anonymous.get and s3.anonymous.list - Deduplicate action values in s3.anonymous.set (e.g. -access Read,Read) - Add action validation in s3.serviceaccount.create with case normalization * shell: dedup actions and reject negative expiry in s3.serviceaccount.create - Deduplicate -actions values (e.g. Read,read,Read produces one entry) - Reject negative -expiry values instead of silently treating as no expiration
92 lines
2.2 KiB
Go
92 lines
2.2 KiB
Go
package shell
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"sort"
|
|
"strings"
|
|
"text/tabwriter"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/iam_pb"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
func init() {
|
|
Commands = append(Commands, &commandS3AnonymousList{})
|
|
}
|
|
|
|
type commandS3AnonymousList struct {
|
|
}
|
|
|
|
func (c *commandS3AnonymousList) Name() string {
|
|
return "s3.anonymous.list"
|
|
}
|
|
|
|
func (c *commandS3AnonymousList) Help() string {
|
|
return `list all buckets with anonymous access
|
|
|
|
s3.anonymous.list
|
|
`
|
|
}
|
|
|
|
func (c *commandS3AnonymousList) HasTag(CommandTag) bool {
|
|
return false
|
|
}
|
|
|
|
func (c *commandS3AnonymousList) Do(args []string, commandEnv *CommandEnv, writer io.Writer) error {
|
|
return pb.WithGrpcClient(false, 0, func(conn *grpc.ClientConn) error {
|
|
client := iam_pb.NewSeaweedIdentityAccessManagementClient(conn)
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
|
|
resp, err := client.GetUser(ctx, &iam_pb.GetUserRequest{Username: anonymousUserName})
|
|
if err != nil {
|
|
st, ok := status.FromError(err)
|
|
if ok && st.Code() == codes.NotFound {
|
|
fmt.Fprintln(writer, "No anonymous access configured.")
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
if resp.Identity == nil {
|
|
fmt.Fprintln(writer, "No anonymous access configured.")
|
|
return nil
|
|
}
|
|
|
|
// Group actions by bucket
|
|
bucketActions := map[string][]string{}
|
|
for _, a := range resp.Identity.Actions {
|
|
parts := strings.SplitN(a, ":", 2)
|
|
if len(parts) == 2 {
|
|
bucketActions[parts[1]] = append(bucketActions[parts[1]], parts[0])
|
|
}
|
|
}
|
|
|
|
if len(bucketActions) == 0 {
|
|
fmt.Fprintln(writer, "No anonymous access configured.")
|
|
return nil
|
|
}
|
|
|
|
// Sort bucket names
|
|
buckets := make([]string, 0, len(bucketActions))
|
|
for b := range bucketActions {
|
|
buckets = append(buckets, b)
|
|
}
|
|
sort.Strings(buckets)
|
|
|
|
tw := tabwriter.NewWriter(writer, 0, 4, 2, ' ', 0)
|
|
fmt.Fprintln(tw, "BUCKET\tACCESS")
|
|
for _, b := range buckets {
|
|
actions := bucketActions[b]
|
|
sort.Strings(actions)
|
|
fmt.Fprintf(tw, "%s\t%s\n", b, strings.Join(actions, ", "))
|
|
}
|
|
return tw.Flush()
|
|
}, commandEnv.option.FilerAddress.ToGrpcAddress(), false, commandEnv.option.GrpcDialOption)
|
|
}
|