mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-07-06 16:16:31 +00:00
7y-9
7bbd28634a
Problem: RandomUint64 generated eight random bytes but returned int32, truncating the value before mount file and directory handles converted it to uint64. This reduced handle entropy to 32 bits and produced sign-extended handle values.\n\nRoot cause: the helper cast BytesToUint64 to int32 and exposed int32 as its return type.\n\nFix: make RandomUint64 return uint64 and return the full BytesToUint64 result.\n\nReproduction: go test ./weed/util -run TestRandomUint64ReturnsUint64 -count=1 failed before the fix because RandomUint64() had kind int32.\n\nValidation: gofmt -w weed/util/bytes.go weed/util/bytes_test.go; git diff --check; go test ./weed/util -run TestRandomUint64ReturnsUint64 -count=1; go test ./weed/util -count=1; go test ./weed/mount -count=1; git diff --cached --check
99 lines
2.0 KiB
Go
99 lines
2.0 KiB
Go
package util
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
)
|
|
|
|
func TestRandomUint64ReturnsFullRandomValue(t *testing.T) {
|
|
useRandomRead(t, func(p []byte) (int, error) {
|
|
copy(p, []byte{0x80, 0, 0, 0, 0, 0, 0, 1})
|
|
return len(p), nil
|
|
})
|
|
|
|
const want uint64 = 0x8000000000000001
|
|
if got := RandomUint64(); got != want {
|
|
t.Fatalf("RandomUint64() = %d, want %d", got, want)
|
|
}
|
|
}
|
|
|
|
func TestRandomUint64PanicsOnRandomReadError(t *testing.T) {
|
|
useRandomRead(t, func([]byte) (int, error) {
|
|
return 0, errors.New("random read failed")
|
|
})
|
|
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("RandomUint64() did not panic on random read error")
|
|
}
|
|
}()
|
|
|
|
RandomUint64()
|
|
}
|
|
|
|
func useRandomRead(t *testing.T, read func([]byte) (int, error)) {
|
|
t.Helper()
|
|
|
|
original := randomRead
|
|
randomRead = read
|
|
t.Cleanup(func() {
|
|
randomRead = original
|
|
})
|
|
}
|
|
|
|
func TestByteParsing(t *testing.T) {
|
|
tests := []struct {
|
|
in string
|
|
exp uint64
|
|
}{
|
|
{"42", 42},
|
|
{"42MB", 42000000},
|
|
{"42MiB", 44040192},
|
|
{"42mb", 42000000},
|
|
{"42mib", 44040192},
|
|
{"42MIB", 44040192},
|
|
{"42 MB", 42000000},
|
|
{"42 MiB", 44040192},
|
|
{"42 mb", 42000000},
|
|
{"42 mib", 44040192},
|
|
{"42 MIB", 44040192},
|
|
{"42.5MB", 42500000},
|
|
{"42.5MiB", 44564480},
|
|
{"42.5 MB", 42500000},
|
|
{"42.5 MiB", 44564480},
|
|
// No need to say B
|
|
{"42M", 42000000},
|
|
{"42Mi", 44040192},
|
|
{"42m", 42000000},
|
|
{"42mi", 44040192},
|
|
{"42MI", 44040192},
|
|
{"42 M", 42000000},
|
|
{"42 Mi", 44040192},
|
|
{"42 m", 42000000},
|
|
{"42 mi", 44040192},
|
|
{"42 MI", 44040192},
|
|
{"42.5M", 42500000},
|
|
{"42.5Mi", 44564480},
|
|
{"42.5 M", 42500000},
|
|
{"42.5 Mi", 44564480},
|
|
// Bug #42
|
|
{"1,005.03 MB", 1005030000},
|
|
// Large testing, breaks when too much larger than
|
|
// this.
|
|
{"12.5 EB", uint64(12.5 * float64(EByte))},
|
|
{"12.5 E", uint64(12.5 * float64(EByte))},
|
|
{"12.5 EiB", uint64(12.5 * float64(EiByte))},
|
|
}
|
|
|
|
for _, p := range tests {
|
|
got, err := ParseBytes(p.in)
|
|
if err != nil {
|
|
t.Errorf("Couldn't parse %v: %v", p.in, err)
|
|
}
|
|
if got != p.exp {
|
|
t.Errorf("Expected %v for %v, got %v",
|
|
p.exp, p.in, got)
|
|
}
|
|
}
|
|
}
|