mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-27 19:37:00 +00:00
* fix(s3): honor X-Forwarded-For in audit log remote_ip When SeaweedFS S3 sits behind a reverse proxy (e.g., Caddy), the audit log's `remote_ip` was reporting the proxy's address because only `X-Real-IP` and `r.RemoteAddr` were consulted. Caddy and most other proxies set `X-Forwarded-For` by default but not `X-Real-IP`, so the real client IP was lost. Check `X-Forwarded-For` first (using the left-most non-empty entry as the originating client), then fall back to `X-Real-IP`, then `r.RemoteAddr`. Fixes #9293 * fix(s3): strip port from RemoteAddr fallback in audit log Address PR review: the X-Forwarded-For and X-Real-IP paths return host-only values, while the RemoteAddr fallback was returning "host:port", making the remote_ip field inconsistent with both the other code paths and the "192.0.2.3" example in the AccessLog struct. Use net.SplitHostPort to strip the port, falling back to the raw RemoteAddr for non-IP markers (e.g., "@" for unix sockets).
200 lines
6.4 KiB
Go
200 lines
6.4 KiB
Go
package s3err
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"os"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/fluent/fluent-logger-golang/fluent"
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"github.com/seaweedfs/seaweedfs/weed/util/request_id"
|
|
)
|
|
|
|
type AccessLogExtend struct {
|
|
AccessLog
|
|
AccessLogHTTP
|
|
}
|
|
|
|
type AccessLog struct {
|
|
Bucket string `msg:"bucket" json:"bucket"` // awsexamplebucket1
|
|
Time int64 `msg:"time" json:"time"` // [06/Feb/2019:00:00:38 +0000]
|
|
RemoteIP string `msg:"remote_ip" json:"remote_ip,omitempty"` // 192.0.2.3
|
|
Requester string `msg:"requester" json:"requester,omitempty"` // IAM user id
|
|
RequestID string `msg:"request_id" json:"request_id,omitempty"` // 3E57427F33A59F07
|
|
Operation string `msg:"operation" json:"operation,omitempty"` // REST.HTTP_method.resource_type REST.PUT.OBJECT
|
|
Key string `msg:"key" json:"key,omitempty"` // /photos/2019/08/puppy.jpg
|
|
ErrorCode string `msg:"error_code" json:"error_code,omitempty"`
|
|
HostId string `msg:"host_id" json:"host_id,omitempty"`
|
|
HostHeader string `msg:"host_header" json:"host_header,omitempty"` // s3.us-west-2.amazonaws.com
|
|
UserAgent string `msg:"user_agent" json:"user_agent,omitempty"`
|
|
HTTPStatus int `msg:"status" json:"status,omitempty"`
|
|
SignatureVersion string `msg:"signature_version" json:"signature_version,omitempty"`
|
|
}
|
|
|
|
type AccessLogHTTP struct {
|
|
RequestURI string `json:"request_uri,omitempty"` // "GET /awsexamplebucket1/photos/2019/08/puppy.jpg?x-foo=bar HTTP/1.1"
|
|
BytesSent string `json:"bytes_sent,omitempty"`
|
|
ObjectSize string `json:"object_size,omitempty"`
|
|
TotalTime int `json:"total_time,omitempty"`
|
|
TurnAroundTime int `json:"turn_around_time,omitempty"`
|
|
Referer string `json:"Referer,omitempty"`
|
|
VersionId string `json:"version_id,omitempty"`
|
|
CipherSuite string `json:"cipher_suite,omitempty"`
|
|
AuthenticationType string `json:"auth_type,omitempty"`
|
|
TLSVersion string `json:"TLS_version,omitempty"`
|
|
}
|
|
|
|
const tag = "s3.access"
|
|
|
|
var (
|
|
Logger *fluent.Fluent
|
|
hostname = os.Getenv("HOSTNAME")
|
|
environment = os.Getenv("ENVIRONMENT")
|
|
)
|
|
|
|
func InitAuditLog(config string) {
|
|
configContent, readErr := os.ReadFile(config)
|
|
if readErr != nil {
|
|
glog.Errorf("fail to read fluent config %s : %v", config, readErr)
|
|
return
|
|
}
|
|
fluentConfig := &fluent.Config{}
|
|
if err := json.Unmarshal(configContent, fluentConfig); err != nil {
|
|
glog.Errorf("fail to parse fluent config %s : %v", string(configContent), err)
|
|
return
|
|
}
|
|
if len(fluentConfig.TagPrefix) == 0 && len(environment) > 0 {
|
|
fluentConfig.TagPrefix = environment
|
|
}
|
|
fluentConfig.Async = true
|
|
fluentConfig.AsyncResultCallback = func(data []byte, err error) {
|
|
if err != nil {
|
|
glog.Warning("Error while posting log: ", err)
|
|
}
|
|
}
|
|
var err error
|
|
Logger, err = fluent.New(*fluentConfig)
|
|
if err != nil {
|
|
glog.Errorf("fail to load fluent config: %v", err)
|
|
}
|
|
}
|
|
|
|
// getRemoteIP returns the client IP for the audit log, honoring forwarding
|
|
// headers set by reverse proxies. Preference order: X-Forwarded-For (first
|
|
// non-empty entry), X-Real-IP, then r.RemoteAddr. Headers are trusted as-is;
|
|
// operators who expose the S3 endpoint directly to untrusted networks should
|
|
// strip these headers at the proxy boundary so clients cannot spoof them.
|
|
func getRemoteIP(r *http.Request) string {
|
|
if forwardedFor := r.Header.Get("X-Forwarded-For"); forwardedFor != "" {
|
|
for _, entry := range strings.Split(forwardedFor, ",") {
|
|
if ip := strings.TrimSpace(entry); ip != "" {
|
|
return ip
|
|
}
|
|
}
|
|
}
|
|
if realIP := strings.TrimSpace(r.Header.Get("X-Real-IP")); realIP != "" {
|
|
return realIP
|
|
}
|
|
if host, _, err := net.SplitHostPort(r.RemoteAddr); err == nil {
|
|
return host
|
|
}
|
|
return r.RemoteAddr
|
|
}
|
|
|
|
func getREST(httpMetod string, resourceType string) string {
|
|
return fmt.Sprintf("REST.%s.%s", httpMetod, resourceType)
|
|
}
|
|
|
|
func getResourceType(object string, query_key string, metod string) (string, bool) {
|
|
if object == "/" {
|
|
switch query_key {
|
|
case "delete":
|
|
return "BATCH.DELETE.OBJECT", true
|
|
case "tagging":
|
|
return getREST(metod, "OBJECTTAGGING"), true
|
|
case "lifecycle":
|
|
return getREST(metod, "LIFECYCLECONFIGURATION"), true
|
|
case "acl":
|
|
return getREST(metod, "ACCESSCONTROLPOLICY"), true
|
|
case "policy":
|
|
return getREST(metod, "BUCKETPOLICY"), true
|
|
default:
|
|
return getREST(metod, "BUCKET"), false
|
|
}
|
|
} else {
|
|
switch query_key {
|
|
case "tagging":
|
|
return getREST(metod, "OBJECTTAGGING"), true
|
|
default:
|
|
return getREST(metod, "OBJECT"), false
|
|
}
|
|
}
|
|
}
|
|
|
|
func getOperation(object string, r *http.Request) string {
|
|
queries := r.URL.Query()
|
|
var operation string
|
|
var queryFound bool
|
|
for key, _ := range queries {
|
|
operation, queryFound = getResourceType(object, key, r.Method)
|
|
if queryFound {
|
|
return operation
|
|
}
|
|
}
|
|
if len(queries) == 0 {
|
|
operation, _ = getResourceType(object, "", r.Method)
|
|
}
|
|
return operation
|
|
}
|
|
|
|
func GetAccessLog(r *http.Request, HTTPStatusCode int, s3errCode ErrorCode) *AccessLog {
|
|
bucket, key := s3_constants.GetBucketAndObject(r)
|
|
var errorCode string
|
|
if s3errCode != ErrNone {
|
|
errorCode = GetAPIError(s3errCode).Code
|
|
}
|
|
remoteIP := getRemoteIP(r)
|
|
hostHeader := r.Header.Get("X-Forwarded-Host")
|
|
if len(hostHeader) == 0 {
|
|
hostHeader = r.Host
|
|
}
|
|
return &AccessLog{
|
|
HostHeader: hostHeader,
|
|
RequestID: request_id.GetFromRequest(r),
|
|
RemoteIP: remoteIP,
|
|
Requester: s3_constants.GetIdentityNameFromContext(r), // Get from context, not header (secure)
|
|
SignatureVersion: r.Header.Get(s3_constants.AmzAuthType),
|
|
UserAgent: r.Header.Get("user-agent"),
|
|
HostId: hostname,
|
|
Bucket: bucket,
|
|
HTTPStatus: HTTPStatusCode,
|
|
Time: time.Now().Unix(),
|
|
Key: key,
|
|
Operation: getOperation(key, r),
|
|
ErrorCode: errorCode,
|
|
}
|
|
}
|
|
|
|
func PostLog(r *http.Request, HTTPStatusCode int, errorCode ErrorCode) {
|
|
if Logger == nil {
|
|
return
|
|
}
|
|
if err := Logger.Post(tag, *GetAccessLog(r, HTTPStatusCode, errorCode)); err != nil {
|
|
glog.Warning("Error while posting log: ", err)
|
|
}
|
|
}
|
|
|
|
func PostAccessLog(log AccessLog) {
|
|
if Logger == nil || len(log.Key) == 0 {
|
|
return
|
|
}
|
|
if err := Logger.Post(tag, log); err != nil {
|
|
glog.Warning("Error while posting log: ", err)
|
|
}
|
|
}
|