4 people 4f0322af86 perf(weed/topology): log writable-state changes, not every check (#10612) ...

* perf(weed/topology): log writable-state changes, not every check

ensureCorrectWritables ran its three diagnostics whenever it was asked, so a
volume that had always been read-only re-announced that on every registration.
A volume server reconnecting with 550k read-only volumes made the master format
over a million log lines before it could serve anything, which is exactly when
it is already at its memory peak rebuilding the topology.

removeFromWritable already reports the transition, and only when there is one.
Explain it only then. Dropped the separate 'remove from writable' line, which
said nothing that 'becomes unwritable' does not.

BenchmarkRegisterReadOnlyVolumes, 100k volumes
  285791480 B/op 1902069 allocs/op -> 234592088 B/op 1302572 allocs/op

* Update weed/topology/volume_layout.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

2026-08-07 00:44:30 -07:00

..

balancer

topology/balancer: share replica selection between shell and workers (#10276)

2026-07-08 20:06:15 -07:00

allocate_volume.go

master: timeout AllocateVolume/DeleteVolume and defer growRequest cleanup (#9698)

2026-05-26 16:26:21 -07:00

cluster_commands.go

Prevent split-brain: Persistent ClusterID and Join Validation (#8022)

2026-01-18 14:02:34 -08:00

collection.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

configuration.go

chore(weed/topology): prune unused functions (#9249)

2026-04-27 15:54:52 -07:00

data_center.go

Master: volume assignment concurrency (#7159)

2025-08-23 21:02:30 -07:00

data_node_ec_multi_disk_test.go

fix(master): register EC shards per physical disk on full heartbeat sync (#9212) (#9219)

2026-04-24 14:01:09 -07:00

data_node_ec.go

fix(master): register EC shards per physical disk on full heartbeat sync (#9212) (#9219)

2026-04-24 14:01:09 -07:00

data_node_empty_disk_test.go

feat(topology): report empty disks (per-disk type + capacity in heartbeat) (#10166)

2026-06-30 18:45:44 -07:00

data_node.go

perf(weed/topology): diff a heartbeat without copying the volume map (#10608)

2026-08-07 00:28:32 -07:00

disk_ec.go

fix(master): register EC shards per physical disk on full heartbeat sync (#9212) (#9219)

2026-04-24 14:01:09 -07:00

disk.go

perf(weed/topology): preallocate the disk volume snapshot (#10609)

2026-08-07 00:30:28 -07:00

node.go

Treat co-located volume servers as one fault domain when balancing and allocating (#9854)

2026-06-07 14:14:45 -07:00

race_condition_stress_test.go

Fix concurrent map access in EC shards info (#8222)

2026-02-05 10:24:18 -08:00

rack.go

cluster: restrict Ping RPC to known peers of the requested type (#9445)

2026-05-12 13:00:52 -07:00

replication_metrics_test.go

feat: add Prometheus metrics for replication operations (#10006)

2026-06-19 11:05:43 -07:00

store_replicate_test.go

topology: fail replica writes fast when a replica is unreachable (#9744)

2026-05-30 10:45:02 -07:00

store_replicate.go

volume: drop stale volume-location cache on under-replication (#10185)

2026-07-01 13:51:59 -07:00

topology_ec_max_volume_id_test.go

fix(master): advance maxVolumeId when registering EC shards (#9827)

2026-06-04 22:25:30 -07:00

topology_ec.go

mount: report data sizes to df with -df.logical (#10459)

2026-07-27 14:28:29 -07:00

topology_event_handling.go

cluster: restrict Ping RPC to known peers of the requested type (#9445)

2026-05-12 13:00:52 -07:00

topology_heartbeat_bench_test.go

perf(weed/topology): preallocate the heartbeat volume conversion slice (#10607)

2026-08-07 00:21:16 -07:00

topology_info.go

fix(master): route ec shard vids to NewEcVids on initial subscribe (#9435)

2026-05-11 10:56:26 -07:00

topology_stats_test.go

mount: report data sizes to df with -df.logical (#10459)

2026-07-27 14:28:29 -07:00

topology_test.go

master: repair the lookup index after a vacuum that raced a disconnect (#10226)

2026-07-03 14:42:33 -07:00

topology_vacuum.go

vacuum: compact a read-only volume when an explicit volumeId is given (#9861)

2026-06-07 22:42:51 -07:00

topology.go

perf(weed/topology): preallocate the heartbeat volume conversion slice (#10607)

2026-08-07 00:21:16 -07:00

volume_growth_reservation_test.go

chore(weed/topology): prune unused functions (#9249)

2026-04-27 15:54:52 -07:00

volume_growth_test.go

Treat co-located volume servers as one fault domain when balancing and allocating (#9854)

2026-06-07 14:14:45 -07:00

volume_growth.go

feat: add Prometheus metric for volume creation operations (#10026)

2026-06-21 10:56:03 -07:00

volume_layout_capacity_recovery_test.go

fix(topology): restore active count after vacuum recovery (#9770)

2026-06-01 15:23:22 -07:00

volume_layout_drain_test.go

feat(master): drain pending size before marking volume readonly (#9036)

2026-04-11 18:29:11 -07:00

volume_layout_grow_test.go

master: count only writable volumes as crowded when deciding growth (#10522)

2026-07-31 19:56:45 -07:00

volume_layout_pick_bench_test.go

feat(master): size-aware volume assignment with weighted selection (#9031)

2026-04-11 09:19:05 -07:00

volume_layout_pick_test.go

fix(master): eagerly remove volume from writable when assign hits limit (#9108)

2026-04-16 12:50:30 -07:00

volume_layout.go

perf(weed/topology): log writable-state changes, not every check (#10612)

2026-08-07 00:44:30 -07:00

volume_location_list.go

fix panic 5435 (#5436)

2024-03-28 16:17:59 -07:00