4 people 3c1e8ca7a8 volume: never finish serving a needle whose data fails its CRC (#11467) ...

* storage: hold back last chunk until CRC verifies on whole-needle reads

Above PagedReadLimit the needle is streamed: headers and body go out
before the checksum is computed, so a corrupted needle was served as
200 with bad bytes and readers could not fall back to a replica. The
final chunk is now written only after the checksum verifies; on a
mismatch the response ends short of Content-Length and the client sees
a failed transfer.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* rust volume: verify needle checksum on streamed reads (parity)

Mirror the Go fix: carry the needle checksum in NeedleStreamInfo and
have StreamingBody accumulate the CRC and verify it before emitting the
last frame; a mismatch ends the body with an error so the client sees
the transfer fail rather than receiving corrupt bytes that look
complete.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* server: abort the transfer when a committed stream fails

A writeFn failure after any byte or WriteHeader call leaves the declared
status and Content-Length already sent; http.Error's text then joins the
body and can exactly fill the withheld tail of a corrupted needle read —
the client sees a complete 200 instead of a failed transfer to retry.

Track whether the response is committed (headers sent, or bytes buffered
for the deferred flush) and panic with http.ErrAbortHandler instead of
appending an error body; pre-commit failures keep the 500 path.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* server: drop the response writer wrapper from the committed-response check

Counting buffered writes is enough: with no bytes buffered the status and
headers cannot have gone out, and the range branches commit via the
explicit WriteHeader call before writeFn runs. The extra ResponseWriter
wrapper added a new Write sink site that CodeQL flags.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

---------

Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

2026-09-26 16:50:41 +08:00

..

remote_storage

volume: one long-lived tokio runtime for blocking tiered S3 reads (#11448)

2026-09-26 12:00:50 +08:00

security

rust: a seaweed-common crate for the address and TLS helpers both crates carry (#11358)

2026-09-20 13:30:58 -07:00

server

volume: never finish serving a needle whose data fails its CRC (#11467)

2026-09-26 16:50:41 +08:00

storage

volume: never finish serving a needle whose data fails its CRC (#11467)

2026-09-26 16:50:41 +08:00

config.rs

volume: reject invalid -minFreeSpace and duration flags at startup like Go (#11447)

2026-09-26 12:00:06 +08:00

images.rs

Rust volume server implementation with CI (#8539)

2026-03-26 17:24:35 -07:00

lib.rs

rust volume: stop glibc retaining freed EC buffers as unreturnable heap (#11255)

2026-09-10 09:29:31 -07:00

main.rs

rust volume: build outgoing gRPC clients in one place and give every dial a connect timeout (#11354)

2026-09-20 19:41:37 -07:00

malloc_tuning.rs

rust volume: stop glibc retaining freed EC buffers as unreturnable heap (#11255)

2026-09-10 09:29:31 -07:00

metrics.rs

s3api: don't delete chunks when CreateEntry outcome is ambiguous (#11376)

2026-09-17 19:58:49 -07:00

security.rs

rust: cargo fmt both crates, with a commented-out fmt --check CI step (#11329)

2026-09-15 09:29:22 -07:00

version.rs

rust: clippy-clean both crates and adopt the std APIs the 1.91 MSRV allows (#11312)

2026-09-14 11:29:29 -07:00