Chris Lu 3cf52f8114 Address second round of Gemini Code Assist review comments ...

Fixed all issues identified in the second review:

1. MEDIUM: Added constants for hardcoded values
   - Defined defaultBlockSize (4 MB) and defaultConcurrency (16)
   - Applied to WriteFile UploadStream options
   - Improves maintainability and readability

2. MEDIUM: Made DeleteFile idempotent
   - Now returns nil (no error) if blob doesn't exist
   - Uses bloberror.HasCode(err, bloberror.BlobNotFound)
   - Consistent with idempotent operation expectations

3. Fixed TestToMetadata test failures
   - Test was using lowercase 'x-amz-meta-' but constant is 'X-Amz-Meta-'
   - Updated test to use s3_constants.AmzUserMetaPrefix
   - All tests now pass

Changes:
- Added import: github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/bloberror
- Added constants: defaultBlockSize, defaultConcurrency
- Updated WriteFile to use constants
- Updated DeleteFile to be idempotent
- Fixed test to use correct S3 metadata prefix constant

All tests pass. Build succeeds. Code follows Azure SDK best practices.

2025-10-08 21:44:41 -07:00

..

azure

Address second round of Gemini Code Assist review comments

2025-10-08 21:44:41 -07:00

gcs

convert error fromating to %w everywhere (#6995)

2025-07-16 23:39:27 -07:00

s3

fix for baidu cloud storage

2025-08-06 20:53:05 -07:00

remote_storage.go

move proto package

2022-08-17 12:05:07 -07:00

track_sync_offset.go

grpc connection to filer add sw-client-id header

2023-01-20 01:48:12 -08:00