mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-27 18:34:19 +00:00
* fix 11400 * persist failed-recovery quarantine and harden rollback - record the unavailable state in a .unavailable marker, fsync it, and re-arm it on load so a restart cannot serve an unverified pair - quarantine the volume so heartbeats stop advertising it - block MarkVolumeWritable while unavailable, rechecked under noWriteLock - fail every request of a failed batch, not only the succeeded ones - restore the needle map and truncate .dat on inline fsync rollback failure - add truncateIndex for the sorted-file needle map - mirror the fail-closed semantics in the Rust volume server * volume: erase rolled-back mappings instead of leaving tombstones A rolled-back batch or failed inline write used Delete() to undo a needle that did not exist beforehand, leaving a tombstoned map entry whose stale offset makes the next write to that needle fail reading a header that no longer exists. Add removeMapping/restoreMapping to the mappers so recovery erases entries that were absent before the batch and reinstates the exact prior offset/size for ones that were, including tombstones. The index row still goes through Delete so a replay forgets the needle. * volume: gate bulk readers on unavailable and fsync the marker's dir - fsync_dir(&self.dir) synced the volume dir's parent, not the dir holding .unavailable; pass the marker path so the create survives a host crash - export UnavailableError and check it in ReadAllNeedles, VolumeTailSender, VolumeIncrementalCopy, and IncrementalBackup so replica-sync paths cannot stream or append data from an unverified .dat/.idx pair; mirror on the Rust side via read_dat_slice, read_all_needles, dat_scan_plan, and the incremental-copy handler * volume: drop issue references from comments near touched code * volume: stop active scans when the volume becomes unavailable The stream entry-point checks ran once per RPC, so a volume quarantined by a failed recovery mid-scan kept serving data. Recheck availability per needle/chunk on the detached read paths: tail scan and heartbeat, read-all, incremental copy, incremental backup writes, and the Rust StreamingBody chunk reads. Rust incremental copy also rejects a quarantined volume before sync_to_disk touches the backend. --------- Co-authored-by: Chris Lu <chris.lu@gmail.com>
122 lines
3.2 KiB
Go
122 lines
3.2 KiB
Go
package storage
|
|
|
|
import (
|
|
"io"
|
|
"os"
|
|
"sync"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/idx"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle_map"
|
|
. "github.com/seaweedfs/seaweedfs/weed/storage/types"
|
|
"github.com/syndtr/goleveldb/leveldb/opt"
|
|
)
|
|
|
|
type NeedleMapKind int
|
|
|
|
const (
|
|
NeedleMapInMemory NeedleMapKind = iota
|
|
NeedleMapLevelDb // small memory footprint, 4MB total, 1 write buffer, 3 block buffer
|
|
NeedleMapLevelDbMedium // medium memory footprint, 8MB total, 3 write buffer, 5 block buffer
|
|
NeedleMapLevelDbLarge // large memory footprint, 12MB total, 4write buffer, 8 block buffer
|
|
)
|
|
|
|
type NeedleMapper interface {
|
|
Put(key NeedleId, offset Offset, size Size) error
|
|
Get(key NeedleId) (element *needle_map.NeedleValue, ok bool)
|
|
Delete(key NeedleId, offset Offset) error
|
|
Close()
|
|
Destroy() error
|
|
ContentSize() uint64
|
|
DeletedSize() uint64
|
|
FileCount() int
|
|
DeletedCount() int
|
|
MaxFileKey() NeedleId
|
|
MaxNeedleEnd() int64
|
|
IndexFileSize() uint64
|
|
Sync() error
|
|
ReadIndexEntry(n int64) (key NeedleId, offset Offset, size Size, err error)
|
|
}
|
|
|
|
type batchIndexRollbacker interface {
|
|
truncateIndex(offset int64) error
|
|
}
|
|
|
|
// batchMapRollbacker restores the in-memory/durable needle mapping without
|
|
// touching the index file: a rolled-back batch rewrites the index wholesale
|
|
// via truncateIndex, so replay-correcting entries are not needed here.
|
|
type batchMapRollbacker interface {
|
|
removeMapping(key NeedleId) error
|
|
restoreMapping(key NeedleId, offset Offset, size Size) error
|
|
}
|
|
|
|
type batchMetricRollbacker interface {
|
|
snapshotBatchMetrics() batchMapMetricSnapshot
|
|
restoreBatchMetrics(snapshot batchMapMetricSnapshot)
|
|
}
|
|
|
|
type baseNeedleMapper struct {
|
|
mapMetric
|
|
|
|
indexFile *os.File
|
|
indexFileAccessLock sync.Mutex
|
|
indexFileOffset int64
|
|
}
|
|
|
|
type TempNeedleMapper interface {
|
|
NeedleMapper
|
|
DoOffsetLoading(v *Volume, indexFile *os.File, startFrom uint64) error
|
|
UpdateNeedleMap(v *Volume, indexFile *os.File, opts *opt.Options, ldbTimeout int64) error
|
|
}
|
|
|
|
func (nm *baseNeedleMapper) IndexFileSize() uint64 {
|
|
stat, err := nm.indexFile.Stat()
|
|
if err == nil {
|
|
return uint64(stat.Size())
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func (nm *baseNeedleMapper) appendToIndexFile(key NeedleId, offset Offset, size Size) error {
|
|
bytes := needle_map.ToBytes(key, offset, size)
|
|
|
|
nm.indexFileAccessLock.Lock()
|
|
defer nm.indexFileAccessLock.Unlock()
|
|
written, err := nm.indexFile.WriteAt(bytes, nm.indexFileOffset)
|
|
if err == nil {
|
|
nm.indexFileOffset += int64(written)
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (nm *baseNeedleMapper) Sync() error {
|
|
return nm.indexFile.Sync()
|
|
}
|
|
|
|
func (nm *baseNeedleMapper) truncateIndex(offset int64) error {
|
|
nm.indexFileAccessLock.Lock()
|
|
defer nm.indexFileAccessLock.Unlock()
|
|
|
|
if err := nm.indexFile.Truncate(offset); err != nil {
|
|
return err
|
|
}
|
|
nm.indexFileOffset = offset
|
|
return nil
|
|
}
|
|
|
|
func (nm *baseNeedleMapper) ReadIndexEntry(n int64) (key NeedleId, offset Offset, size Size, err error) {
|
|
bytes := make([]byte, NeedleMapEntrySize)
|
|
var readCount int
|
|
if readCount, err = nm.indexFile.ReadAt(bytes, n*NeedleMapEntrySize); err != nil {
|
|
if err == io.EOF {
|
|
if readCount == NeedleMapEntrySize {
|
|
err = nil
|
|
}
|
|
}
|
|
if err != nil {
|
|
return
|
|
}
|
|
}
|
|
key, offset, size = idx.IdxFileEntry(bytes)
|
|
return
|
|
}
|