mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-19 21:56:54 +00:00
* filer: add filer.options.disable_remote_storage_deletion for cache-only deletes Deleting a filer entry under a remote.mount path also deletes the backing object from the remote store (maybeDeleteFromRemote). Deployments that use a remote mount as a read-through cache in front of an authoritative, externally-managed object store cannot allow this: the filer typically holds read-only credentials, so the remote delete fails and the entire delete errors out; and even where it would succeed, it destroys data the filer does not own. Add filer.options.disable_remote_storage_deletion (default false, so existing behaviour is unchanged). When enabled, maybeDeleteFromRemote is skipped for both single-entry and recursive folder deletes: local metadata and cached chunks are still removed, but the remote object is left intact. * filer: assert local removal in cache-only recursive delete test The recursive cache-only delete test only checked that no remote delete happened; it did not verify the local child and directory entries were removed. Add FindEntry assertions so a regression that skips local recursive deletion is caught. * filer: reload the remote mount mapping when /etc/remote changes The mapping was only read at startup, so remote.unmount left the mount live in the filer: the purge that follows the mapping delete then went to the remote store and wiped every object under the mount. Rebuild the rules trie and the conf map from scratch on each load, since ptrie cannot drop a key, and swap them under a lock. * filer: drop the filer-wide remote deletion switch With the mapping reloaded on unmount, the purge no longer reaches the remote store, so there is nothing left for the switch to protect against. --------- Co-authored-by: Chris Lu <chris.lu@gmail.com>
128 lines
3.5 KiB
Go
128 lines
3.5 KiB
Go
package shell
|
|
|
|
import (
|
|
"context"
|
|
"flag"
|
|
"fmt"
|
|
"io"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/filer"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/remote_storage"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
func init() {
|
|
Commands = append(Commands, &commandRemoteUnmount{})
|
|
}
|
|
|
|
type commandRemoteUnmount struct {
|
|
}
|
|
|
|
func (c *commandRemoteUnmount) Name() string {
|
|
return "remote.unmount"
|
|
}
|
|
|
|
func (c *commandRemoteUnmount) Help() string {
|
|
return `unmount remote storage
|
|
|
|
# assume a remote storage is configured to name "s3_1"
|
|
remote.configure -name=s3_1 -type=s3 -s3.access_key=xxx -s3.secret_key=yyy
|
|
# mount and pull one bucket
|
|
remote.mount -dir=/xxx -remote=s3_1/bucket
|
|
|
|
# unmount the mounted directory and remove its cache
|
|
remote.unmount -dir=/xxx
|
|
|
|
`
|
|
}
|
|
|
|
func (c *commandRemoteUnmount) HasTag(CommandTag) bool {
|
|
return false
|
|
}
|
|
|
|
func (c *commandRemoteUnmount) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
|
|
|
|
remoteMountCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
|
|
|
|
dir := remoteMountCommand.String("dir", "", "a directory in filer")
|
|
|
|
if err = remoteMountCommand.Parse(args); err != nil {
|
|
return nil
|
|
}
|
|
|
|
mappings, listErr := filer.ReadMountMappings(commandEnv.option.GrpcDialOption, commandEnv.option.FilerAddress)
|
|
if listErr != nil {
|
|
return listErr
|
|
}
|
|
if *dir == "" {
|
|
return jsonPrintln(writer, mappings)
|
|
}
|
|
|
|
_, found := mappings.Mappings[*dir]
|
|
if !found {
|
|
return fmt.Errorf("directory %s is not mounted", *dir)
|
|
}
|
|
|
|
// delete the mount mapping first: the filer reloads it on the spot, so the
|
|
// purge below stays local instead of deleting the remote objects
|
|
fmt.Fprintf(writer, "deleting mount for %s ...\n", *dir)
|
|
if err = filer.DeleteMountMapping(commandEnv, *dir); err != nil {
|
|
return fmt.Errorf("delete mount mapping: %w", err)
|
|
}
|
|
|
|
// purge mounted data
|
|
fmt.Fprintf(writer, "purge %s ...\n", *dir)
|
|
if err = c.purgeMountedData(commandEnv, *dir); err != nil {
|
|
return fmt.Errorf("purge mounted data: %w", err)
|
|
}
|
|
|
|
// reset remote sync offset in case the folder is mounted again
|
|
if err = remote_storage.SetSyncOffset(commandEnv.option.GrpcDialOption, commandEnv.option.FilerAddress, *dir, time.Now().UnixNano()); err != nil {
|
|
return fmt.Errorf("reset remote.sync offset for %s: %v", *dir, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (c *commandRemoteUnmount) purgeMountedData(commandEnv *CommandEnv, dir string) error {
|
|
|
|
// find existing directory, and ensure the directory is empty
|
|
err := commandEnv.WithFilerClient(false, func(client filer_pb.SeaweedFilerClient) error {
|
|
ctx := context.Background()
|
|
parent, name := util.FullPath(dir).DirAndName()
|
|
lookupResp, lookupErr := client.LookupDirectoryEntry(context.Background(), &filer_pb.LookupDirectoryEntryRequest{
|
|
Directory: parent,
|
|
Name: name,
|
|
})
|
|
if lookupErr != nil {
|
|
return fmt.Errorf("lookup %s: %v", dir, lookupErr)
|
|
}
|
|
|
|
oldEntry := lookupResp.Entry
|
|
|
|
deleteError := filer_pb.DoRemove(ctx, client, parent, name, true, true, true, false, nil)
|
|
if deleteError != nil {
|
|
return fmt.Errorf("delete %s: %v", dir, deleteError)
|
|
}
|
|
|
|
mkdirErr := filer_pb.DoMkdir(ctx, client, parent, name, func(entry *filer_pb.Entry) {
|
|
entry.Attributes = oldEntry.Attributes
|
|
entry.Extended = oldEntry.Extended
|
|
entry.Attributes.Crtime = time.Now().Unix()
|
|
entry.Attributes.Mtime = time.Now().Unix()
|
|
})
|
|
if mkdirErr != nil {
|
|
return fmt.Errorf("mkdir %s: %v", dir, mkdirErr)
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|