mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-16 20:26:45 +00:00
Chris LuandGitHub
6e6255b58e
LiveMoveVolume and the copy, tail, delete, mark, replicate, and configure helpers around it issued every RPC on context.Background(), so a caller had no way to bound or abort a move once it started. They now take a context, which the exported LiveMoveVolume in particular needs: callers outside the shell drive long moves and want to stop them. The deferred restore in copyVolume runs on a detached, bounded context rather than the caller's. Marking the source writable again is cleanup, and cancelling the copy must not skip it and leave the volume readonly — the same guard balance_task.go already applies for the same reason. Shell commands pass context.Background(): their Do signature carries no context, and changing it would touch every command in the package. Claude-Session: https://claude.ai/code/session_01Ks16jnt4S7gdDk8cheQ3xu
98 lines
3.0 KiB
Go
98 lines
3.0 KiB
Go
package shell
|
|
|
|
import (
|
|
"context"
|
|
"flag"
|
|
"io"
|
|
"log"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
)
|
|
|
|
func init() {
|
|
Commands = append(Commands, &commandVolumeDeleteEmpty{})
|
|
}
|
|
|
|
type commandVolumeDeleteEmpty struct {
|
|
}
|
|
|
|
func (c *commandVolumeDeleteEmpty) Name() string {
|
|
return "volume.deleteEmpty"
|
|
}
|
|
|
|
func (c *commandVolumeDeleteEmpty) Help() string {
|
|
return `delete empty volumes from all volume servers
|
|
|
|
volume.deleteEmpty -quietFor=24h -apply
|
|
volume.deleteEmpty -collectionPattern=important* -quietFor=24h -apply
|
|
|
|
This command deletes all empty volumes from one volume server.
|
|
|
|
`
|
|
}
|
|
|
|
func (c *commandVolumeDeleteEmpty) HasTag(CommandTag) bool {
|
|
return false
|
|
}
|
|
|
|
func (c *commandVolumeDeleteEmpty) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
|
|
|
|
volDeleteCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
|
|
quietPeriod := volDeleteCommand.Duration("quietFor", 24*time.Hour, "select empty volumes with no recent writes, avoid newly created ones")
|
|
collectionPattern := volDeleteCommand.String("collectionPattern", "", "match with wildcard characters '*' and '?'")
|
|
applyBalancing := volDeleteCommand.Bool("apply", false, "apply to delete empty volumes")
|
|
// TODO: remove this alias
|
|
applyBalancingAlias := volDeleteCommand.Bool("force", false, "apply to delete empty volumes (alias for -apply)")
|
|
if err = volDeleteCommand.Parse(args); err != nil {
|
|
return nil
|
|
}
|
|
|
|
handleDeprecatedForceFlag(writer, volDeleteCommand, applyBalancingAlias, applyBalancing)
|
|
infoAboutSimulationMode(writer, *applyBalancing, "-apply")
|
|
|
|
if err = commandEnv.confirmIsLocked(args); err != nil {
|
|
return
|
|
}
|
|
|
|
// collect topology information
|
|
topologyInfo, _, err := collectTopologyInfo(commandEnv, 0)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
quietSeconds := int64(*quietPeriod / time.Second)
|
|
nowUnixSeconds := time.Now().Unix()
|
|
|
|
eachDataNode(topologyInfo, func(dc DataCenterId, rack RackId, dn *master_pb.DataNodeInfo) {
|
|
for _, diskInfo := range dn.DiskInfos {
|
|
for _, v := range diskInfo.VolumeInfos {
|
|
if isEmptyVolumeDeleteCandidate(v, quietSeconds, nowUnixSeconds, *collectionPattern) {
|
|
if *applyBalancing {
|
|
log.Printf("deleting empty volume %d from %s", v.Id, dn.Id)
|
|
if deleteErr := deleteVolume(context.Background(), commandEnv.option.GrpcDialOption, needle.VolumeId(v.Id),
|
|
pb.NewServerAddressFromDataNode(dn), true, false); deleteErr != nil {
|
|
err = deleteErr
|
|
}
|
|
continue
|
|
} else {
|
|
log.Printf("empty volume %d from %s", v.Id, dn.Id)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
})
|
|
|
|
return
|
|
}
|
|
|
|
func isEmptyVolumeDeleteCandidate(v *master_pb.VolumeInformationMessage, quietSeconds, nowUnixSeconds int64, collectionPattern string) bool {
|
|
return matchesVolumeCollectionPattern(collectionPattern, v.Collection) &&
|
|
v.Size <= super_block.SuperBlockSize &&
|
|
v.ModifiedAtSecond > 0 &&
|
|
v.ModifiedAtSecond+quietSeconds < nowUnixSeconds
|
|
}
|