Chris Lu b2d65168ab Address third round of Gemini Code Assist review comments ...

Fixed all issues identified in the third review:

1. MEDIUM: Use bloberror.HasCode for ContainerAlreadyExists
   - Replaced fragile string check with bloberror.HasCode()
   - More robust and aligned with Azure SDK best practices
   - Applied to CreateBucket test

2. MEDIUM: Use bloberror.HasCode for BlobNotFound in test
   - Replaced generic error check with specific BlobNotFound check
   - Makes test more precise and verifies correct error returned
   - Applied to VerifyDeleted test

3. MEDIUM: Made DeleteEntry idempotent in azure_sink.go
   - Now returns nil (no error) if blob doesn't exist
   - Uses bloberror.HasCode(err, bloberror.BlobNotFound)
   - Consistent with DeleteFile implementation
   - Makes replication sink more robust to retries

Changes:
- Added import to azure_storage_client_test.go: bloberror
- Added import to azure_sink.go: bloberror
- Updated CreateBucket test to use bloberror.HasCode
- Updated VerifyDeleted test to use bloberror.HasCode
- Updated DeleteEntry to be idempotent

All tests pass. Build succeeds. Code uses Azure SDK best practices.

2025-10-08 21:56:10 -07:00

..

repl_util

Add context with request (#6824)

2025-05-28 11:34:02 -07:00

sink

Address third round of Gemini Code Assist review comments

2025-10-08 21:56:10 -07:00

source

Changes logging function (#6919)

2025-06-24 08:44:06 -07:00

sub

convert error fromating to %w everywhere (#6995)

2025-07-16 23:39:27 -07:00

replicator.go

convert error fromating to %w everywhere (#6995)

2025-07-16 23:39:27 -07:00