mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-04 15:17:09 +00:00
Chris LuandGitHub
21b4b81edb
* fix(filer/postgres): default to ON CONFLICT upsert to keep tx alive A KvPut from the inode-index secondary write could fail with 23505 (duplicate key) inside a rename's transaction, after which the next statement returned 25P02 and rename surfaced to FUSE as EIO. Default the postgres upsert query when enableUpsert=true so INSERTs are idempotent; the enableUpsert=false escape hatch is preserved for non-PG-compatible backends. * fix(filer/mysql): default to ON DUPLICATE KEY UPDATE upsert Same shape as the postgres default: when enableUpsert=true but no upsertQuery is configured, install a sensible default so the inode-index KvPut does not waste a duplicate-key roundtrip on every entry write. Uses the VALUES() form so the default works on MariaDB and MySQL >=5.7; the MySQL 8.0.19 row-alias form is left to explicit config. * fix(filer): default enableUpsert=true for sql stores The default-template fallback only kicks in when enableUpsert=true, so minimal configs that omit the flag entirely were still exposed. Default it on for postgres/postgres2/mysql/mysql2; an explicit false in filer.toml still wins because SetDefault only fills absent keys.
66 lines
2.5 KiB
Go
66 lines
2.5 KiB
Go
package mysql
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
_ "github.com/go-sql-driver/mysql"
|
|
"github.com/seaweedfs/seaweedfs/weed/filer/abstract_sql"
|
|
)
|
|
|
|
type SqlGenMysql struct {
|
|
CreateTableSqlTemplate string
|
|
DropTableSqlTemplate string
|
|
UpsertQueryTemplate string
|
|
}
|
|
|
|
// DefaultUpsertQuery keeps INSERTs idempotent so the inode-index KvPut
|
|
// after every entry write does not emit a duplicate-key roundtrip on
|
|
// every mutation. The VALUES() form works on MariaDB and MySQL >=5.7;
|
|
// the newer "AS new" alias from MySQL 8.0.19 errors on MariaDB, so it
|
|
// is left for users to opt into via an explicit upsertQuery.
|
|
const DefaultUpsertQuery = "INSERT INTO `%s` (`dirhash`,`name`,`directory`,`meta`) VALUES(?,?,?,?) ON DUPLICATE KEY UPDATE `meta` = VALUES(`meta`)"
|
|
|
|
var (
|
|
_ = abstract_sql.SqlGenerator(&SqlGenMysql{})
|
|
)
|
|
|
|
func (gen *SqlGenMysql) GetSqlInsert(tableName string) string {
|
|
if gen.UpsertQueryTemplate != "" {
|
|
return fmt.Sprintf(gen.UpsertQueryTemplate, tableName)
|
|
} else {
|
|
return fmt.Sprintf("INSERT INTO `%s` (`dirhash`,`name`,`directory`,`meta`) VALUES(?,?,?,?)", tableName)
|
|
}
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlUpdate(tableName string) string {
|
|
return fmt.Sprintf("UPDATE `%s` SET `meta` = ? WHERE `dirhash` = ? AND `name` = ? AND `directory` = ?", tableName)
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlFind(tableName string) string {
|
|
return fmt.Sprintf("SELECT `meta` FROM `%s` WHERE `dirhash` = ? AND `name` = ? AND `directory` = ?", tableName)
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlDelete(tableName string) string {
|
|
return fmt.Sprintf("DELETE FROM `%s` WHERE `dirhash` = ? AND `name` = ? AND `directory` = ?", tableName)
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlDeleteFolderChildren(tableName string) string {
|
|
return fmt.Sprintf("DELETE FROM `%s` WHERE `dirhash` = ? AND `directory` = ?", tableName)
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlListExclusive(tableName string) string {
|
|
return fmt.Sprintf("SELECT `name`, `meta` FROM `%s` WHERE `dirhash` = ? AND `name` > ? AND `directory` = ? AND `name` LIKE ? ORDER BY `name` ASC LIMIT ?", tableName)
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlListInclusive(tableName string) string {
|
|
return fmt.Sprintf("SELECT `name`, `meta` FROM `%s` WHERE `dirhash` = ? AND `name` >= ? AND `directory` = ? AND `name` LIKE ? ORDER BY `name` ASC LIMIT ?", tableName)
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlCreateTable(tableName string) string {
|
|
return fmt.Sprintf(gen.CreateTableSqlTemplate, tableName)
|
|
}
|
|
|
|
func (gen *SqlGenMysql) GetSqlDropTable(tableName string) string {
|
|
return fmt.Sprintf(gen.DropTableSqlTemplate, tableName)
|
|
}
|