mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-04 15:17:09 +00:00
Chris LuandGitHub
21b4b81edb
* fix(filer/postgres): default to ON CONFLICT upsert to keep tx alive A KvPut from the inode-index secondary write could fail with 23505 (duplicate key) inside a rename's transaction, after which the next statement returned 25P02 and rename surfaced to FUSE as EIO. Default the postgres upsert query when enableUpsert=true so INSERTs are idempotent; the enableUpsert=false escape hatch is preserved for non-PG-compatible backends. * fix(filer/mysql): default to ON DUPLICATE KEY UPDATE upsert Same shape as the postgres default: when enableUpsert=true but no upsertQuery is configured, install a sensible default so the inode-index KvPut does not waste a duplicate-key roundtrip on every entry write. Uses the VALUES() form so the default works on MariaDB and MySQL >=5.7; the MySQL 8.0.19 row-alias form is left to explicit config. * fix(filer): default enableUpsert=true for sql stores The default-template fallback only kicks in when enableUpsert=true, so minimal configs that omit the flag entirely were still exposed. Default it on for postgres/postgres2/mysql/mysql2; an explicit false in filer.toml still wins because SetDefault only fills absent keys.
29 lines
873 B
Go
29 lines
873 B
Go
package mysql
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestDefaultUpsertQueryUsesOnDuplicateKey(t *testing.T) {
|
|
gen := &SqlGenMysql{UpsertQueryTemplate: DefaultUpsertQuery}
|
|
got := gen.GetSqlInsert("filemeta")
|
|
if !strings.Contains(got, "ON DUPLICATE KEY UPDATE") {
|
|
t.Fatalf("expected ON DUPLICATE KEY UPDATE in default upsert, got: %s", got)
|
|
}
|
|
if strings.Contains(got, "AS `new`") {
|
|
t.Fatalf("default should avoid MySQL 8.0.19 row-alias syntax for MariaDB compat, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "`filemeta`") {
|
|
t.Fatalf("expected backticked table name, got: %s", got)
|
|
}
|
|
}
|
|
|
|
func TestEmptyUpsertTemplateFallsBackToPlainInsert(t *testing.T) {
|
|
gen := &SqlGenMysql{}
|
|
got := gen.GetSqlInsert("filemeta")
|
|
if strings.Contains(got, "ON DUPLICATE KEY UPDATE") {
|
|
t.Fatalf("plain INSERT path should not contain ON DUPLICATE KEY UPDATE, got: %s", got)
|
|
}
|
|
}
|