mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-05-30 13:36:23 +00:00
* refactor(volume): extract replica sync/select into shared volume_replica package Move the volume replica reconciliation helpers (status, union builder, SyncAndSelectBestReplica, ReadNeedleMeta) out of the shell into a new weed/storage/volume_replica package so both the shell (ec.encode, volume.tier.move, volume.check.disk) and the EC encode worker can reuse them. No behavior change. * fix(ec): bring ec.encode worker to parity with the shell - Sync replicas and encode the most-complete one (via the shared volume_replica.SyncAndSelectBestReplica) instead of a possibly-stale replica, marking all replicas readonly first. Prevents silent data loss when a stale replica is encoded and the originals deleted. - Skip remote/tiered volumes in detection (shell ec.encode excludes them). - Min-node safety gate: refuse to encode when cluster nodes < parity shards. - Align default thresholds with the shell (fullness 0.95, quiet 1h). * fix(vacuum): plugin path honors min_volume_age_seconds override deriveVacuumConfig hard-coded MinVolumeAgeSeconds=0, dropping any configured value. Read it from worker config (default 0, matching the shell/master vacuum which has no age gate) so an explicit override is honored. * address review feedback - config.go: align GetConfigSpec schema defaults (quiet_for_seconds=3600, fullness_ratio=0.95) with the runtime defaults so UI/bootstrap flows match the shell (coderabbitai). - ec_task.go: roll back readonly when markReplicasReadonly fails partway, so already-marked replicas don't stay readonly (coderabbitai). - volume_replica: pass the caller's replica statuses into buildUnionReplica instead of re-fetching them, and skip the per-needle ReadNeedleMeta RPC when the source replica is read-only (gemini-code-assist). * test(plugin_workers/ec): make fixtures eligible under the new defaults The default EC encode thresholds were raised to match the shell (fullness 0.95, quiet 1h), but the plugin-worker integration fixtures still used 90%-full / 10-minute-old volumes, so detection found no eligible volumes and the tests failed in CI. Bump the eligible fixtures to 96% full and 2h old.
203 lines
5.0 KiB
Go
203 lines
5.0 KiB
Go
package shell
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/operation"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/volume_server_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle_map"
|
|
|
|
"google.golang.org/grpc"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
"github.com/seaweedfs/seaweedfs/weed/wdclient"
|
|
"github.com/seaweedfs/seaweedfs/weed/wdclient/exclusive_locks"
|
|
)
|
|
|
|
type ShellOptions struct {
|
|
Masters *string
|
|
GrpcDialOption grpc.DialOption
|
|
// shell transient context
|
|
FilerHost string
|
|
FilerPort int64
|
|
FilerGroup *string
|
|
FilerAddress pb.ServerAddress
|
|
Directory string
|
|
Debug bool
|
|
}
|
|
|
|
type CommandEnv struct {
|
|
env map[string]string
|
|
MasterClient *wdclient.MasterClient
|
|
option *ShellOptions
|
|
locker *exclusive_locks.ExclusiveLocker
|
|
noLock bool
|
|
forceNoLock bool
|
|
verbose bool
|
|
}
|
|
|
|
func NewCommandEnv(options *ShellOptions) *CommandEnv {
|
|
ce := &CommandEnv{
|
|
env: make(map[string]string),
|
|
MasterClient: wdclient.NewMasterClient(options.GrpcDialOption, *options.FilerGroup, pb.AdminShellClient, "", "", "", *pb.ServerAddresses(*options.Masters).ToServiceDiscovery()),
|
|
option: options,
|
|
noLock: false,
|
|
}
|
|
ce.locker = exclusive_locks.NewExclusiveLocker(ce.MasterClient, "shell")
|
|
return ce
|
|
}
|
|
|
|
func (ce *CommandEnv) parseUrl(input string) (path string, err error) {
|
|
if strings.HasPrefix(input, "http") {
|
|
err = fmt.Errorf("http://<filer>:<port> prefix is not supported any more")
|
|
return
|
|
}
|
|
if !strings.HasPrefix(input, "/") {
|
|
input = util.Join(ce.option.Directory, input)
|
|
}
|
|
return input, err
|
|
}
|
|
|
|
func (ce *CommandEnv) isDirectory(path string) bool {
|
|
|
|
return ce.checkDirectory(path) == nil
|
|
|
|
}
|
|
|
|
func (ce *CommandEnv) confirmIsLocked(args []string) error {
|
|
|
|
if ce.noLock || ce.forceNoLock {
|
|
return nil
|
|
}
|
|
if ce.locker.IsLocked() {
|
|
return nil
|
|
}
|
|
ce.locker.SetMessage(fmt.Sprintf("%v", args))
|
|
|
|
return fmt.Errorf("need to run \"lock\" first to continue")
|
|
|
|
}
|
|
|
|
func (ce *CommandEnv) SetNoLock(noLock bool) {
|
|
if ce == nil {
|
|
return
|
|
}
|
|
ce.noLock = noLock
|
|
}
|
|
|
|
func (ce *CommandEnv) ForceNoLock() {
|
|
if ce == nil {
|
|
return
|
|
}
|
|
ce.forceNoLock = true
|
|
}
|
|
|
|
func (ce *CommandEnv) isLocked() bool {
|
|
if ce == nil {
|
|
return true
|
|
}
|
|
if ce.noLock || ce.forceNoLock {
|
|
return true
|
|
}
|
|
return ce.locker.IsLocked()
|
|
}
|
|
|
|
func (ce *CommandEnv) checkDirectory(path string) error {
|
|
|
|
dir, name := util.FullPath(path).DirAndName()
|
|
|
|
exists, err := filer_pb.Exists(context.Background(), ce, dir, name, true)
|
|
|
|
if !exists {
|
|
return fmt.Errorf("%s is not a directory", path)
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
var _ = filer_pb.FilerClient(&CommandEnv{})
|
|
|
|
func (ce *CommandEnv) WithFilerClient(streamingMode bool, fn func(filer_pb.SeaweedFilerClient) error) error {
|
|
|
|
return pb.WithGrpcFilerClient(streamingMode, 0, ce.option.FilerAddress, ce.option.GrpcDialOption, fn)
|
|
|
|
}
|
|
|
|
func (ce *CommandEnv) AdjustedUrl(location *filer_pb.Location) string {
|
|
return location.Url
|
|
}
|
|
|
|
func (ce *CommandEnv) GetDataCenter() string {
|
|
return ce.MasterClient.GetDataCenter()
|
|
}
|
|
|
|
func findInputDirectory(args []string) (input string) {
|
|
input = "."
|
|
if len(args) > 0 {
|
|
input = args[len(args)-1]
|
|
if strings.HasPrefix(input, "-") {
|
|
input = "."
|
|
}
|
|
}
|
|
return input
|
|
}
|
|
|
|
// isHelpRequest checks if the args contain a help flag (-h, --help, or -help)
|
|
// It also handles combined short flags like -lh or -hl
|
|
func isHelpRequest(args []string) bool {
|
|
for _, arg := range args {
|
|
// Check for exact matches
|
|
if arg == "-h" || arg == "--help" || arg == "-help" {
|
|
return true
|
|
}
|
|
// Check for combined short flags (e.g., -lh, -hl, -rfh)
|
|
// Limit to reasonable length (2-4 chars total) to avoid matching long options like -verbose
|
|
if strings.HasPrefix(arg, "-") && !strings.HasPrefix(arg, "--") && len(arg) > 1 && len(arg) <= 4 {
|
|
for _, char := range arg[1:] {
|
|
if char == 'h' {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// handleHelpRequest checks for help flags and prints the help message if requested.
|
|
// It returns true if the help message was printed, indicating the command should exit.
|
|
func handleHelpRequest(c command, args []string, writer io.Writer) bool {
|
|
if isHelpRequest(args) {
|
|
fmt.Fprintln(writer, c.Help())
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
func readNeedleStatus(grpcDialOption grpc.DialOption, sourceVolumeServer pb.ServerAddress, volumeId uint32, needleValue needle_map.NeedleValue) (resp *volume_server_pb.VolumeNeedleStatusResponse, err error) {
|
|
err = operation.WithVolumeServerClient(false, sourceVolumeServer, grpcDialOption,
|
|
func(client volume_server_pb.VolumeServerClient) error {
|
|
if resp, err = client.VolumeNeedleStatus(context.Background(), &volume_server_pb.VolumeNeedleStatusRequest{
|
|
VolumeId: volumeId,
|
|
NeedleId: uint64(needleValue.Key),
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
},
|
|
)
|
|
return
|
|
}
|
|
|
|
func getCollectionName(commandEnv *CommandEnv, bucket string) string {
|
|
if *commandEnv.option.FilerGroup != "" {
|
|
return fmt.Sprintf("%s_%s", *commandEnv.option.FilerGroup, bucket)
|
|
}
|
|
return bucket
|
|
}
|