pingqiuandClaude Opus 4.6 bc767eb9d2 fix: rebuild correctness — single completion, fail-closed acks, diagnostic logging ...

Three correctness fixes for the remote rebuild path:

1. No double completion: for remote rebuilds, OnRebuildCompleted skips
   RebuildCommitted since ObserveReplicaRebuildSessionAck already emitted
   SessionCompleted on the accepted ack. One rebuild = one completion event.

2. SessionAckFailed with rejected observation: if OnAck rejects the failed
   ack (stale session), don't use the sentinel errRebuildAckFailed. Return
   a regular error so ExecutePendingRebuild emits the fallback SessionFailed.
   No path leaves the engine session hanging.

3. Diagnostic logging in ExecutePendingRebuild: log the replicaID and
   targetLSN on both nil-return (TakeRebuild mismatch) and successful take
   paths. Also log the pending store in runRebuild with replicaID, targetLSN,
   and IO type. This makes the TakeRebuild seam diagnosable on hardware
   without rebuilding the engine package.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-04-09 15:25:26 -07:00

..

blockcmd

refactor: close bounded recovery drain and invalidation seams

2026-04-04 11:01:12 -07:00

constants

Nit: use time.Durations instead of constants in seconds. (#7438)

2025-11-04 13:02:22 -08:00

filer_ui

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

master_ui

fix format of internal node URLs in master UI templates

2026-02-22 13:47:29 -08:00

postgres

Move SQL engine and PostgreSQL server to their own binaries (#8417)

2026-02-23 16:27:08 -08:00

volume_server_ui

fix: EC UI template error when viewing shard details (#7955)

2026-01-03 22:45:48 -08:00

block_heartbeat_loop_test.go

test: align collector readiness check with replica eligibility

2026-04-04 14:03:21 -07:00

block_heartbeat_loop.go

feat: CP13-8 PASSES — real-workload validation on RF=2 sync_all

2026-04-03 14:24:13 -07:00

block_protocol_state.go

feat: protocol-aware execution wave — phase gate for live WAL shipping

2026-04-05 23:47:07 -07:00

block_rebuild_remote.go

fix: rebuild correctness — single completion, fail-closed acks, diagnostic logging

2026-04-09 15:25:26 -07:00

block_rebuild_session.go

feat: rebuild hardening A1-A5 + session-controlled execution path

2026-04-08 14:39:11 -07:00

block_recovery_adversarial_test.go

feat: Phase 10 — control-plane closure (identity, convergence, idempotence)

2026-04-02 16:25:43 -07:00

block_recovery_test.go

feat: RemoteRebuildIO — primary coordinates rebuild, replica installs

2026-04-09 15:04:22 -07:00

block_recovery.go

fix: rebuild correctness — single completion, fail-closed acks, diagnostic logging

2026-04-09 15:25:26 -07:00

block_service_host_effects.go

refactor: extract host effects adapter and define Phase 17 stop line

2026-04-04 08:43:21 -07:00

common_test.go

…

common.go

fix: Use mime.FormatMediaType for RFC 6266 compliant Content-Disposition (#7635)

2025-12-05 15:59:12 -08:00

filer_grpc_server_admin.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

filer_grpc_server_dlm.go

reduce logs

2025-12-26 13:26:25 -08:00

filer_grpc_server_kv.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

filer_grpc_server_remote.go

s3: fix remote object not caching (#7790)

2025-12-16 12:41:04 -08:00

filer_grpc_server_rename.go

Prevent bucket renaming in filer, fuse mount, and S3 (#8048)

2026-01-16 19:48:09 -08:00

filer_grpc_server_sub_meta.go

avoid repeated reading disk (#7369)

2025-10-24 01:26:42 -07:00

filer_grpc_server_traverse_meta_test.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

filer_grpc_server_traverse_meta.go

Add error list each entry func (#7485)

2025-11-25 19:35:19 -08:00

filer_grpc_server.go

filer: preserve existing TTL during CreateEntry/UpdateEntry gRPC calls

2026-01-29 14:42:09 -08:00

filer_jwt_test.go

fix Filer startup failure due to JWT on / path #8149 (#8167)

2026-01-29 21:45:15 -08:00

filer_server_handlers_copy.go

use one http client

2025-08-11 16:45:13 -07:00

filer_server_handlers_iam_grpc.go

Implement IAM propagation to S3 servers (#8130)

2026-01-26 22:59:43 -08:00

filer_server_handlers_proxy.go

Changes logging function (#6919)

2025-06-24 08:44:06 -07:00

filer_server_handlers_read_dir.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

filer_server_handlers_read.go

S3: set identity to request context, and remove obsolete code (#7523)

2025-11-21 14:46:32 -08:00

filer_server_handlers_tagging.go

Changes logging function (#6919)

2025-06-24 08:44:06 -07:00

filer_server_handlers_write_autochunk.go

filer write request use context without cancellation (#7567)

2025-11-28 11:52:57 -08:00

filer_server_handlers_write_cipher.go

convert error fromating to %w everywhere (#6995)

2025-07-16 23:39:27 -07:00

filer_server_handlers_write_merge.go

S3 API: Add SSE-KMS (#7144)

2025-08-21 08:28:07 -07:00

filer_server_handlers_write_upload.go

fix: multipart upload ETag calculation (#8238)

2026-02-06 21:54:43 -08:00

filer_server_handlers_write.go

Reduce memory allocations in hot paths (#7725)

2025-12-12 12:51:48 -08:00

filer_server_handlers.go

fix Filer startup failure due to JWT on / path #8149 (#8167)

2026-01-29 21:45:15 -08:00

filer_server_rocksdb.go

go fix

2026-02-20 18:42:00 -08:00

filer_server_tus_handlers.go

Add TUS protocol support for resumable uploads (#7592)

2025-12-14 21:56:07 -08:00

filer_server_tus_session.go

Add TUS protocol support for resumable uploads (#7592)

2025-12-14 21:56:07 -08:00

filer_server.go

Fix: filer not yet available in s3.configure (#8198)

2026-02-03 17:43:58 -08:00

integration_block_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

master_block_assignment_queue_test.go

feat: protocol-aware execution wave — phase gate for live WAL shipping

2026-04-05 23:47:07 -07:00

master_block_assignment_queue.go

feat: protocol-aware execution wave — phase gate for live WAL shipping

2026-04-05 23:47:07 -07:00

master_block_cluster_mode_test.go

test: Phase 20 Tier 1 component tests — wiring proof for CI/CD

2026-04-05 19:39:00 -07:00

master_block_evidence.go

fix: Phase 20 T3 — production wiring + fail-closed on partial evidence

2026-04-05 16:23:35 -07:00

master_block_failover_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

master_block_failover.go

fix: recover TOCTOU + WAL pressure edge case tests

2026-04-08 23:56:26 -07:00

master_block_observability_test.go

refactor: preserve bounded volume mode reason heartbeat truth

2026-04-04 14:21:31 -07:00

master_block_observability.go

feat: CP11B-4 observability pack — health state, alerts, dashboard

2026-03-23 02:12:42 -07:00

master_block_plan_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

master_block_plan.go

feat: CP11B-2 explainable placement / plan API

2026-03-23 02:12:25 -07:00

master_block_registry_test.go

fix: three hardware blockers — WAL retention + registry race + shutdown beat

2026-04-08 22:59:46 -07:00

master_block_registry.go

fix: three hardware blockers — WAL retention + registry race + shutdown beat

2026-04-08 22:59:46 -07:00

master_grpc_server_admin.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

master_grpc_server_assign.go

Fix Maintenance Task Sorting and Refactor Log Persistence (#8199)

2026-02-04 08:48:55 -08:00

master_grpc_server_block_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

master_grpc_server_block.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

master_grpc_server_cluster.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

master_grpc_server_collection.go

move to https://github.com/seaweedfs/seaweedfs

2022-07-29 00:17:28 -07:00

master_grpc_server_raft_test.go

Add cluster.raft.leader.transfer command for graceful leader change (#7819)

2025-12-19 00:15:39 -08:00

master_grpc_server_raft.go

fix: admin does not show all master servers #7999 (#8002)

2026-01-11 12:31:46 -08:00

master_grpc_server_volume.go

Fix imbalance detection disk type grouping and volume grow errors (#8097)

2026-01-23 12:25:11 -08:00

master_grpc_server.go

fix: recover TOCTOU + WAL pressure edge case tests

2026-04-08 23:56:26 -07:00

master_server_handlers_admin.go

fix: generate topology uuid uniformly in single-master mode (#8405)

2026-02-22 23:45:48 -08:00

master_server_handlers_block_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

master_server_handlers_block_ui.go

fix: Lookup/ListAll return copies, add UpdateEntry for safe mutation

2026-03-24 01:00:27 -07:00

master_server_handlers_block.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

master_server_handlers_ui.go

hide millseconds in up time (#7553)

2025-11-26 08:01:19 -08:00

master_server_handlers.go

add disable volume_growth flag (#7196)

2025-09-04 05:39:56 -07:00

master_server.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_assign_test.go

feat: Phase 4A CP4b-3 -- assignment processing, 2 bug fixes, 20 QA tests

2026-03-02 11:34:06 -08:00

qa_block_control_loop_adversarial_test.go

feat: Phase 10 — control-plane closure (identity, convergence, idempotence)

2026-04-02 16:25:43 -07:00

qa_block_control_loop_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_convergence_adversarial_test.go

feat: Phase 10 — control-plane closure (identity, convergence, idempotence)

2026-04-02 16:25:43 -07:00

qa_block_convergence_test.go

feat: Phase 15 + Phase 16A/B — V2 core integration + checkpoint review

2026-04-03 20:58:12 -07:00

qa_block_cp11b1_adversarial_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_cp11b2_adversarial_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_cp11b3_adversarial_test.go

feat: Phase 16M/17 + promote fixes + testrunner updates

2026-04-05 11:38:05 -07:00

qa_block_cp13_8a_test.go

fix: CP13-8A — fix malformed replica address in test allocator + add read proof

2026-04-03 11:47:41 -07:00

qa_block_cp13_9_mode_test.go

feat: CP13-9 — mode normalization for constrained V1 runtime

2026-04-03 15:02:50 -07:00

qa_block_cp62_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_cp63_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_cp82_adversarial_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_cp831_adversarial_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_csi_lifecycle_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_diagnosability_test.go

feat: Phase 12 P3+P4 — diagnosability surfaces, perf floor, rollout gates

2026-04-02 16:20:22 -07:00

qa_block_disturbance_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_durability_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_ec6_fix_test.go

feat: Phase 12 — production hardening (disturbance, soak, testrunner scenarios)

2026-04-02 16:26:17 -07:00

qa_block_edge_cases_test.go

fix: stable ServerID in assignments, fail-closed on missing identity, wire into ProcessAssignments

2026-03-31 10:46:17 -07:00

qa_block_expand_adversarial_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_ha_edge_cases_test.go

feat: Phase 12 — production hardening (disturbance, soak, testrunner scenarios)

2026-04-02 16:26:17 -07:00

qa_block_heartbeat_loop_test.go

feat: Phase 4A CP4b-3 -- assignment processing, 2 bug fixes, 20 QA tests

2026-03-02 11:34:06 -08:00

qa_block_idempotence_test.go

feat: Phase 15 + Phase 16A/B — V2 core integration + checkpoint review

2026-04-03 20:58:12 -07:00

qa_block_identity_test.go

feat: Phase 10 — control-plane closure (identity, convergence, idempotence)

2026-04-02 16:25:43 -07:00

qa_block_nvme_publication_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_perf_test.go

feat: Phase 12 P3+P4 — diagnosability surfaces, perf floor, rollout gates

2026-04-02 16:20:22 -07:00

qa_block_publication_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_restore_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_rf3_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_snapshot_product_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_soak_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

qa_block_v2bridge_test.go

fix: deliver assignment intent to real engine orchestrator, not discard

2026-03-31 13:38:30 -07:00

qa_failover_role_test.go

fix: registry role-aware failover + devops action + failover scenario update

2026-04-03 08:48:13 -07:00

qa_promote_rejoin_live_test.go

feat: Phase 16M/17 + promote fixes + testrunner updates

2026-04-05 11:38:05 -07:00

qa_promote_replication_test.go

feat: Phase 16M/17 + promote fixes + testrunner updates

2026-04-05 11:38:05 -07:00

raft_common.go

Prevent split-brain: Persistent ClusterID and Join Validation (#8022)

2026-01-18 14:02:34 -08:00

raft_hashicorp_test.go

Normalize hashicorp raft peer ids (#8253)

2026-02-09 07:46:34 -08:00

raft_hashicorp.go

Normalize hashicorp raft peer ids (#8253)

2026-02-09 07:46:34 -08:00

raft_server_handlers.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

raft_server.go

s3api: add AttachUserPolicy/DetachUserPolicy/ListAttachedUserPolicies (#8379)

2026-02-19 12:26:27 -08:00

volume_grpc_admin.go

Add a version token on RPCs to read/update volume server states. (#8191)

2026-02-06 10:58:43 -08:00

volume_grpc_batch_delete.go

Block RPC write operations on volume servers when maintenance mode is enabled (#8115)

2026-02-02 13:21:02 -08:00

volume_grpc_block_activation_gate_test.go

feat: protocol-aware execution wave — phase gate for live WAL shipping

2026-04-05 23:47:07 -07:00

volume_grpc_block_evidence_test.go

feat: Phase 20 T2 — promotion evidence semantics + selection substrate

2026-04-05 16:10:57 -07:00

volume_grpc_block_evidence.go

feat: Phase 20 T3 — durability-first V2 promotion in real failover path

2026-04-05 16:15:54 -07:00

volume_grpc_block_test.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

volume_grpc_block.go

feat: Phase 20 Stage 0+1 closure — bootstrap + sustained workload on hardware

2026-04-06 19:55:12 -07:00

volume_grpc_client_to_master.go

fix: three hardware blockers — WAL retention + registry race + shutdown beat

2026-04-08 22:59:46 -07:00

volume_grpc_copy_incremental.go

move to https://github.com/seaweedfs/seaweedfs

2022-07-29 00:17:28 -07:00

volume_grpc_copy.go

Fix live volume move tail timestamp (#8440)

2026-02-24 20:07:26 -08:00

volume_grpc_erasure_coding_test.go

iceberg: wire pagination for list namespaces/tables REST APIs (#8275)

2026-02-09 21:46:55 -08:00

volume_grpc_erasure_coding.go

Fix EC rebuild shard detection (#8265)

2026-02-09 12:34:38 -08:00

volume_grpc_query.go

move to https://github.com/seaweedfs/seaweedfs

2022-07-29 00:17:28 -07:00

volume_grpc_read_all.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00

volume_grpc_read_write.go

Block RPC write operations on volume servers when maintenance mode is enabled (#8115)

2026-02-02 13:21:02 -08:00

volume_grpc_remote.go

Block RPC write operations on volume servers when maintenance mode is enabled (#8115)

2026-02-02 13:21:02 -08:00

volume_grpc_scrub.go

Implement full scrubbing for EC volumes (#8318)

2026-02-16 15:09:01 -08:00

volume_grpc_state.go

Add a version token on RPCs to read/update volume server states. (#8191)

2026-02-06 10:58:43 -08:00

volume_grpc_tail.go

Block RPC write operations on volume servers when maintenance mode is enabled (#8115)

2026-02-02 13:21:02 -08:00

volume_grpc_tier_download.go

avoid load volume file with BytesOffset mismatch (#3841)

2022-10-14 00:18:09 -07:00

volume_grpc_tier_upload.go

Block RPC write operations on volume servers when maintenance mode is enabled (#8115)

2026-02-02 13:21:02 -08:00

volume_grpc_vacuum.go

Block RPC write operations on volume servers when maintenance mode is enabled (#8115)

2026-02-02 13:21:02 -08:00

volume_server_block_debug.go

feat: Phase 16M/17 + promote fixes + testrunner updates

2026-04-05 11:38:05 -07:00

volume_server_block_test.go

fix: proactive shipper reconnect on rejoin (Bug 5)

2026-04-09 00:14:46 -07:00

volume_server_block.go

feat: RemoteRebuildIO — primary coordinates rebuild, replica installs

2026-04-09 15:04:22 -07:00

volume_server_handlers_admin.go

fix: volume server healthz now checks local conditions only (#7610)

2025-12-02 23:19:14 -08:00

volume_server_handlers_helper.go

…

volume_server_handlers_read.go

fix: Use mime.FormatMediaType for RFC 6266 compliant Content-Disposition (#7635)

2025-12-05 15:59:12 -08:00

volume_server_handlers_ui.go

hide millseconds in up time (#7553)

2025-11-26 08:01:19 -08:00

volume_server_handlers_write.go

fix: multipart upload ETag calculation (#8238)

2026-02-06 21:54:43 -08:00

volume_server_handlers.go

fix: JWT validation failures during replication (#7788) (#7795)

2025-12-16 13:42:18 -08:00

volume_server_test.go

refactor: close bounded phase 16 restart truth seams

2026-04-04 16:13:06 -07:00

volume_server.go

fix: stable ServerID in assignments, fail-closed on missing identity, wire into ProcessAssignments

2026-03-31 10:46:17 -07:00

webdav_server.go

mount: improve read throughput with parallel chunk fetching (#7569)

2025-11-29 10:06:11 -08:00

wrapped_webdav_fs.go

chore: execute goimports to format the code (#7983)

2026-01-07 13:06:08 -08:00