mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-19 21:56:54 +00:00
Ping previously dialled whatever host:port the caller asked for. Gate each server's Ping handler on cluster membership: masters check the topology, registered cluster nodes, and configured master peers; volume servers only accept their seed/current masters; filers accept tracked peer filers, the master-learned volume server set, and configured masters. Use address-indexed peer lookups to keep Ping target validation O(1): - topology maintains a pb.ServerAddress -> *DataNode index alongside the dc/rack/node tree, kept in sync from doLinkChildNode and UnlinkChildNode plus the ip/port-rewrite branch in GetOrCreateDataNode. GetTopology now returns nil on a detached subtree instead of panicking, so the linkage hooks can no-op safely. - vid_map tracks a refcount per volume-server address so hasVolumeServer answers without scanning every vid location. The add path skips empty-address entries the same way the delete path already does, so a zero-value Location cannot leak a permanent serverRefCount[""] bucket. - masters reuse a cached master-address set from MasterClient instead of walking the configured peer slice on every request. - volume servers compare against a pre-built seed-master set and protect currentMaster reads/writes with an RWMutex, fixing the data race with the heartbeat goroutine. The seed slice is copied on construction so external mutation cannot desync it from the frozen lookup set. - cluster.check drops the direct volume-to-volume sweep; volume servers no longer carry a peer-volume list, and the note next to the dropped probe is reworded to make clear that direct volume-to-volume reachability is intentionally not validated by this command. Update the volume-server integration tests that drove Ping through the new admission gate: success-path coverage now targets the master peer (the only type a volume server tracks), and the unknown/unreachable path asserts the InvalidArgument the gate now returns instead of the old downstream dial error. Mirror the same admission gate in the Rust volume server crate: a seed-master HashSet built once at startup plus a tokio RwLock over the heartbeat-tracked current master, both consulted in is_known_ping_target on every Ping, with InvalidArgument returned for any target that isn't a recognised master.
167 lines
4.5 KiB
Go
167 lines
4.5 KiB
Go
package wdclient
|
|
|
|
import (
|
|
"context"
|
|
"strconv"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"google.golang.org/grpc"
|
|
)
|
|
|
|
func TestLookupFileId(t *testing.T) {
|
|
mc := NewMasterClient(grpc.EmptyDialOption{}, "", "", "", "", "", pb.ServerDiscovery{})
|
|
length := 5
|
|
|
|
//Construct a cache linked list of length 5
|
|
for i := 0; i < length; i++ {
|
|
mc.addLocation(uint32(i), Location{Url: strconv.FormatInt(int64(i), 10)})
|
|
mc.resetVidMap()
|
|
}
|
|
for i := 0; i < length; i++ {
|
|
locations, found := mc.GetLocations(uint32(i))
|
|
if !found || len(locations) != 1 || locations[0].Url != strconv.FormatInt(int64(i), 10) {
|
|
t.Fatalf("urls of vid=%d is not valid.", i)
|
|
}
|
|
}
|
|
|
|
//When continue to add nodes to the linked list, the previous node will be deleted, and the cache of the response will be gone.
|
|
for i := length; i < length+5; i++ {
|
|
mc.addLocation(uint32(i), Location{Url: strconv.FormatInt(int64(i), 10)})
|
|
mc.resetVidMap()
|
|
}
|
|
for i := 0; i < length; i++ {
|
|
locations, found := mc.GetLocations(uint32(i))
|
|
if found {
|
|
t.Fatalf("urls of vid[%d] should not exists, but found: %v", i, locations)
|
|
}
|
|
}
|
|
|
|
//The delete operation will be applied to all cache nodes
|
|
_, found := mc.GetLocations(uint32(length))
|
|
if !found {
|
|
t.Fatalf("urls of vid[%d] not found", length)
|
|
}
|
|
|
|
//If the locations of the current node exist, return directly
|
|
newUrl := "abc"
|
|
mc.addLocation(uint32(length), Location{Url: newUrl})
|
|
locations, found := mc.GetLocations(uint32(length))
|
|
if !found || locations[0].Url != newUrl {
|
|
t.Fatalf("urls of vid[%d] not found", length)
|
|
}
|
|
|
|
//After delete `abc`, cache nodes are searched
|
|
deleteLoc := Location{Url: newUrl}
|
|
mc.deleteLocation(uint32(length), deleteLoc)
|
|
locations, found = mc.GetLocations(uint32(length))
|
|
if found && locations[0].Url != strconv.FormatInt(int64(length), 10) {
|
|
t.Fatalf("urls of vid[%d] not expected", length)
|
|
}
|
|
|
|
//lock: concurrent test
|
|
var wg sync.WaitGroup
|
|
for i := 0; i < 20; i++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
for i := 0; i < 100; i++ {
|
|
for i := 0; i < 20; i++ {
|
|
_, _ = mc.GetLocations(uint32(i))
|
|
}
|
|
}
|
|
}()
|
|
}
|
|
|
|
for i := 0; i < 100; i++ {
|
|
mc.addLocation(uint32(i), Location{})
|
|
}
|
|
wg.Wait()
|
|
}
|
|
|
|
func TestConcurrentGetLocations(t *testing.T) {
|
|
mc := NewMasterClient(grpc.EmptyDialOption{}, "", "", "", "", "", pb.ServerDiscovery{})
|
|
location := Location{Url: "TestDataRacing"}
|
|
mc.addLocation(1, location)
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
wg := sync.WaitGroup{}
|
|
for i := 0; i < 50; i++ {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return
|
|
default:
|
|
_, found := mc.GetLocations(1)
|
|
if !found {
|
|
cancel()
|
|
t.Error("vid map invalid due to data racing. ")
|
|
return
|
|
}
|
|
}
|
|
}
|
|
}()
|
|
}
|
|
|
|
//Simulate vidmap reset with cache when leader changes
|
|
for i := 0; i < 100; i++ {
|
|
mc.resetVidMap()
|
|
mc.addLocation(1, location)
|
|
time.Sleep(1 * time.Microsecond)
|
|
}
|
|
cancel()
|
|
wg.Wait()
|
|
}
|
|
|
|
func TestHasVolumeServer(t *testing.T) {
|
|
mc := NewMasterClient(grpc.EmptyDialOption{}, "", "", "", "", "", pb.ServerDiscovery{})
|
|
|
|
regular := Location{Url: "10.0.0.1:8080", GrpcPort: 18080}
|
|
ecOnly := Location{Url: "10.0.0.2:8080", GrpcPort: 18080}
|
|
|
|
mc.addLocation(7, regular)
|
|
mc.addEcLocation(9, ecOnly)
|
|
|
|
addr := func(u string) pb.ServerAddress { return pb.ServerAddress(u) }
|
|
|
|
if !mc.HasVolumeServer(addr("10.0.0.1:8080")) {
|
|
t.Fatalf("regular volume server must be known by http address")
|
|
}
|
|
if !mc.HasVolumeServer(addr("10.0.0.1:8080.18080")) {
|
|
t.Fatalf("regular volume server must be known by grpc-suffix address")
|
|
}
|
|
if !mc.HasVolumeServer(addr("10.0.0.2:8080")) {
|
|
t.Fatalf("ec-only volume server must be known")
|
|
}
|
|
if mc.HasVolumeServer(addr("127.0.0.1:1")) {
|
|
t.Fatalf("unknown address must not be known")
|
|
}
|
|
|
|
// Adding the same location twice must not double-count:
|
|
// deleting once should evict the server.
|
|
mc.addLocation(7, regular)
|
|
mc.deleteLocation(7, regular)
|
|
if mc.HasVolumeServer(addr("10.0.0.1:8080")) {
|
|
t.Fatalf("server should be evicted after deleteLocation")
|
|
}
|
|
|
|
// Removing the EC entry must also drop the index entry.
|
|
mc.deleteEcLocation(9, ecOnly)
|
|
if mc.HasVolumeServer(addr("10.0.0.2:8080")) {
|
|
t.Fatalf("server should be evicted after deleteEcLocation")
|
|
}
|
|
|
|
// deleteVid removes every reference held by that vid in one call.
|
|
mc.addLocation(11, regular)
|
|
mc.addEcLocation(11, regular)
|
|
mc.InvalidateCache("11,abc")
|
|
if mc.HasVolumeServer(addr("10.0.0.1:8080")) {
|
|
t.Fatalf("server should be evicted after InvalidateCache")
|
|
}
|
|
}
|