mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-01 04:05:54 +00:00
* shell: say which read-only volumes volume.vacuum leaves alone volume.vacuum without -volumeId runs the same sweep as the automatic vacuum, which skips read-only volumes, and the master's response carries no result. An operator whose disk filled up runs the command, sees it return, and watches nothing change (issue #11516). Before issuing the request, list the read-only volumes whose garbage is at or above the threshold and point at -volumeId, which is the explicit path PR #9861 opened for them. The help text says the same. * shell: volume.vacuum hint survives a failed listing and looks at every replica Review follow-ups: a failed topology listing no longer stops a sweep without -volumeId, it only drops the hint; a volume counts as read-only when any replica is, with the garbage ratio taken from the replica that reports the most, which is what the sweep itself does; a converted index that reports deletes without sizes is listed rather than hidden; and the threshold is printed as given instead of rounded to two decimals. * shell: do not guess a garbage ratio for a converted index The master cannot compute one for a volume that reports deletes without their sizes, and a guess of 1 would send the operator to -volumeId for a volume the server may decline at that threshold. Leave it out and say so.
171 lines
5.5 KiB
Go
171 lines
5.5 KiB
Go
package shell
|
|
|
|
import (
|
|
"context"
|
|
"flag"
|
|
"fmt"
|
|
"io"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
)
|
|
|
|
func init() {
|
|
Commands = append(Commands, &commandVacuum{})
|
|
}
|
|
|
|
type commandVacuum struct {
|
|
}
|
|
|
|
func (c *commandVacuum) Name() string {
|
|
return "volume.vacuum"
|
|
}
|
|
|
|
func (c *commandVacuum) Help() string {
|
|
return `compact volumes if deleted entries are more than the limit
|
|
|
|
volume.vacuum [-garbageThreshold=0.3] [-collection=<collection name>] [-volumeId=<volume id>]
|
|
|
|
Without -volumeId this runs the same sweep as the automatic vacuum, which skips
|
|
read-only volumes. Name a read-only volume with -volumeId to vacuum it anyway.
|
|
|
|
`
|
|
}
|
|
|
|
func (c *commandVacuum) HasTag(CommandTag) bool {
|
|
return false
|
|
}
|
|
|
|
func (c *commandVacuum) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
|
|
|
|
volumeVacuumCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
|
|
garbageThreshold := volumeVacuumCommand.Float64("garbageThreshold", 0.3, "vacuum when garbage is more than this limit")
|
|
collection := volumeVacuumCommand.String("collection", "", "vacuum this collection")
|
|
volumeIds := volumeVacuumCommand.String("volumeId", "", "comma-separated list of volume IDs")
|
|
if err = volumeVacuumCommand.Parse(args); err != nil {
|
|
return nil
|
|
}
|
|
|
|
if err = commandEnv.confirmIsLocked(args); err != nil {
|
|
return
|
|
}
|
|
|
|
var volumeIdInts []uint32
|
|
if *volumeIds != "" {
|
|
for _, volumeIdStr := range strings.Split(*volumeIds, ",") {
|
|
volumeIdStr = strings.TrimSpace(volumeIdStr)
|
|
if volumeIdInt, err := strconv.ParseUint(volumeIdStr, 10, 32); err == nil {
|
|
volumeIdInts = append(volumeIdInts, uint32(volumeIdInt))
|
|
} else {
|
|
return fmt.Errorf("parse volumeId string %s to int: %v", volumeIdStr, err)
|
|
}
|
|
}
|
|
} else {
|
|
volumeIdInts = append(volumeIdInts, 0)
|
|
}
|
|
|
|
topo, _, err := collectTopologyInfo(commandEnv, 0)
|
|
if err != nil {
|
|
if *volumeIds != "" {
|
|
return fmt.Errorf("collect topology: %w", err)
|
|
}
|
|
// The hint below is a courtesy; a sweep must not depend on it.
|
|
fmt.Fprintf(writer, "could not list volumes to check for read-only ones: %v\n", err)
|
|
}
|
|
|
|
// Reject unknown ids up front. The master's VacuumVolume RPC silently
|
|
// iterates matching volumes, so a typo or an already-deleted volume just
|
|
// returns success — making this command look like it worked when nothing
|
|
// happened.
|
|
if *volumeIds != "" {
|
|
known := make(map[uint32]bool)
|
|
eachDataNode(topo, func(_ DataCenterId, _ RackId, dn *master_pb.DataNodeInfo) {
|
|
for _, disk := range dn.DiskInfos {
|
|
for _, vi := range disk.VolumeInfos {
|
|
known[vi.Id] = true
|
|
}
|
|
}
|
|
})
|
|
// Dedupe via a set so "volume.vacuum -volumeId 5,5,5" on a missing
|
|
// volume 5 reports [5] once instead of [5 5 5].
|
|
missingSet := make(map[uint32]bool)
|
|
for _, vid := range volumeIdInts {
|
|
if !known[vid] {
|
|
missingSet[vid] = true
|
|
}
|
|
}
|
|
if len(missingSet) > 0 {
|
|
missing := make([]uint32, 0, len(missingSet))
|
|
for vid := range missingSet {
|
|
missing = append(missing, vid)
|
|
}
|
|
sort.Slice(missing, func(i, j int) bool { return missing[i] < missing[j] })
|
|
return fmt.Errorf("volume(s) not found on master: %v", missing)
|
|
}
|
|
} else if topo != nil {
|
|
// The sweep says nothing about the volumes it leaves alone, so an
|
|
// operator on a full disk sees the command return and nothing change.
|
|
if skipped := readOnlyVolumesAboveThreshold(topo, *collection, *garbageThreshold); len(skipped) > 0 {
|
|
fmt.Fprintf(writer, "%d read-only volume(s) hold garbage above %g and are skipped by the sweep: %v\n", len(skipped), *garbageThreshold, skipped)
|
|
fmt.Fprintf(writer, "vacuum them explicitly with -volumeId\n")
|
|
}
|
|
}
|
|
|
|
for _, volumeId := range volumeIdInts {
|
|
err = commandEnv.MasterClient.WithClient(context.Background(), false, func(client master_pb.SeaweedClient) error {
|
|
_, err = client.VacuumVolume(context.Background(), &master_pb.VacuumVolumeRequest{
|
|
GarbageThreshold: float32(*garbageThreshold),
|
|
VolumeId: volumeId,
|
|
Collection: *collection,
|
|
})
|
|
return err
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// readOnlyVolumesAboveThreshold lists the volumes a sweep leaves alone: any
|
|
// replica read-only (that is what the sweep checks), in the collection when one
|
|
// is given, and some replica with a garbage ratio at or above the threshold.
|
|
// The ratio uses the sizes the master reports, which is deleted bytes over the
|
|
// .dat size rather than over the content size the volume server divides by, so
|
|
// it can only understate, and a converted index that reports deletes without
|
|
// their sizes is left out because its ratio is not knowable here. This is a
|
|
// hint; the volume server's own check decides.
|
|
func readOnlyVolumesAboveThreshold(topo *master_pb.TopologyInfo, collection string, garbageThreshold float64) []uint32 {
|
|
readOnly := make(map[uint32]bool)
|
|
garbage := make(map[uint32]float64) // the highest ratio any replica reports
|
|
eachDataNode(topo, func(_ DataCenterId, _ RackId, dn *master_pb.DataNodeInfo) {
|
|
for _, disk := range dn.DiskInfos {
|
|
for _, v := range disk.VolumeInfos {
|
|
if collection != "" && v.Collection != collection {
|
|
continue
|
|
}
|
|
if v.ReadOnly {
|
|
readOnly[v.Id] = true
|
|
}
|
|
if v.Size == 0 {
|
|
continue
|
|
}
|
|
if ratio := float64(v.DeletedByteCount) / float64(v.Size); ratio > garbage[v.Id] {
|
|
garbage[v.Id] = ratio
|
|
}
|
|
}
|
|
}
|
|
})
|
|
vids := make([]uint32, 0, len(readOnly))
|
|
for vid := range readOnly {
|
|
if garbage[vid] >= garbageThreshold {
|
|
vids = append(vids, vid)
|
|
}
|
|
}
|
|
sort.Slice(vids, func(i, j int) bool { return vids[i] < vids[j] })
|
|
return vids
|
|
}
|