mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-27 10:24:16 +00:00
* fix 11400 * persist failed-recovery quarantine and harden rollback - record the unavailable state in a .unavailable marker, fsync it, and re-arm it on load so a restart cannot serve an unverified pair - quarantine the volume so heartbeats stop advertising it - block MarkVolumeWritable while unavailable, rechecked under noWriteLock - fail every request of a failed batch, not only the succeeded ones - restore the needle map and truncate .dat on inline fsync rollback failure - add truncateIndex for the sorted-file needle map - mirror the fail-closed semantics in the Rust volume server * volume: erase rolled-back mappings instead of leaving tombstones A rolled-back batch or failed inline write used Delete() to undo a needle that did not exist beforehand, leaving a tombstoned map entry whose stale offset makes the next write to that needle fail reading a header that no longer exists. Add removeMapping/restoreMapping to the mappers so recovery erases entries that were absent before the batch and reinstates the exact prior offset/size for ones that were, including tombstones. The index row still goes through Delete so a replay forgets the needle. * volume: gate bulk readers on unavailable and fsync the marker's dir - fsync_dir(&self.dir) synced the volume dir's parent, not the dir holding .unavailable; pass the marker path so the create survives a host crash - export UnavailableError and check it in ReadAllNeedles, VolumeTailSender, VolumeIncrementalCopy, and IncrementalBackup so replica-sync paths cannot stream or append data from an unverified .dat/.idx pair; mirror on the Rust side via read_dat_slice, read_all_needles, dat_scan_plan, and the incremental-copy handler * volume: drop issue references from comments near touched code * volume: stop active scans when the volume becomes unavailable The stream entry-point checks ran once per RPC, so a volume quarantined by a failed recovery mid-scan kept serving data. Recheck availability per needle/chunk on the detached read paths: tail scan and heartbeat, read-all, incremental copy, incremental backup writes, and the Rust StreamingBody chunk reads. Rust incremental copy also rejects a quarantined volume before sync_to_disk touches the backend. --------- Co-authored-by: Chris Lu <chris.lu@gmail.com>
164 lines
4.9 KiB
Go
164 lines
4.9 KiB
Go
package weed_server
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/operation"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/volume_server_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
)
|
|
|
|
func (vs *VolumeServer) VolumeTailSender(req *volume_server_pb.VolumeTailSenderRequest, stream volume_server_pb.VolumeServer_VolumeTailSenderServer) error {
|
|
v := vs.store.GetVolume(needle.VolumeId(req.VolumeId))
|
|
if v == nil {
|
|
return fmt.Errorf("not found volume id %d", req.VolumeId)
|
|
}
|
|
if err := v.UnavailableError(); err != nil {
|
|
return err
|
|
}
|
|
|
|
defer glog.V(1).Infof("tailing volume %d finished", v.Id)
|
|
|
|
lastTimestampNs := req.SinceNs
|
|
drainingSeconds := req.IdleTimeoutSeconds
|
|
|
|
for {
|
|
if err := v.UnavailableError(); err != nil {
|
|
return err
|
|
}
|
|
lastProcessedTimestampNs, err := sendNeedlesSince(stream, v, lastTimestampNs)
|
|
if err != nil {
|
|
glog.Infof("sendNeedlesSince: %v", err)
|
|
return fmt.Errorf("streamFollow: %w", err)
|
|
}
|
|
time.Sleep(2 * time.Second)
|
|
|
|
if req.IdleTimeoutSeconds == 0 {
|
|
lastTimestampNs = lastProcessedTimestampNs
|
|
continue
|
|
}
|
|
if lastProcessedTimestampNs == lastTimestampNs {
|
|
drainingSeconds--
|
|
if drainingSeconds <= 0 {
|
|
return nil
|
|
}
|
|
glog.V(1).Infof("tailing volume %d drains requests with %d seconds remaining", v.Id, drainingSeconds)
|
|
} else {
|
|
lastTimestampNs = lastProcessedTimestampNs
|
|
drainingSeconds = req.IdleTimeoutSeconds
|
|
glog.V(1).Infof("tailing volume %d resets draining wait time to %d seconds", v.Id, drainingSeconds)
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
func sendNeedlesSince(stream volume_server_pb.VolumeServer_VolumeTailSenderServer, v *storage.Volume, lastTimestampNs uint64) (lastProcessedTimestampNs uint64, err error) {
|
|
|
|
foundOffset, isLastOne, err := v.BinarySearchByAppendAtNs(lastTimestampNs)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("fail to locate by appendAtNs %d: %s", lastTimestampNs, err)
|
|
}
|
|
|
|
// log.Printf("reading ts %d offset %d isLast %v", lastTimestampNs, foundOffset, isLastOne)
|
|
|
|
if isLastOne {
|
|
if err := v.UnavailableError(); err != nil {
|
|
return 0, err
|
|
}
|
|
// need to heart beat to the client to ensure the connection health
|
|
sendErr := stream.Send(&volume_server_pb.VolumeTailSenderResponse{IsLastChunk: true, Version: uint32(v.Version())})
|
|
return lastTimestampNs, sendErr
|
|
}
|
|
|
|
scanner := &VolumeFileScanner4Tailing{
|
|
stream: stream,
|
|
version: uint32(v.Version()),
|
|
v: v,
|
|
}
|
|
|
|
err = storage.ScanVolumeFileFrom(v.Version(), v.DataBackend, foundOffset.ToActualOffset(), scanner)
|
|
|
|
return scanner.lastProcessedTimestampNs, err
|
|
|
|
}
|
|
|
|
func (vs *VolumeServer) VolumeTailReceiver(ctx context.Context, req *volume_server_pb.VolumeTailReceiverRequest) (*volume_server_pb.VolumeTailReceiverResponse, error) {
|
|
if err := vs.checkGrpcAdminAuth(ctx); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
resp := &volume_server_pb.VolumeTailReceiverResponse{}
|
|
|
|
if !vs.AllowUntrustedRemoteEndpoints {
|
|
if err := validateReplicaTarget(ctx, req.SourceVolumeServer); err != nil {
|
|
return resp, fmt.Errorf("invalid source volume server %s: %w", req.SourceVolumeServer, err)
|
|
}
|
|
}
|
|
|
|
v := vs.store.GetVolume(needle.VolumeId(req.VolumeId))
|
|
if v == nil {
|
|
return resp, fmt.Errorf("receiver not found volume id %d", req.VolumeId)
|
|
}
|
|
|
|
defer glog.V(1).Infof("receive tailing volume %d finished", v.Id)
|
|
|
|
return resp, operation.TailVolumeFromSource(pb.ServerAddress(req.SourceVolumeServer), v.Id, req.SinceNs, int(req.IdleTimeoutSeconds), func(n *needle.Needle) error {
|
|
_, err := vs.store.WriteVolumeNeedle(v.Id, n, false, false)
|
|
return err
|
|
}, vs.grpcDialOption, vs.guardedGrpcDialOption(req.SourceVolumeServer))
|
|
|
|
}
|
|
|
|
// generate the volume idx
|
|
type VolumeFileScanner4Tailing struct {
|
|
stream volume_server_pb.VolumeServer_VolumeTailSenderServer
|
|
lastProcessedTimestampNs uint64
|
|
version uint32
|
|
v *storage.Volume
|
|
}
|
|
|
|
func (scanner *VolumeFileScanner4Tailing) VisitSuperBlock(superBlock super_block.SuperBlock) error {
|
|
return nil
|
|
|
|
}
|
|
func (scanner *VolumeFileScanner4Tailing) ReadNeedleBody() bool {
|
|
return true
|
|
}
|
|
|
|
func (scanner *VolumeFileScanner4Tailing) VisitNeedle(n *needle.Needle, offset int64, needleHeader, needleBody []byte) error {
|
|
if err := scanner.v.UnavailableError(); err != nil {
|
|
return err
|
|
}
|
|
isLastChunk := false
|
|
|
|
// need to send body by chunks
|
|
for i := 0; i < len(needleBody); i += BufferSizeLimit {
|
|
stopOffset := i + BufferSizeLimit
|
|
if stopOffset >= len(needleBody) {
|
|
isLastChunk = true
|
|
stopOffset = len(needleBody)
|
|
}
|
|
|
|
sendErr := scanner.stream.Send(&volume_server_pb.VolumeTailSenderResponse{
|
|
NeedleHeader: needleHeader,
|
|
NeedleBody: needleBody[i:stopOffset],
|
|
IsLastChunk: isLastChunk,
|
|
Version: scanner.version,
|
|
})
|
|
if sendErr != nil {
|
|
return sendErr
|
|
}
|
|
}
|
|
|
|
scanner.lastProcessedTimestampNs = n.AppendAtNs
|
|
return nil
|
|
}
|