mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-21 14:46:58 +00:00
Chris LuandGitHub
a24f4844d3
* mysql: keep S3 list order byte-lexicographic regardless of name column collation ORDER BY name and the name > ? pagination predicate follow the column collation, so a case-insensitive filemeta.name (e.g. utf8mb3_general_ci) returns S3 keys out of byte order and breaks clients that merge two sorted listings. Detect the live name collation at startup; only when it isn't binary, wrap the list comparison, prefix, and ORDER BY in BINARY name so order and pagination stay consistent. Correctly configured utf8mb4_bin tables keep their indexed range scan unchanged, and the operator gets a warning to convert the column. * postgres: keep S3 list order byte-lexicographic regardless of name column collation ORDER BY name and the name > $n pagination predicate follow the column or database collation, so a locale-aware filemeta.name (e.g. the en_US.UTF-8 database default) returns S3 keys out of byte order and breaks clients that merge two sorted listings. Detect the live name collation at startup; only when it isn't byte-ordered, wrap the list comparison, prefix, and ORDER BY in COLLATE "C" so order and pagination stay consistent. A byte-ordered (C/POSIX/C.UTF-8) column keeps its indexed range scan unchanged, and the operator gets a warning to declare the column COLLATE "C".
71 lines
2.3 KiB
Go
71 lines
2.3 KiB
Go
package mysql
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestDefaultUpsertQueryUsesOnDuplicateKey(t *testing.T) {
|
|
gen := &SqlGenMysql{UpsertQueryTemplate: DefaultUpsertQuery}
|
|
got := gen.GetSqlInsert("filemeta")
|
|
if !strings.Contains(got, "ON DUPLICATE KEY UPDATE") {
|
|
t.Fatalf("expected ON DUPLICATE KEY UPDATE in default upsert, got: %s", got)
|
|
}
|
|
if strings.Contains(got, "AS `new`") {
|
|
t.Fatalf("default should avoid MySQL 8.0.19 row-alias syntax for MariaDB compat, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "`filemeta`") {
|
|
t.Fatalf("expected backticked table name, got: %s", got)
|
|
}
|
|
}
|
|
|
|
func TestEmptyUpsertTemplateFallsBackToPlainInsert(t *testing.T) {
|
|
gen := &SqlGenMysql{}
|
|
got := gen.GetSqlInsert("filemeta")
|
|
if strings.Contains(got, "ON DUPLICATE KEY UPDATE") {
|
|
t.Fatalf("plain INSERT path should not contain ON DUPLICATE KEY UPDATE, got: %s", got)
|
|
}
|
|
}
|
|
|
|
func TestListSqlDefaultOrderingFollowsColumn(t *testing.T) {
|
|
gen := &SqlGenMysql{}
|
|
for _, got := range []string{gen.GetSqlListExclusive("filemeta"), gen.GetSqlListInclusive("filemeta")} {
|
|
if strings.Contains(got, "BINARY") {
|
|
t.Fatalf("default list query should not force BINARY, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "ORDER BY `name` ASC") {
|
|
t.Fatalf("expected plain name ordering, got: %s", got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestListSqlBinaryOrderingOnNonBinaryColumn(t *testing.T) {
|
|
gen := &SqlGenMysql{ForceBinaryCollation: true}
|
|
for _, got := range []string{gen.GetSqlListExclusive("filemeta"), gen.GetSqlListInclusive("filemeta")} {
|
|
if !strings.Contains(got, "ORDER BY BINARY `name` ASC") {
|
|
t.Fatalf("expected BINARY ordering, got: %s", got)
|
|
}
|
|
if !strings.Contains(got, "BINARY `name` LIKE ?") {
|
|
t.Fatalf("expected BINARY prefix filter, got: %s", got)
|
|
}
|
|
if strings.Contains(got, "AND `name` > ?") || strings.Contains(got, "AND `name` >= ?") {
|
|
t.Fatalf("pagination comparison must also be BINARY, got: %s", got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIsBinaryCollation(t *testing.T) {
|
|
binary := []string{"", "binary", "utf8mb4_bin", "utf8mb3_bin", "latin1_bin", "UTF8MB4_BIN"}
|
|
for _, c := range binary {
|
|
if !isBinaryCollation(c) {
|
|
t.Fatalf("expected %q to be treated as binary", c)
|
|
}
|
|
}
|
|
ci := []string{"utf8mb4_general_ci", "utf8mb3_general_ci", "utf8mb4_0900_ai_ci", "latin1_swedish_ci"}
|
|
for _, c := range ci {
|
|
if isBinaryCollation(c) {
|
|
t.Fatalf("expected %q to be treated as non-binary", c)
|
|
}
|
|
}
|
|
}
|