mirrors/stfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat; Add tests for symlink behaviour of mkdirAll and prevent creating directories on file paths

Browse Source
This commit is contained in:
Felicitas Pojtinger
2022-01-21 02:35:48 +01:00
parent 259db51d9e
commit d5557ebf9c
2 changed files with 143 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
pkg/fs/filesystem.go
View File

@@ -349,7 +349,7 @@ func (f *STFS) MkdirAll(path string, perm os.FileMode) error {
currentPath = filepath.Join(currentPath, part)
}
if _, err := inventory.Stat(
if hdr, err := inventory.Stat(
f.metadata,
currentPath,
@@ -358,12 +358,29 @@ func (f *STFS) MkdirAll(path string, perm os.FileMode) error {
f.onHeader,
); err != nil {
if err == sql.ErrNoRows {
if err := f.mknodeWithoutLocking(true, currentPath, perm, false, "", false); err != nil {
return err
if hdr, err := inventory.Stat(
f.metadata,
currentPath,
true,
f.onHeader,
); err != nil {
if err == sql.ErrNoRows {
if err := f.mknodeWithoutLocking(true, currentPath, perm, false, "", false); err != nil {
return err
}
} else {
return err
}
} else if hdr.Typeflag != tar.TypeDir {
return config.ErrIsFile
}
} else {
return err
}
} else if hdr.Typeflag != tar.TypeDir {
return config.ErrIsFile
}
}