mirrors/tar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

maint: avoid -Wstringop-truncation warnings from upcoming GCC8

Browse Source 
* src/create.c (start_private_header, start_header): Convert
trivial uses of strncpy to memcpy, to avoid warnings like this:
In function 'strncpy',
    inlined from 'start_private_header' at create.c:522:3:
/usr/include/bits/string_fortified.h:106:10: warning: \
  '__builtin_strncpy' output truncated before terminating nul \
  copying 2 bytes from a string of the same length \
  [-Wstringop-truncation]
This commit is contained in:
Jim Meyering
2018-03-18 21:32:19 -07:00
committed by Sergey Poznyakoff
parent 2baa531ce5
commit 0a0242582f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/create.c
View File

@@ -518,8 +518,8 @@ start_private_header (const char *name, size_t size, time_t t)
MODE_TO_CHARS (S_IFREG|S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH, header->header.mode);
UID_TO_CHARS (0, header->header.uid);
GID_TO_CHARS (0, header->header.gid);
strncpy (header->header.magic, TMAGIC, TMAGLEN);
strncpy (header->header.version, TVERSION, TVERSLEN);
memcpy (header->header.magic, TMAGIC, TMAGLEN);
memcpy (header->header.version, TVERSION, TVERSLEN);
return header;
}
@@ -917,8 +917,8 @@ start_header (struct tar_stat_info *st)
case POSIX_FORMAT:
case USTAR_FORMAT:
strncpy (header->header.magic, TMAGIC, TMAGLEN);
strncpy (header->header.version, TVERSION, TVERSLEN);
memcpy (header->header.magic, TMAGIC, TMAGLEN);
memcpy (header->header.version, TVERSION, TVERSLEN);
break;
default: