Fix extraction from concatenated incremental archives.

* src/common.h (remove_delayed_set_stat): New proto.
* src/extract.c (free_delayed_set_stat)
(remove_delayed_set_stat): New function.
(apply_nonancestor_delayed_set_stat): Use free_delayed_set_stat.
* src/misc.c (safer_rmdir): Remove delayed_set_stat entry
corresponding to the removed directory.
* tests/incr10.at: New test case.
* tests/Makefile.am: Add new test.
* tests/testsuite.at: Likewise.
This commit is contained in:
Sergey Poznyakoff
2015-04-16 13:02:10 +03:00
parent 0c4aa85e6c
commit 15c02c2b9d
6 changed files with 107 additions and 6 deletions
+2
View File
@@ -523,6 +523,8 @@ void extract_archive (void);
void extract_finish (void);
bool rename_directory (char *src, char *dst);
void remove_delayed_set_stat (const char *fname);
/* Module delete.c. */
void delete_archive_members (void);
+33 -5
View File
@@ -537,6 +537,38 @@ repair_delayed_set_stat (char const *dir,
quotearg_colon (dir)));
}
static void
free_delayed_set_stat (struct delayed_set_stat *data)
{
xheader_xattr_free (data->xattr_map, data->xattr_map_size);
free (data->cntx_name);
free (data->acls_a_ptr);
free (data->acls_d_ptr);
free (data);
}
void
remove_delayed_set_stat (const char *fname)
{
struct delayed_set_stat *data, *next, *prev = NULL;
for (data = delayed_set_stat_head; data; data = next)
{
next = data->next;
if (chdir_current == data->change_dir
&& strcmp (data->file_name, fname) == 0)
{
free_delayed_set_stat (data);
if (prev)
prev->next = next;
else
delayed_set_stat_head = next;
return;
}
else
prev = data;
}
}
/* After a file/link/directory creation has failed, see if
it's because some required directory was not present, and if so,
create all required directories. Return zero if all the required
@@ -846,11 +878,7 @@ apply_nonancestor_delayed_set_stat (char const *file_name, bool after_links)
}
delayed_set_stat_head = data->next;
xheader_xattr_free (data->xattr_map, data->xattr_map_size);
free (data->cntx_name);
free (data->acls_a_ptr);
free (data->acls_d_ptr);
free (data);
free_delayed_set_stat (data);
}
}
+6 -1
View File
@@ -586,7 +586,12 @@ safer_rmdir (const char *file_name)
return -1;
}
return unlinkat (chdir_fd, file_name, AT_REMOVEDIR);
if (unlinkat (chdir_fd, file_name, AT_REMOVEDIR) == 0)
{
remove_delayed_set_stat (file_name);
return 0;
}
return -1;
}
/* Remove FILE_NAME, returning 1 on success. If FILE_NAME is a directory,