mirrors/tar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Port short_read to UBSan

Browse Source 
Problem reported by Kirill Furman in:
https://lists.gnu.org/r/bug-tar/2025-06/msg00002.html
* src/buffer.c (short_read): Use (char *) record_start,
instead of record_start->buffer, to avoid undefined behavior
accessing past end of buffer.  In practice the undefined
behavior is harmless unless running with -fsanitize=undefined
or a similarly-picky implementation.
This commit is contained in:
Paul Eggert
2025-06-12 00:20:52 -07:00
parent 7c4f8fb579
commit 7d96e820a5
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
THANKS
View File

@@ -308,6 +308,7 @@ Kevin D Quitt drs@netcom.com
Kevin Dalley kevin@aimnet.com Kevin Dalley kevin@aimnet.com
Kimball Collins kpc@ptolemy.arc.nasa.gov Kimball Collins kpc@ptolemy.arc.nasa.gov
Kimmy Posey kimmyd@bnr.ca Kimmy Posey kimmyd@bnr.ca
Kirill Furman kfurman@astralinux.ru
Koji Kishi kis@rqa.sony.co.jp Koji Kishi kis@rqa.sony.co.jp
Konno Hiroharu konno@pac.co.jp Konno Hiroharu konno@pac.co.jp
Kurt Jaeger pi@lf.net Kurt Jaeger pi@lf.net

7
src/buffer.c
View File

@@ -959,11 +959,8 @@ archive_is_dev (void)
static void static void
short_read (idx_t status) short_read (idx_t status)
{ {
idx_t left; /* bytes left */ idx_t left = record_size - status; /* bytes left to read */
char *more; /* pointer to next byte to read */ char *more = (char *) record_start + status; /* address of next read */
more = record_start->buffer + status;
left = record_size - status;
if (left && left % BLOCKSIZE == 0 if (left && left % BLOCKSIZE == 0
&& (warning_option & WARN_RECORD_SIZE) && (warning_option & WARN_RECORD_SIZE)