mirrors/tar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix minor integer overflow in xsparse.c

Browse Source 
* scripts/xsparse.c (read_xheader):
Don’t assume size_t fits in unsigned.
Make the version numbers off_t, not just unsigned.
This commit is contained in:
Paul Eggert
2024-08-08 16:38:28 -07:00
parent d1e72a536f
commit 88c2aa1616
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/xsparse.c
View File

@@ -160,8 +160,8 @@ get_var (FILE *fp, char **name, char **value)
static char *outname; static char *outname;
static off_t outsize; static off_t outsize;
static unsigned int version_major; static off_t version_major;
static unsigned int version_minor; static off_t version_minor;
static void static void
read_xheader (char *name) read_xheader (char *name)
@@ -190,11 +190,11 @@ read_xheader (char *name)
} }
else if (strcmp (kw, "major") == 0) else if (strcmp (kw, "major") == 0)
{ {
version_major = string_to_size (val, NULL, SIZE_MAX); version_major = string_to_off (val, NULL);
} }
else if (strcmp (kw, "minor") == 0) else if (strcmp (kw, "minor") == 0)
{ {
version_minor = string_to_size (val, NULL, SIZE_MAX); version_minor = string_to_off (val, NULL);
} }
else if (strcmp (kw, "realsize") == 0 else if (strcmp (kw, "realsize") == 0
|| strcmp (kw, "size") == 0) || strcmp (kw, "size") == 0)