4e742fc867
Problem and fix reported by Pavel Cahyna in https://lists.gnu.org/r/bug-tar/2025-01/msg00000.html * src/extract.c (extract_dir): With --no-overwrite-dir, skip the chmod if the directory already exists. * tests/extrac23.at (--no-overwrite-dir on empty directory): Move the part of the test that looks at a nonempty directory ... * tests/extrac30.at: ... to this new file, because the test now must be run as non-root. Adjust the test to match the new behavior. * tests/Makefile.am (TESTSUITE_AT), tests/testsuite.at: Add it.
45 lines
1.5 KiB
Plaintext
45 lines
1.5 KiB
Plaintext
# Test suite for GNU tar. -*- Autotest -*-
|
|
# Copyright 2020-2025 Free Software Foundation, Inc.
|
|
#
|
|
# This file is part of GNU tar.
|
|
#
|
|
# GNU tar is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# GNU tar is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
AT_SETUP([--no-overwrite-dir on empty directory])
|
|
AT_KEYWORDS([extract extrac23 no-overwrite-dir])
|
|
|
|
# Description: Implementation of the --no-overwrite-dir option was flawed in
|
|
# tar versions up to 1.32.90. This option is intended to preserve metadata
|
|
# of existing directories. In fact it worked only for non-empty directories.
|
|
#
|
|
# Reported by: Michael Kaufmann <mail@michael-kaufmann.ch>
|
|
# References: <20200207112934.Horde.anXzYhAj2CHiwUrw5CuT0G-@webmail.michael-kaufmann.ch>,
|
|
# https://lists.gnu.org/archive/html/bug-tar/2020-02/msg00003.html
|
|
|
|
AT_TAR_CHECK([
|
|
# Test if the directory permissions are restored properly.
|
|
mkdir dir
|
|
chmod 755 dir
|
|
tar cf a.tar dir
|
|
chmod 777 dir
|
|
tar -xf a.tar --no-overwrite-dir
|
|
genfile --stat=mode.777 dir
|
|
|
|
find dir
|
|
],
|
|
[0],
|
|
[777
|
|
dir
|
|
])
|
|
AT_CLEANUP
|