diff --git a/consensus/invalid_test.go b/consensus/invalid_test.go index 907693c57..5b161dd71 100644 --- a/consensus/invalid_test.go +++ b/consensus/invalid_test.go @@ -19,7 +19,7 @@ import ( func TestReactorInvalidPrecommit(t *testing.T) { N := 4 css, cleanup := randConsensusNet(N, "consensus_reactor_test", newMockTickerFunc(true), newCounter) - defer cleanup() + t.Cleanup(cleanup) for i := 0; i < 4; i++ { ticker := NewTimeoutTicker() @@ -43,7 +43,7 @@ func TestReactorInvalidPrecommit(t *testing.T) { invalidDoPrevoteFunc(t, height, round, byzVal, byzR.Switch, pv) } byzVal.mtx.Unlock() - defer stopConsensusNet(log.TestingLogger(), reactors, eventBuses) + t.Cleanup(func() { stopConsensusNet(log.TestingLogger(), reactors, eventBuses) }) // wait for a bunch of blocks // TODO: make this tighter by ensuring the halt happens by block 2 diff --git a/consensus/mempool_test.go b/consensus/mempool_test.go index db9662acb..c53185048 100644 --- a/consensus/mempool_test.go +++ b/consensus/mempool_test.go @@ -26,7 +26,8 @@ func assertMempool(txn txNotifier) mempl.Mempool { func TestMempoolNoProgressUntilTxsAvailable(t *testing.T) { config := ResetConfig("consensus_mempool_txs_available_test") - defer os.RemoveAll(config.RootDir) + t.Cleanup(func() { _ = os.RemoveAll(config.RootDir) }) + config.Consensus.CreateEmptyBlocks = false state, privVals := randGenesisState(1, false, 10) cs := newStateWithConfig(config, state, privVals[0], NewCounterApplication()) @@ -45,7 +46,7 @@ func TestMempoolNoProgressUntilTxsAvailable(t *testing.T) { func TestMempoolProgressAfterCreateEmptyBlocksInterval(t *testing.T) { config := ResetConfig("consensus_mempool_txs_available_test") - defer os.RemoveAll(config.RootDir) + t.Cleanup(func() { _ = os.RemoveAll(config.RootDir) }) config.Consensus.CreateEmptyBlocksInterval = ensureTimeout state, privVals := randGenesisState(1, false, 10) @@ -63,7 +64,8 @@ func TestMempoolProgressAfterCreateEmptyBlocksInterval(t *testing.T) { func TestMempoolProgressInHigherRound(t *testing.T) { config := ResetConfig("consensus_mempool_txs_available_test") - defer os.RemoveAll(config.RootDir) + t.Cleanup(func() { _ = os.RemoveAll(config.RootDir) }) + config.Consensus.CreateEmptyBlocks = false state, privVals := randGenesisState(1, false, 10) cs := newStateWithConfig(config, state, privVals[0], NewCounterApplication()) diff --git a/consensus/replay_test.go b/consensus/replay_test.go index 2970f15ed..85b196215 100644 --- a/consensus/replay_test.go +++ b/consensus/replay_test.go @@ -83,11 +83,11 @@ func startNewStateAndWaitForBlock(t *testing.T, consensusReplayConfig *cfg.Confi err := cs.Start() require.NoError(t, err) - defer func() { + t.Cleanup(func() { if err := cs.Stop(); err != nil { t.Error(err) } - }() + }) // This is just a signal that we haven't halted; its not something contained // in the WAL itself. Assuming the consensus state is running, replay of any @@ -658,7 +658,7 @@ func testHandshakeReplay(t *testing.T, config *cfg.Config, nBlocks int, mode uin var genesisState sm.State if testValidatorsChange { testConfig := ResetConfig(fmt.Sprintf("%s_%v_m", t.Name(), mode)) - defer os.RemoveAll(testConfig.RootDir) + t.Cleanup(func() { _ = os.RemoveAll(testConfig.RootDir) }) stateDB = dbm.NewMemDB() genesisState = sim.GenesisState @@ -668,7 +668,7 @@ func testHandshakeReplay(t *testing.T, config *cfg.Config, nBlocks int, mode uin store = newMockBlockStore(config, genesisState.ConsensusParams) } else { // test single node testConfig := ResetConfig(fmt.Sprintf("%s_%v_s", t.Name(), mode)) - defer os.RemoveAll(testConfig.RootDir) + t.Cleanup(func() { _ = os.RemoveAll(testConfig.RootDir) }) walBody, err := WALWithNBlocks(t, numBlocks) require.NoError(t, err) walFile := tempWALWithData(walBody) @@ -885,7 +885,7 @@ func TestHandshakePanicsIfAppReturnsWrongAppHash(t *testing.T) { // - 0x02 // - 0x03 config := ResetConfig("handshake_test_") - defer os.RemoveAll(config.RootDir) + t.Cleanup(func() { os.RemoveAll(config.RootDir) }) privVal := privval.LoadFilePV(config.PrivValidatorKeyFile(), config.PrivValidatorStateFile()) const appVersion = 0x0 pubKey, err := privVal.GetPubKey() @@ -1220,7 +1220,8 @@ func TestHandshakeUpdatesValidators(t *testing.T) { clientCreator := proxy.NewLocalClientCreator(app) config := ResetConfig("handshake_test_") - defer os.RemoveAll(config.RootDir) + t.Cleanup(func() { _ = os.RemoveAll(config.RootDir) }) + privVal := privval.LoadFilePV(config.PrivValidatorKeyFile(), config.PrivValidatorStateFile()) pubKey, err := privVal.GetPubKey() require.NoError(t, err)