From 1ddbfa62a7132a36bfccc56ddc430fd778ac2a12 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Wed, 7 Dec 2022 10:10:48 -0300 Subject: [PATCH] Mention tx_max_bytes in the tutorials (#9809) (#9813) Updates the discussion of prepareProposal in the go tutorials to mention tx_max_bytes limitation to transaction set size. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed (cherry picked from commit ba84060b075984b21873e2176f15172a8f25068d) Co-authored-by: Lasaro Camargos --- docs/tutorials/go-built-in.md | 3 ++- docs/tutorials/go.md | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/tutorials/go-built-in.md b/docs/tutorials/go-built-in.md index 7afad2f3c..14d754244 100644 --- a/docs/tutorials/go-built-in.md +++ b/docs/tutorials/go-built-in.md @@ -461,7 +461,8 @@ When Tendermint Core sees that valid transactions (validated through `CheckTx`) included in blocks, it groups some of these transactions and then gives the application a chance to modify the group by invoking `PrepareProposal`. -The application is free to modify the group before returning from the call. +The application is free to modify the group before returning from the call, as long as the resulting set +does not use more bytes than `RequestPrepareProposal.max_tx_bytes' For example, the application may reorder, add, or even remove transactions from the group to improve the execution of the block once accepted. In the following code, the application simply returns the unmodified group of transactions: diff --git a/docs/tutorials/go.md b/docs/tutorials/go.md index c12f36f41..4dd3dcb20 100644 --- a/docs/tutorials/go.md +++ b/docs/tutorials/go.md @@ -460,7 +460,8 @@ When Tendermint Core sees that valid transactions (validated through `CheckTx`) included in blocks, it groups some of these transactions and then gives the application a chance to modify the group by invoking `PrepareProposal`. -The application is free to modify the group before returning from the call. +The application is free to modify the group before returning from the call, as long as the resulting set +does not use more bytes than `RequestPrepareProposal.max_tx_bytes' For example, the application may reorder, add, or even remove transactions from the group to improve the execution of the block once accepted. In the following code, the application simply returns the unmodified group of transactions: