diff --git a/internal/consensus/byzantine_test.go b/internal/consensus/byzantine_test.go index 055eef770..17b76b9dc 100644 --- a/internal/consensus/byzantine_test.go +++ b/internal/consensus/byzantine_test.go @@ -176,7 +176,6 @@ func TestByzantinePrevoteEquivocation(t *testing.T) { require.NotNil(t, lazyNodeState.privValidator) var commit *types.Commit - var votes []*types.Vote switch { case lazyNodeState.Height == lazyNodeState.state.InitialHeight: // We're creating a proposal for the first block. @@ -185,7 +184,6 @@ func TestByzantinePrevoteEquivocation(t *testing.T) { case lazyNodeState.LastCommit.HasTwoThirdsMajority(): // Make the commit from LastCommit commit = lazyNodeState.LastCommit.MakeCommit() - votes = lazyNodeState.LastCommit.GetVotes() default: // This shouldn't happen. lazyNodeState.logger.Error("enterPropose: Cannot propose anything: No commit for the previous block") return diff --git a/internal/state/execution_test.go b/internal/state/execution_test.go index 37db51ad0..a25242c6e 100644 --- a/internal/state/execution_test.go +++ b/internal/state/execution_test.go @@ -665,6 +665,10 @@ func TestPrepareProposalRemoveTxs(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) defer cancel() + logger := log.TestingLogger() + eventBus := eventbus.NewDefault(logger) + require.NoError(t, eventBus.Start(ctx)) + state, stateDB, privVals := makeState(t, 1, height) stateStore := sm.NewStore(stateDB) @@ -686,19 +690,19 @@ func TestPrepareProposalRemoveTxs(t *testing.T) { TxRecords: trs, }, nil) - cc := abciclient.NewLocalCreator(app) - logger := log.TestingLogger() - proxyApp := proxy.NewAppConns(cc, logger, proxy.NopMetrics()) + cc := abciclient.NewLocalClient(logger, app) + proxyApp := proxy.New(cc, logger, proxy.NopMetrics()) err := proxyApp.Start(ctx) require.NoError(t, err) blockExec := sm.NewBlockExecutor( stateStore, logger, - proxyApp.Consensus(), + proxyApp, mp, evpool, nil, + eventBus, ) pa, _ := state.Validators.GetByIndex(0) commit := makeValidCommit(ctx, t, height, types.BlockID{}, state.Validators, privVals) @@ -722,6 +726,10 @@ func TestPrepareProposalAddedTxsIncluded(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) defer cancel() + logger := log.TestingLogger() + eventBus := eventbus.NewDefault(logger) + require.NoError(t, eventBus.Start(ctx)) + state, stateDB, privVals := makeState(t, 1, height) stateStore := sm.NewStore(stateDB) @@ -743,19 +751,19 @@ func TestPrepareProposalAddedTxsIncluded(t *testing.T) { TxRecords: trs, }, nil) - cc := abciclient.NewLocalCreator(app) - logger := log.TestingLogger() - proxyApp := proxy.NewAppConns(cc, logger, proxy.NopMetrics()) + cc := abciclient.NewLocalClient(logger, app) + proxyApp := proxy.New(cc, logger, proxy.NopMetrics()) err := proxyApp.Start(ctx) require.NoError(t, err) blockExec := sm.NewBlockExecutor( stateStore, logger, - proxyApp.Consensus(), + proxyApp, mp, evpool, nil, + eventBus, ) pa, _ := state.Validators.GetByIndex(0) commit := makeValidCommit(ctx, t, height, types.BlockID{}, state.Validators, privVals) @@ -777,6 +785,10 @@ func TestPrepareProposalReorderTxs(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) defer cancel() + logger := log.TestingLogger() + eventBus := eventbus.NewDefault(logger) + require.NoError(t, eventBus.Start(ctx)) + state, stateDB, privVals := makeState(t, 1, height) stateStore := sm.NewStore(stateDB) @@ -797,19 +809,19 @@ func TestPrepareProposalReorderTxs(t *testing.T) { TxRecords: trs, }, nil) - cc := abciclient.NewLocalCreator(app) - logger := log.TestingLogger() - proxyApp := proxy.NewAppConns(cc, logger, proxy.NopMetrics()) + cc := abciclient.NewLocalClient(logger, app) + proxyApp := proxy.New(cc, logger, proxy.NopMetrics()) err := proxyApp.Start(ctx) require.NoError(t, err) blockExec := sm.NewBlockExecutor( stateStore, logger, - proxyApp.Consensus(), + proxyApp, mp, evpool, nil, + eventBus, ) pa, _ := state.Validators.GetByIndex(0) commit := makeValidCommit(ctx, t, height, types.BlockID{}, state.Validators, privVals) @@ -831,6 +843,10 @@ func TestPrepareProposalModifiedTxFalse(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) defer cancel() + logger := log.TestingLogger() + eventBus := eventbus.NewDefault(logger) + require.NoError(t, eventBus.Start(ctx)) + state, stateDB, privVals := makeState(t, 1, height) stateStore := sm.NewStore(stateDB) @@ -856,19 +872,19 @@ func TestPrepareProposalModifiedTxFalse(t *testing.T) { TxRecords: trs, }, nil) - cc := abciclient.NewLocalCreator(app) - logger := log.TestingLogger() - proxyApp := proxy.NewAppConns(cc, logger, proxy.NopMetrics()) + cc := abciclient.NewLocalClient(logger, app) + proxyApp := proxy.New(cc, logger, proxy.NopMetrics()) err := proxyApp.Start(ctx) require.NoError(t, err) blockExec := sm.NewBlockExecutor( stateStore, logger, - proxyApp.Consensus(), + proxyApp, mp, evpool, nil, + eventBus, ) pa, _ := state.Validators.GetByIndex(0) commit := makeValidCommit(ctx, t, height, types.BlockID{}, state.Validators, privVals)