mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-07 13:55:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

address discrepancies between spec and implementation (#322)

Browse Source
This commit is contained in:
Callum Waters
2021-07-16 12:49:15 +02:00
committed by GitHub
parent f790b6f903
commit 24f22eeb52
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/light-client/detection/detection_003_reviewed.md
View File

@@ -457,6 +457,10 @@ we refer to a variable of the following type
type LightClientAttackEvidence struct { type LightClientAttackEvidence struct {
ConflictingBlock LightBlock ConflictingBlock LightBlock
CommonHeight int64 CommonHeight int64
// Evidence also includes application specific data which is not
// part of verification but is sent to the application once the
// evidence gets committed on chain.
} }
``` ```
@@ -698,6 +702,10 @@ func CreateEvidenceForPeer(peer PeerID, root LightBlock, trace LightStore)
// we can create evidence for submission to the secondary // we can create evidence for submission to the secondary
ev := new InternalEvidence; ev := new InternalEvidence;
ev.Evidence.ConflictingBlock := trace[i]; ev.Evidence.ConflictingBlock := trace[i];
// CommonHeight is used to indicate the type of attack
// if the CommonHeight != ConflictingBlock.Height this
// is by definition a lunatic attack else it is an
// equivocation attack
ev.Evidence.CommonHeight := common.Height; ev.Evidence.CommonHeight := common.Height;
ev.Peer := peer ev.Peer := peer
return (ev, common, auxLS, FoundEvidence) return (ev, common, auxLS, FoundEvidence)

2
spec/light-client/verification/verification_001_published.md
View File

@@ -472,8 +472,6 @@ type LightBlock struct {
Header Header Header Header
Commit Commit Commit Commit
Validators ValidatorSet Validators ValidatorSet
NextValidators ValidatorSet
Provider PeerID
} }
``` ```

2
spec/light-client/verification/verification_002_draft.md
View File

@@ -486,8 +486,6 @@ type LightBlock struct {
Header Header Header Header
Commit Commit Commit Commit
Validators ValidatorSet Validators ValidatorSet
NextValidators ValidatorSet
Provider PeerID
} }
``` ```