From 2a49070299b3680fcfdd8637355fe6d7ff3c94a7 Mon Sep 17 00:00:00 2001 From: William Banfield Date: Wed, 23 Feb 2022 10:59:54 -0500 Subject: [PATCH] ProcessProposal comment fix --- internal/consensus/state.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/consensus/state.go b/internal/consensus/state.go index 78f36f4ff..7f2045dcd 100644 --- a/internal/consensus/state.go +++ b/internal/consensus/state.go @@ -1453,12 +1453,13 @@ func (cs *State) defaultDoPrevote(ctx context.Context, height int64, round int32 } /* - Before prevoting on the block received from the proposer for the current round and height, - we request the Application, via `ProcessProposal` ABCI call, to confirm that the block is - valid. If the Application does not accept the block, Tendermint prevotes `nil`. + The block has now passed Tendermint's validation rules. + Before prevoting the block received from the proposer for the current round and height, + we request the Application, via the ProcessProposal, ABCI call to confirm that the block is + valid. If the Application does not accept the block, Tendermint prevotes nil. WARNING: misuse of block rejection by the Application can seriously compromise Tendermint's - liveness properties. Please see `PrepareProposal`-`ProcessProposal` coherence and determinism + liveness properties. Please see PrepareProposal-ProcessProposal coherence and determinism properties in the ABCI++ specification. */ isAppValid, err := cs.blockExec.ProcessProposal(ctx, cs.ProposalBlock, cs.state)