From 471f7a15ac914b6767cd351ae54991b7a2d41b12 Mon Sep 17 00:00:00 2001 From: William Banfield <4561443+williambanfield@users.noreply.github.com> Date: Tue, 4 Jan 2022 15:13:10 -0500 Subject: [PATCH 1/2] Update docs/architecture/adr-074-timeout-params.md Co-authored-by: M. J. Fromberger --- docs/architecture/adr-074-timeout-params.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/architecture/adr-074-timeout-params.md b/docs/architecture/adr-074-timeout-params.md index e806c2ccb..74e628048 100644 --- a/docs/architecture/adr-074-timeout-params.md +++ b/docs/architecture/adr-074-timeout-params.md @@ -162,7 +162,7 @@ message TimeoutParams { } ``` -This new `message` will then be added as a field into the [`ConsensusParams` +This new message will be added as a field into the [`ConsensusParams` message][consensus-params-proto]. The same default values that are [currently set for these parameters][current-timeout-defaults] in the local configuration file will be used as the defaults for these new consensus parameters in the From 5f6a2c3101b7eadfe749e28c2be9a4b4b3740410 Mon Sep 17 00:00:00 2001 From: William Banfield <4561443+williambanfield@users.noreply.github.com> Date: Tue, 4 Jan 2022 15:13:25 -0500 Subject: [PATCH 2/2] Update docs/architecture/adr-074-timeout-params.md Co-authored-by: M. J. Fromberger --- docs/architecture/adr-074-timeout-params.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/architecture/adr-074-timeout-params.md b/docs/architecture/adr-074-timeout-params.md index 74e628048..ace902ccf 100644 --- a/docs/architecture/adr-074-timeout-params.md +++ b/docs/architecture/adr-074-timeout-params.md @@ -168,9 +168,9 @@ set for these parameters][current-timeout-defaults] in the local configuration file will be used as the defaults for these new consensus parameters in the [consensus parameter defaults][default-consensus-params]. -Validation of these new parameters will be identical to their [validation -currently][time-param-validation]. -Namely, these parameters must be non-negative. +The new consensus parameters will be subject to the same +[validity rules][time-param-validation] as the current configuration values, +namely, each value must be non-negative. ### Removal of Old Parameters