abci: remove counter app (#6684)

* remove counter app

* remove unneeeded ci

* lint fix

* modify tx sizes

* cleanup docs

* Update abci/cmd/abci-cli/abci-cli.go

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

* Update docs/app-dev/getting-started.md

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

* Update docs/app-dev/getting-started.md

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

* bring back comment

* migrate to kvstore and not persistent

* remove unused func

* test persistent

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

test/README.md

@@ -10,8 +10,6 @@ and run the following tests in docker containers:
     - includes test coverage
 - app tests
     - kvstore app over socket
-    - counter app over socket
-    - counter app over grpc
 - persistence tests
     - crash tendermint at each of many predefined points, restart, and ensure it syncs properly with the app
 

test/app/test.sh

@@ -2,9 +2,6 @@
 set -ex
 
 #- kvstore over socket, curl
-#- counter over socket, curl
-#- counter over grpc, curl
-#- counter over grpc, grpc
 
 # TODO: install everything
 
@@ -45,57 +42,6 @@ function kvstore_over_socket_reorder(){
     kill -9 $pid_kvstore $pid_tendermint
 }
 
-
-function counter_over_socket() {
-    rm -rf $TMHOME
-    tendermint init validator
-    echo "Starting counter_over_socket"
-    abci-cli counter --serial > /dev/null &
-    pid_counter=$!
-    tendermint start --mode validator > tendermint.log &
-    pid_tendermint=$!
-    sleep 5
-
-    echo "running test"
-    bash test/app/counter_test.sh "Counter over Socket"
-
-    kill -9 $pid_counter $pid_tendermint
-}
-
-function counter_over_grpc() {
-    rm -rf $TMHOME
-    tendermint init validator
-    echo "Starting counter_over_grpc"
-    abci-cli counter --serial --abci grpc > /dev/null &
-    pid_counter=$!
-    tendermint start --mode validator --abci grpc > tendermint.log &
-    pid_tendermint=$!
-    sleep 5
-
-    echo "running test"
-    bash test/app/counter_test.sh "Counter over GRPC"
-
-    kill -9 $pid_counter $pid_tendermint
-}
-
-function counter_over_grpc_grpc() {
-    rm -rf $TMHOME
-    tendermint init validator
-    echo "Starting counter_over_grpc_grpc (ie. with grpc broadcast_tx)"
-    abci-cli counter --serial --abci grpc > /dev/null &
-    pid_counter=$!
-    sleep 1
-    GRPC_PORT=36656
-    tendermint start --mode validator --abci grpc --rpc.grpc-laddr tcp://localhost:$GRPC_PORT > tendermint.log &
-    pid_tendermint=$!
-    sleep 5
-
-    echo "running test"
-    GRPC_BROADCAST_TX=true bash test/app/counter_test.sh "Counter over GRPC via GRPC BroadcastTx"
-
-    kill -9 $pid_counter $pid_tendermint
-}
-
 case "$1" in 
     "kvstore_over_socket")
     kvstore_over_socket
@@ -103,25 +49,10 @@ case "$1" in
 "kvstore_over_socket_reorder")
     kvstore_over_socket_reorder
     ;;
-    "counter_over_socket")
-    counter_over_socket
-    ;;
-"counter_over_grpc")
-    counter_over_grpc
-    ;;
-    "counter_over_grpc_grpc")
-    counter_over_grpc_grpc
-    ;;
 *)
     echo "Running all"
     kvstore_over_socket
     echo ""
     kvstore_over_socket_reorder
     echo ""
-    counter_over_socket
-    echo ""
-    counter_over_grpc
-    echo ""
-    counter_over_grpc_grpc
 esac
-