From 36decbb4c8829f13c6368dc02dd8f17d7d867d89 Mon Sep 17 00:00:00 2001 From: William Banfield Date: Fri, 21 Oct 2022 12:42:51 -0400 Subject: [PATCH] remove superflous extra funcs in mempool --- mempool/v0/reactor.go | 24 ------------------------ mempool/v1/reactor.go | 38 -------------------------------------- 2 files changed, 62 deletions(-) diff --git a/mempool/v0/reactor.go b/mempool/v0/reactor.go index e4f54b8bb..28d743ff6 100644 --- a/mempool/v0/reactor.go +++ b/mempool/v0/reactor.go @@ -5,7 +5,6 @@ import ( "fmt" "time" - "github.com/cosmos/gogoproto/proto" cfg "github.com/tendermint/tendermint/config" "github.com/tendermint/tendermint/libs/clist" "github.com/tendermint/tendermint/libs/log" @@ -268,29 +267,6 @@ func (memR *Reactor) broadcastTxRoutine(peer p2p.Peer) { } } -func msgFromProto(m proto.Message) (TxsMessage, error) { - msg := m.(*protomem.Message) - var message TxsMessage - if i, ok := msg.Sum.(*protomem.Message_Txs); ok { - txs := i.Txs.GetTxs() - - if len(txs) == 0 { - return message, errors.New("empty TxsMessage") - } - - decoded := make([]types.Tx, len(txs)) - for j, tx := range txs { - decoded[j] = types.Tx(tx) - } - - message = TxsMessage{ - Txs: decoded, - } - return message, nil - } - return message, fmt.Errorf("msg type: %T is not supported", msg) -} - // TxsMessage is a Message containing transactions. type TxsMessage struct { Txs []types.Tx diff --git a/mempool/v1/reactor.go b/mempool/v1/reactor.go index b812cf043..e3f12abf3 100644 --- a/mempool/v1/reactor.go +++ b/mempool/v1/reactor.go @@ -5,8 +5,6 @@ import ( "fmt" "time" - "github.com/cosmos/gogoproto/proto" - cfg "github.com/tendermint/tendermint/config" "github.com/tendermint/tendermint/libs/clist" "github.com/tendermint/tendermint/libs/log" @@ -275,42 +273,6 @@ func (memR *Reactor) broadcastTxRoutine(peer p2p.Peer) { //----------------------------------------------------------------------------- // Messages -func decodeMsg(bz []byte) (TxsMessage, error) { - msg := protomem.Message{} - err := msg.Unmarshal(bz) - if err != nil { - return TxsMessage{}, err - } - - return protoToMsg(&msg) -} - -func protoToMsg(m proto.Message) (TxsMessage, error) { - msg := m.(*protomem.Message) - var message TxsMessage - - if i, ok := msg.Sum.(*protomem.Message_Txs); ok { - txs := i.Txs.GetTxs() - - if len(txs) == 0 { - return message, errors.New("empty TxsMessage") - } - - decoded := make([]types.Tx, len(txs)) - for j, tx := range txs { - decoded[j] = types.Tx(tx) - } - - message = TxsMessage{ - Txs: decoded, - } - return message, nil - } - return message, fmt.Errorf("msg type: %T is not supported", msg) -} - -//------------------------------------- - // TxsMessage is a Message containing transactions. type TxsMessage struct { Txs []types.Tx