From 393a02a729e9845adf092f053678d426cdd79a22 Mon Sep 17 00:00:00 2001 From: Aleksandr Bezobchuk Date: Fri, 13 Aug 2021 21:40:14 -0400 Subject: [PATCH] rpc: log update (#6825) We INFO log every `ABCIQuery`. This can output a tremendous amount of noise in the logs, can cause cosmovisor to completely crash and slows down the node due to I/O. This log is completely unnecessary. Let's get this backported into v0.43 and get that into v0.43 and v0.42 releases of the SDK /cc @marbar3778 --- CHANGELOG_PENDING.md | 2 ++ rpc/core/abci.go | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md index a0a47de34..e8d687f1c 100644 --- a/CHANGELOG_PENDING.md +++ b/CHANGELOG_PENDING.md @@ -108,6 +108,8 @@ Friendly reminder: We have a [bug bounty program](https://hackerone.com/tendermi - [statesync/event] \#6700 Emit statesync status start/end event (@JayT106) ### IMPROVEMENTS + +- [rpc] \#6825 Remove egregious INFO log from `ABCI#Query` RPC. (@alexanderbez) - [libs/log] Console log formatting changes as a result of \#6534 and \#6589. (@tychoish) - [statesync] \#6566 Allow state sync fetchers and request timeout to be configurable. (@alexanderbez) - [types] \#6478 Add `block_id` to `newblock` event (@jeebster) diff --git a/rpc/core/abci.go b/rpc/core/abci.go index 613eaec8b..ce705ba90 100644 --- a/rpc/core/abci.go +++ b/rpc/core/abci.go @@ -26,7 +26,7 @@ func (env *Environment) ABCIQuery( if err != nil { return nil, err } - env.Logger.Info("ABCIQuery", "path", path, "data", data, "result", resQuery) + return &ctypes.ResultABCIQuery{Response: *resQuery}, nil } @@ -37,5 +37,6 @@ func (env *Environment) ABCIInfo(ctx *rpctypes.Context) (*ctypes.ResultABCIInfo, if err != nil { return nil, err } + return &ctypes.ResultABCIInfo{Response: *resInfo}, nil }