From 3b0ecf72462b19414c6b408eba7add7ecef0e35e Mon Sep 17 00:00:00 2001 From: William Banfield Date: Mon, 20 Sep 2021 17:37:31 -0400 Subject: [PATCH] update comments --- internal/consensus/state_test.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/internal/consensus/state_test.go b/internal/consensus/state_test.go index f763e2281..b02187783 100644 --- a/internal/consensus/state_test.go +++ b/internal/consensus/state_test.go @@ -692,6 +692,8 @@ func TestStateLockPOLRelock(t *testing.T) { ensureNewProposal(proposalCh, height, round) // go to prevote, node should prevote for locked block (not the new proposal) - this is relocking + // TODO: Ensure we prevote for the proposal if it is valid and from a round greater than + // the valid round: https://github.com/tendermint/tendermint/issues/6850. ensurePrevote(voteCh, height, round) validatePrevote(t, cs1, round, vss[0], theBlockHash) @@ -799,7 +801,10 @@ func TestStatePOLDoesNotUnlock(t *testing.T) { ensureNewProposal(proposalCh, height, round) - // go to prevote, prevote for locked block (not proposal) + // prevote for the locked block. We do not currently prevote for the + // proposal. + // TODO: do not prevote the locked block if it does not match the proposal. + // (https://github.com/tendermint/tendermint/issues/6850) ensurePrevote(voteCh, height, round) validatePrevote(t, cs1, round, vss[0], theBlockHash) // add >2/3 prevotes for nil from all other validators