Divergences in comparison with #9620. Part 4: Other changes spotted (#9927)

* Make mempool v1 UTs more predictable

* Simple changes

* Reuse new signVote tests in production code

* Fix `IsNil` problem from cherry-pick: should be `IsZero`

* Fix linter issue

* Apply suggestions from code review

Co-authored-by: Lasaro <lasaro@informal.systems>

* Addressed @lasarojc's comment

* Addressed @jmalicevic's comment

Co-authored-by: Lasaro <lasaro@informal.systems>
This commit is contained in:
Sergio Mena
2022-12-22 18:20:26 +01:00
committed by GitHub
parent 1332be0831
commit 4255d5d233
7 changed files with 85 additions and 62 deletions

View File

@@ -41,7 +41,7 @@ func (opts TrustOptions) ValidateBasic() error {
return errors.New("negative or zero period")
}
if opts.Height <= 0 {
return errors.New("negative or zero height")
return errors.New("zero or negative height")
}
if len(opts.Hash) != tmhash.Size {
return fmt.Errorf("expected hash size to be %d bytes, got %d bytes",