From 49d8c0b17479adc4f6afdd7ce708bd795e9a4c07 Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Fri, 3 Apr 2020 17:31:01 +0400 Subject: [PATCH] changelog: fix grammar --- CHANGELOG.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5eccbc855..5c03c90f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,13 +6,13 @@ This security release fixes: -### Denial of service 1 +### Denial of Service 1 -Tendermint 0.33.2 and earlier does not limit P2P connection requests number. -For each p2p connection, Tendermint allocates ~0.5MB. Even though this -memory is garbage collected once the connection is terminated (due to duplicate -IP or reaching a maximum number of inbound peers), temporary memory spikes can -lead to OOM (Out-Of-Memory) exceptions. +Tendermint 0.33.2 and earlier does not limit the number of P2P connection +requests. For each p2p connection, Tendermint allocates ~0.5MB. Even though +this memory is garbage collected once the connection is terminated (due to +duplicate IP or reaching a maximum number of inbound peers), temporary memory +spikes can lead to OOM (Out-Of-Memory) exceptions. Tendermint 0.33.3 (and 0.32.10) limits the total number of P2P incoming connection requests to to `p2p.max_num_inbound_peers + @@ -27,7 +27,7 @@ Notes: (https://www.nginx.com/blog/rate-limiting-nginx/). We may implement this in the future ([\#1696](https://github.com/tendermint/tendermint/issues/1696)). -### Denial of service 2 +### Denial of Service 2 Tendermint 0.33.2 and earlier does not reclaim `activeID` of a peer after it's removed in `Mempool` reactor. This does not happen all the time. It only @@ -36,7 +36,7 @@ added to all reactors. `RemovePeer` is therefore called before `AddPeer`, which leads to always growing memory (`activeIDs` map). The `activeIDs` map has a maximum size of 65535 and the node will panic if this map reaches the maximum. An attacker can create a lot of connection attempts (exploiting Denial of -service 1), which ultimately will lead to the node panicking. +Service 1), which ultimately will lead to the node panicking. Tendermint 0.33.3 (and 0.32.10) claims `activeID` for a peer in `InitPeer`, which is executed before `MConnection` is started. @@ -45,7 +45,7 @@ Notes: - `InitPeer` function was added to all reactors to combat a similar issue - [\#3338](https://github.com/tendermint/tendermint/issues/3338); -- Denial of service 2 is independent of Denial of service 1 and can be executed +- Denial of Service 2 is independent of Denial of Service 1 and can be executed without it. **All clients are recommended to upgrade**