From 4da3de79a77bb81b7f91eb4921f2708d214d6120 Mon Sep 17 00:00:00 2001 From: Anton Kaliaev Date: Sat, 3 Aug 2019 00:00:18 +0400 Subject: [PATCH] =?UTF-8?q?consensus:=20reduce=20"Error=20attempting=20to?= =?UTF-8?q?=20add=20vote"=20message=20severity=20(Er=E2=80=A6=20(#3871)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * consensus: reduce "Error attempting to add vote" message severity (Error -> Info) Fixes #3839 * add missing changelog entry --- CHANGELOG_PENDING.md | 3 +++ consensus/state.go | 8 +++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md index cfc4a7529..833fb6cc0 100644 --- a/CHANGELOG_PENDING.md +++ b/CHANGELOG_PENDING.md @@ -19,5 +19,8 @@ program](https://hackerone.com/tendermint). ### IMPROVEMENTS: +- [consensus] \#3839 Reduce "Error attempting to add vote" message severity (Error -> Info) + ### BUG FIXES: + - [config] \#3868 move misplaced `max_msg_bytes` into mempool section diff --git a/consensus/state.go b/consensus/state.go index a53e6b267..5dfeaf907 100644 --- a/consensus/state.go +++ b/consensus/state.go @@ -1518,9 +1518,11 @@ func (cs *ConsensusState) tryAddVote(vote *types.Vote, peerID p2p.ID) (bool, err cs.evpool.AddEvidence(voteErr.DuplicateVoteEvidence) return added, err } else { - // Probably an invalid signature / Bad peer. - // Seems this can also err sometimes with "Unexpected step" - perhaps not from a bad peer ? - cs.Logger.Error("Error attempting to add vote", "err", err) + // Either + // 1) bad peer OR + // 2) not a bad peer? this can also err sometimes with "Unexpected step" OR + // 3) tmkms use with multiple validators connecting to a single tmkms instance (https://github.com/tendermint/tendermint/issues/3839). + cs.Logger.Info("Error attempting to add vote", "err", err) return added, ErrAddingVote } }