From 4ddc46e0b7e297e827132ca64bf8f2fdd338e4d5 Mon Sep 17 00:00:00 2001 From: Thane Thomson Date: Tue, 29 Mar 2022 17:51:58 -0400 Subject: [PATCH] Validate vote extension signature against canonical vote extension Signed-off-by: Thane Thomson --- types/vote.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/vote.go b/types/vote.go index 301b5c8ba..8c72637c9 100644 --- a/types/vote.go +++ b/types/vote.go @@ -172,7 +172,8 @@ func (vote *Vote) Verify(chainID string, pubKey crypto.PubKey) error { if !pubKey.VerifySignature(VoteSignBytes(chainID, v), vote.Signature) { return ErrVoteInvalidSignature } - if vote.Extension != nil && !pubKey.VerifySignature(vote.Extension, vote.ExtensionSignature) { + extSignBytes := VoteExtensionSignBytes(chainID, v) + if vote.Extension != nil && !pubKey.VerifySignature(extSignBytes, vote.ExtensionSignature) { return ErrVoteInvalidSignature } return nil