make GoLint happy

This commit is contained in:
Anton Kaliaev
2017-04-20 13:36:39 +04:00
parent 590efc1040
commit 52d9cf080e
+12 -3
View File
@@ -7,12 +7,13 @@ import (
"reflect" "reflect"
"time" "time"
. "github.com/tendermint/go-common"
wire "github.com/tendermint/go-wire" wire "github.com/tendermint/go-wire"
) )
const ( const (
// PexChannel is a channel for PEX messages
PexChannel = byte(0x00) PexChannel = byte(0x00)
// period to ensure peers connected // period to ensure peers connected
defaultEnsurePeersPeriod = 30 * time.Second defaultEnsurePeersPeriod = 30 * time.Second
minNumOutboundPeers = 10 minNumOutboundPeers = 10
@@ -25,6 +26,8 @@ const (
// PEXReactor handles PEX (peer exchange) and ensures that an // PEXReactor handles PEX (peer exchange) and ensures that an
// adequate number of peers are connected to the switch. // adequate number of peers are connected to the switch.
//
// It uses `AddrBook` (address book) to store `NetAddress`es of the peers.
type PEXReactor struct { type PEXReactor struct {
BaseReactor BaseReactor
@@ -37,6 +40,7 @@ type PEXReactor struct {
maxMsgCountByPeer uint16 maxMsgCountByPeer uint16
} }
// NewPEXReactor creates new PEX reactor.
func NewPEXReactor(b *AddrBook) *PEXReactor { func NewPEXReactor(b *AddrBook) *PEXReactor {
r := &PEXReactor{ r := &PEXReactor{
book: b, book: b,
@@ -48,6 +52,7 @@ func NewPEXReactor(b *AddrBook) *PEXReactor {
return r return r
} }
// OnStart implements BaseService
func (r *PEXReactor) OnStart() error { func (r *PEXReactor) OnStart() error {
r.BaseReactor.OnStart() r.BaseReactor.OnStart()
r.book.Start() r.book.Start()
@@ -56,6 +61,7 @@ func (r *PEXReactor) OnStart() error {
return nil return nil
} }
// OnStop implements BaseService
func (r *PEXReactor) OnStop() { func (r *PEXReactor) OnStop() {
r.BaseReactor.OnStop() r.BaseReactor.OnStop()
r.book.Stop() r.book.Stop()
@@ -92,7 +98,7 @@ func (r *PEXReactor) AddPeer(p *Peer) {
} }
} }
// RemovePeer implements Reactor // RemovePeer implements Reactor by removing peer from the address book.
func (r *PEXReactor) RemovePeer(p *Peer, reason interface{}) { func (r *PEXReactor) RemovePeer(p *Peer, reason interface{}) {
addr := NewNetAddressString(p.ListenAddr) addr := NewNetAddressString(p.ListenAddr)
// addr will be ejected from the book // addr will be ejected from the book
@@ -130,7 +136,7 @@ func (r *PEXReactor) Receive(chID byte, src *Peer, msgBytes []byte) {
} }
} }
default: default:
log.Warn(Fmt("Unknown message type %v", reflect.TypeOf(msg))) log.Warn(fmt.Sprintf("Unknown message type %v", reflect.TypeOf(msg)))
} }
} }
@@ -271,6 +277,8 @@ const (
msgTypeAddrs = byte(0x02) msgTypeAddrs = byte(0x02)
) )
// PexMessage is a primary type for PEX messages. Underneath, it could contain
// either pexRequestMessage, or pexAddrsMessage messages.
type PexMessage interface{} type PexMessage interface{}
var _ = wire.RegisterInterface( var _ = wire.RegisterInterface(
@@ -279,6 +287,7 @@ var _ = wire.RegisterInterface(
wire.ConcreteType{&pexAddrsMessage{}, msgTypeAddrs}, wire.ConcreteType{&pexAddrsMessage{}, msgTypeAddrs},
) )
// DecodeMessage implements interface registered above.
func DecodeMessage(bz []byte) (msgType byte, msg PexMessage, err error) { func DecodeMessage(bz []byte) (msgType byte, msg PexMessage, err error) {
msgType = bz[0] msgType = bz[0]
n := new(int) n := new(int)