mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-05 04:55:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove some xxx comments and the config.mempool.recheck_empty (#2505)

Browse Source 
* remove some XXX

* config: remove Mempool.RecheckEmpty

* docs: remove recheck_empty
This commit is contained in:
Ethan Buchman
2018-09-30 13:28:34 -04:00
committed by GitHub
parent 69c7aa77bc
commit 52e21cebcf
11 changed files with 22 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mempool/mempool.go
View File

@@ -513,9 +513,7 @@ func (mem *Mempool) Update(
// Remove transactions that are already in txs.
goodTxs := mem.filterTxs(txsMap)
// Recheck mempool txs if any txs were committed in the block
// NOTE/XXX: in some apps a tx could be invalidated due to EndBlock,
// so we really still do need to recheck, but this is for debugging
if mem.config.Recheck && (mem.config.RecheckEmpty || len(goodTxs) > 0) {
if mem.config.Recheck && len(goodTxs) > 0 {
mem.logger.Info("Recheck txs", "numtxs", len(goodTxs), "height", height)
mem.recheckTxs(goodTxs)
// At this point, mem.txs are being rechecked.