From 5c547137f627e2728729b4147e4afe397aba27a5 Mon Sep 17 00:00:00 2001 From: Sam Kleinman Date: Wed, 17 Mar 2021 16:03:56 -0400 Subject: [PATCH] fix: make p2p evidence_pending test not timing dependent (#6252) --- evidence/reactor_test.go | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/evidence/reactor_test.go b/evidence/reactor_test.go index 459ebcc60..907e11294 100644 --- a/evidence/reactor_test.go +++ b/evidence/reactor_test.go @@ -382,23 +382,10 @@ func TestReactorBroadcastEvidence_Pending(t *testing.T) { require.NoError(t, rts.pools[secondary.NodeID].AddEvidence(evList[i])) } - rts.start(t) - // the secondary should have half the evidence as pending require.Equal(t, numEvidence/2, int(rts.pools[secondary.NodeID].Size())) - // adding the secondary node back in node back in - require.NoError(t, primary.PeerManager.Add(secondary.NodeAddress)) - - startAt := time.Now() - for { - if time.Since(startAt) > time.Second { - require.Fail(t, "could not reconnect the secondary in less than a second") - } - if primary.PeerManager.Status(secondary.NodeID) == p2p.PeerStatusUp { - break - } - } + rts.start(t) // The secondary reactor should have received all the evidence ignoring the // already pending evidence.